public inbox for linux-doc@vger.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org,
	Pingfan Liu <piliu@redhat.com>, Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH] Documentation: kdump: Clarify the default size of memory reserved by crashkernel low
Date: Tue, 19 Dec 2023 15:28:51 +0800	[thread overview]
Message-ID: <ZYFGMxkjfN3BVUq5@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20231218034020.15341-1-kernelfans@gmail.com>

On 12/18/23 at 11:40am, Pingfan Liu wrote:
> From: Pingfan Liu <piliu@redhat.com>
> 
> The default size reserved for crashkernel=,low is decided by the macro
> DEFAULT_CRASH_KERNEL_LOW_SIZE, which is based on arch.
> 
> Signed-off-by: Pingfan Liu <piliu@redhat.com>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Dave Young <dyoung@redhat.com>
> To: kexec@lists.infradead.org
> To: linux-doc@vger.kernel.org
> ---
>  Documentation/admin-guide/kdump/kdump.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kdump/kdump.rst b/Documentation/admin-guide/kdump/kdump.rst
> index 5762e7477a0c..a021ff155012 100644
> --- a/Documentation/admin-guide/kdump/kdump.rst
> +++ b/Documentation/admin-guide/kdump/kdump.rst
> @@ -310,8 +310,9 @@ crashkernel syntax
>     region above 4G, low memory under 4G is needed in this case. There are
>     three ways to get low memory:
>  
> -      1) Kernel will allocate at least 256M memory below 4G automatically
> -         if crashkernel=Y,low is not specified.
> +      1) Kernel will allocate a chunk of default size memory, which is based on
> +         architecture, below 4G automatically if crashkernel=Y,low is not
> +         specified.

Good catch, thx.

Acked-by: Baoquan He <bhe@redhat.com>

>        2) Let user specify low memory size instead.
>        3) Specified value 0 will disable low memory allocation::
>  
> -- 
> 2.31.1
> 


  reply	other threads:[~2023-12-19  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18  3:40 [PATCH] Documentation: kdump: Clarify the default size of memory reserved by crashkernel low Pingfan Liu
2023-12-19  7:28 ` Baoquan He [this message]
2024-01-16  8:47 ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYFGMxkjfN3BVUq5@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=kernelfans@gmail.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=piliu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox