[PATCH v3 0/3] Use proper printk format in appletbdrm

[PATCH v3 0/3] Use proper printk format in appletbdrm

[Aditya Garg]

The vsprint patch was originally being sent as a seperate patch [1], and
I was waiting it to be taken up. But as suggested by Petr, I'm sending
them via DRM.

v2:
Remove printf tests, will merge later through Kees' tree

v3:
Re-add printf tests, since 6.15-rc1 has the necessary commits merged now.

[1]: https://lore.kernel.org/lkml/1A03A5B4-93AC-4307-AE6A-4A4C4B7E9472@live.com/

Aditya Garg (2):
  printf: add tests for generic FourCCs
  drm/appletbdrm: use %p4cl instead of %p4cc

Hector Martin (1):
  lib/vsprintf: Add support for generic FourCCs by extending %p4cc

 Documentation/core-api/printk-formats.rst | 32 +++++++++++++++++++
 drivers/gpu/drm/tiny/appletbdrm.c         |  4 +--
 lib/tests/printf_kunit.c                  | 39 +++++++++++++++++++----
 lib/vsprintf.c                            | 35 ++++++++++++++++----
 scripts/checkpatch.pl                     |  2 +-
 5 files changed, 96 insertions(+), 16 deletions(-)

-- 
2.43.0

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote:
> The vsprint patch was originally being sent as a seperate patch [1], and
> I was waiting it to be taken up. But as suggested by Petr, I'm sending
> them via DRM.


Your message is detached from the thread, make sure you use proper tools, e.g.

`git format-patch --thread --cover-letter -v3 ...` gives the correct result.

...

> [1]: https://lore.kernel.org/lkml/1A03A5B4-93AC-4307-AE6A-4A4C4B7E9472@live.com/

Even here you can use Link: tag

Link: https://lore.kernel.org/lkml/1A03A5B4-93AC-4307-AE6A-4A4C4B7E9472@live.com/ [1]

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

[Aditya Garg]

> On 7 Apr 2025, at 7:26 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote:
>> The vsprint patch was originally being sent as a seperate patch [1], and
>> I was waiting it to be taken up. But as suggested by Petr, I'm sending
>> them via DRM.
> 
> 
> Your message is detached from the thread, make sure you use proper tools, e.g.

It's not a problem with tools, it's a problem with my email provider.

Microsoft now supports only oauth2 for SMTP, which git send-email doesn't support. I had done a few tests using msmtp with git send-email, but msmtp also had this detached from thread bug, since it doesn't read the message id specified by git send-email. I've been using macOS mail for a long time for kernel patches, but since it was a pain to reboot to macOS every time for this. So I just tried using thunderbird in Linux this time. Now this time, it was a configuration issue in thunderbird, in which it was making a copy of the sent email in my sent folder, resulting in 2 copies there. I replied to the copied one by mistake. I've finally fixed this issue as well, so should be good in future.

> 
> `git format-patch --thread --cover-letter -v3 ...` gives the correct result.
> 
> ...
> 
>> [1]: https://lore.kernel.org/lkml/1A03A5B4-93AC-4307-AE6A-4A4C4B7E9472@live.com/
> 
> Even here you can use Link: tag

Alright.
> 
> Link: https://lore.kernel.org/lkml/1A03A5B4-93AC-4307-AE6A-4A4C4B7E9472@live.com/ [1]
> 
> --
> With Best Regards,
> Andy Shevchenko
> 
> 

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 02:17:00PM +0000, Aditya Garg wrote:
> > On 7 Apr 2025, at 7:26 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote:
> >> The vsprint patch was originally being sent as a seperate patch [1], and
> >> I was waiting it to be taken up. But as suggested by Petr, I'm sending
> >> them via DRM.
> > 
> > Your message is detached from the thread, make sure you use proper tools, e.g.
> 
> It's not a problem with tools, it's a problem with my email provider.
> 
> Microsoft now supports only oauth2 for SMTP, which git send-email doesn't
> support. I had done a few tests using msmtp with git send-email, but msmtp
> also had this detached from thread bug, since it doesn't read the message id
> specified by git send-email. I've been using macOS mail for a long time for
> kernel patches, but since it was a pain to reboot to macOS every time for
> this. So I just tried using thunderbird in Linux this time. Now this time, it
> was a configuration issue in thunderbird, in which it was making a copy of
> the sent email in my sent folder, resulting in 2 copies there. I replied to
> the copied one by mistake. I've finally fixed this issue as well, so should
> be good in future.

There is a project called email-oauth2-proxy, which makes it transparent, so
just take your time and configure your box or find another email provider.
The above is not an excuse to break the process.

> > `git format-patch --thread --cover-letter -v3 ...` gives the correct result.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

[Aditya Garg]

On 07-04-2025 07:52 pm, Andy Shevchenko wrote:
> On Mon, Apr 07, 2025 at 02:17:00PM +0000, Aditya Garg wrote:
>>> On 7 Apr 2025, at 7:26 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>>> On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote:
>>>> The vsprint patch was originally being sent as a seperate patch [1], and
>>>> I was waiting it to be taken up. But as suggested by Petr, I'm sending
>>>> them via DRM.
>>>
>>> Your message is detached from the thread, make sure you use proper tools, e.g.
>>
>> It's not a problem with tools, it's a problem with my email provider.
>>
>> Microsoft now supports only oauth2 for SMTP, which git send-email doesn't
>> support. I had done a few tests using msmtp with git send-email, but msmtp
>> also had this detached from thread bug, since it doesn't read the message id
>> specified by git send-email. I've been using macOS mail for a long time for
>> kernel patches, but since it was a pain to reboot to macOS every time for
>> this. So I just tried using thunderbird in Linux this time. Now this time, it
>> was a configuration issue in thunderbird, in which it was making a copy of
>> the sent email in my sent folder, resulting in 2 copies there. I replied to
>> the copied one by mistake. I've finally fixed this issue as well, so should
>> be good in future.
> 
> There is a project called email-oauth2-proxy, which makes it transparent, so
> just take your time and configure your box or find another email provider.

I already have a way to get oauth2 tokens for Outlook, something similar to this.

> The above is not an excuse to break the process.

It was an honest mistake, and I just said I managed to fix it and should be good in the future right?
> 
>>> `git format-patch --thread --cover-letter -v3 ...` gives the correct result.
> 

Re: [PATCH v3 0/3] Use proper printk format in appletbdrm

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 07:57:08PM +0530, Aditya Garg wrote:
> On 07-04-2025 07:52 pm, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 02:17:00PM +0000, Aditya Garg wrote:
> >>> On 7 Apr 2025, at 7:26 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >>> On Mon, Apr 07, 2025 at 07:05:13PM +0530, Aditya Garg wrote:

> >>>> The vsprint patch was originally being sent as a seperate patch [1], and
> >>>> I was waiting it to be taken up. But as suggested by Petr, I'm sending
> >>>> them via DRM.
> >>>
> >>> Your message is detached from the thread, make sure you use proper tools, e.g.
> >>
> >> It's not a problem with tools, it's a problem with my email provider.
> >>
> >> Microsoft now supports only oauth2 for SMTP, which git send-email doesn't
> >> support. I had done a few tests using msmtp with git send-email, but msmtp
> >> also had this detached from thread bug, since it doesn't read the message id
> >> specified by git send-email. I've been using macOS mail for a long time for
> >> kernel patches, but since it was a pain to reboot to macOS every time for
> >> this. So I just tried using thunderbird in Linux this time. Now this time, it
> >> was a configuration issue in thunderbird, in which it was making a copy of
> >> the sent email in my sent folder, resulting in 2 copies there. I replied to
> >> the copied one by mistake. I've finally fixed this issue as well, so should
> >> be good in future.
> > 
> > There is a project called email-oauth2-proxy, which makes it transparent, so
> > just take your time and configure your box or find another email provider.
> 
> I already have a way to get oauth2 tokens for Outlook, something similar to this.
> 
> > The above is not an excuse to break the process.
> 
> It was an honest mistake, and I just said I managed to fix it and should be
> good in the future right?

Sure!

> >>> `git format-patch --thread --cover-letter -v3 ...` gives the correct result.

-- 
With Best Regards,
Andy Shevchenko