From: Daniel Vetter <daniel@ffwll.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] drm/doc: internals: remove section on PCI legacy support
Date: Fri, 12 Jan 2024 13:58:59 +0100 [thread overview]
Message-ID: <ZaE3k1042oCQdft0@phenom.ffwll.local> (raw)
In-Reply-To: <20240112051731.15722-1-rdunlap@infradead.org>
On Thu, Jan 11, 2024 at 09:17:31PM -0800, Randy Dunlap wrote:
> The functions that were described in this section of
> drm-internals.rst were removed in NOV-2023, along with all of the
> kernel-doc comments in the source file. This now causes a
> docs build warning, so remove that section of the documentation also.
>
> drivers/gpu/drm/drm_pci.c:1: warning: no structured comments found
>
> Fixes: 2504c7ec728b ("drm: Remove source code for non-KMS drivers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
Applied to drm-misc-next, thanks!
-Sima
> ---
> Documentation/gpu/drm-internals.rst | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff -- a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
> --- a/Documentation/gpu/drm-internals.rst
> +++ b/Documentation/gpu/drm-internals.rst
> @@ -153,18 +153,6 @@ Managed Resources
> .. kernel-doc:: include/drm/drm_managed.h
> :internal:
>
> -Bus-specific Device Registration and PCI Support
> -------------------------------------------------
> -
> -A number of functions are provided to help with device registration. The
> -functions deal with PCI and platform devices respectively and are only
> -provided for historical reasons. These are all deprecated and shouldn't
> -be used in new drivers. Besides that there's a few helpers for pci
> -drivers.
> -
> -.. kernel-doc:: drivers/gpu/drm/drm_pci.c
> - :export:
> -
> Open/Close, File Operations and IOCTLs
> ======================================
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2024-01-12 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 5:17 [PATCH] drm/doc: internals: remove section on PCI legacy support Randy Dunlap
2024-01-12 12:58 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaE3k1042oCQdft0@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox