Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline

Liam R. Howlett
2024-02-15T04:06:08Z

* Vlastimil Babka <vbabka@suse.cz> [240214 10:14]:
> On 2/13/24 03:08, Kent Overstreet wrote:
> > On Mon, Feb 12, 2024 at 04:31:14PM -0800, Kees Cook wrote:
> >> On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote:
> >> > From: Kent Overstreet <kent.overstreet@linux.dev>
> >> >
> >> > It seems we need to be more forceful with the compiler on this one.
> >>
> >> Sure, but why?
> >
> > Wasn't getting inlined without it, and that's one we do want inlined -
> > it's only called in one place.
>
> It would be better to mention this in the changelog so it's clear this is
> for performance and not e.g. needed for the code tagging to work as expected.

Since it's not needed specifically for this set, can we take this patch
out of the set (and any others) and get them upstream first?

My hope is to reduce the count of 35 patches. Less patches might get
more reviews and small things like this (should be, are?) easy enough to
get out of the way. But also, it sounds worth doing on its own.