Re: [RFC PATCH 06/20] dev_dax_iomap: Add CONFIG_DEV_DAX_IOMAP kernel build parameter

Jonathan Cameron
2024-02-26T12:34:20Z

On Fri, 23 Feb 2024 11:41:50 -0600
John Groves <John@Groves.net> wrote:

> Add the CONFIG_DEV_DAX_IOMAP kernel config parameter to control building
> of the iomap functionality to support fsdax on devdax.

I would squash with previous patch.

Only reason I ever see for separate Kconfig patches is when there is something
complex in the dependencies and you want to talk about it in depth in the
patch description. That's not true here so no need for separate patch.

>
> Signed-off-by: John Groves <john@groves.net>
> ---
> drivers/dax/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> index a88744244149..b1ebcc77120b 100644
> --- a/drivers/dax/Kconfig
> +++ b/drivers/dax/Kconfig
> @@ -78,4 +78,10 @@ config DEV_DAX_KMEM
>
> Say N if unsure.
>
> +config DEV_DAX_IOMAP
> + depends on DEV_DAX && DAX
> + def_bool y
> + help
> + Support iomap mapping of devdax devices (for FS-DAX file
> + systems that reside on character /dev/dax devices)
> endif