Re: [RFC PATCH 20/20] famfs: Add Kconfig and Makefile plumbing

Randy Dunlap
2024-02-24T01:50:30Z

Hi,

On 2/23/24 09:42, John Groves wrote:
> Add famfs Kconfig and Makefile, and hook into fs/Kconfig and fs/Makefile
>
> Signed-off-by: John Groves <john@groves.net>
> ---
> fs/Kconfig | 2 ++
> fs/Makefile | 1 +
> fs/famfs/Kconfig | 10 ++++++++++
> fs/famfs/Makefile | 5 +++++
> 4 files changed, 18 insertions(+)
> create mode 100644 fs/famfs/Kconfig
> create mode 100644 fs/famfs/Makefile
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 89fdbefd1075..8a11625a54a2 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -141,6 +141,8 @@ source "fs/autofs/Kconfig"
> source "fs/fuse/Kconfig"
> source "fs/overlayfs/Kconfig"
>
> +source "fs/famfs/Kconfig"
> +
> menu "Caches"
>
> source "fs/netfs/Kconfig"
> diff --git a/fs/Makefile b/fs/Makefile
> index c09016257f05..382c1ea4f4c3 100644
> --- a/fs/Makefile
> +++ b/fs/Makefile
> @@ -130,3 +130,4 @@ obj-$(CONFIG_EFIVAR_FS) += efivarfs/
> obj-$(CONFIG_EROFS_FS) += erofs/
> obj-$(CONFIG_VBOXSF_FS) += vboxsf/
> obj-$(CONFIG_ZONEFS_FS) += zonefs/
> +obj-$(CONFIG_FAMFS) += famfs/
> diff --git a/fs/famfs/Kconfig b/fs/famfs/Kconfig
> new file mode 100644
> index 000000000000..e450928d8912
> --- /dev/null
> +++ b/fs/famfs/Kconfig
> @@ -0,0 +1,10 @@
> +
> +
> +config FAMFS
> + tristate "famfs: shared memory file system"
> + depends on DEV_DAX && FS_DAX
> + help
> + Support for the famfs file system. Famfs is a dax file system that
> + can support scale-out shared access to fabric-attached memory
> + (e.g. CXL shared memory). Famfs is not a general purpose file system;
> + it is an enabler for data sets in shared memory.

Please use one tab + 2 spaces to indent help text (below the "help" keyword)
as documented in Documentation/process/coding-style.rst.

> diff --git a/fs/famfs/Makefile b/fs/famfs/Makefile
> new file mode 100644
> index 000000000000..8cac90c090a4
> --- /dev/null
> +++ b/fs/famfs/Makefile
> @@ -0,0 +1,5 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +obj-$(CONFIG_FAMFS) += famfs.o
> +
> +famfs-y := famfs_inode.o famfs_file.o

--
#Randy