From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF66554F90 for ; Mon, 19 Feb 2024 21:42:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378933; cv=none; b=pXpP/JqLgS6D87+t5rdedvz5wFOA2dcvqOw4/hgn9VeiNmqlchQNAdJqpw4Qi4vu8fGtPolsY7V98s4e6WyzhA3TuNXjmTrLFwPm84bQPlBuaX1Q3qBbuBNvVmbXgcN2bkI0jRDYN/9VYlykfS5qE42tNEaD91kqXTlomYhsKv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378933; c=relaxed/simple; bh=X/JQNewlP0vjO6jTDKr0e8KEBVYmNgVrFfyXrgV4mFQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=M2vhBoIYsdJFTsVr9SQ9YcsYhsAKpCzHsmPN5VQ+EDCrDBd1AL5r/LyrttwOZJOQyeKSOzmHVhGOgijZes6CcxRGEySP8t7c2jR9MollG76NJZ3qDX6gMaurTSSb+TgAjopD6aukj6zbCTD19rw6x5hmss8w4xTpsEjGlA4Y7+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=D8W6g3xF; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="D8W6g3xF" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-5dca5c631ffso4804461a12.2 for ; Mon, 19 Feb 2024 13:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708378928; x=1708983728; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=g8pCPeHHqio6jkpHM74ywYCDIbICUYC0WuI3ZsK0Xes=; b=D8W6g3xFdxsLnpo9T3gSkE+PwxH+Rz3RgvW2UCiVvziW27U7KYoVdlK5E45sITSc7x MuKfqe+bIhFbWfSgsNTJqnF2g5lp7sEwCnDxw/jyJuzo2pJWeZwe7yBZR/1eAmIA3WH7 Jt9ls/brQsJoJ8Pd3y5TnwiXKoxNYzYkd2AKSg1bn+qvwVt75gSxmf7AuxcL9VgEJ3Gf /O+OsrYF8ko4cWiZCWk1OXhugUk6K+uUJieP9eci7xUSiLniMY3LTi35gDCzaIbZbn+d JR6gIYnAvpw+QlBT/ecpHXxB84cy4qAvW6lSQh5pHYKMtHQnLkweiD0CypSA166rnb4u kDIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708378928; x=1708983728; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g8pCPeHHqio6jkpHM74ywYCDIbICUYC0WuI3ZsK0Xes=; b=a3eXv9FlU5/cQ5sFzJ2WOHpvWLW43eJ+oZqvLehgRzeKBxdXaMSSpaSDVBH02ZgsHn IC+Oeg8/0/lEQamh3SWOMsNZwI/LMLNrVqTVrE54yv2s3IPA2L8TLC6+eSnARiozjfAk Xd17jdJSzJZ0yT2j4NZGxjf+A6MXjDU+KGFQYmxtpaZzSpxmbuN3iRDOQLnJ7+cahbWl nDJ/wjNhwBjWfyBbzo7zXv87BBVorgjSLAvvawc3DDjsGvoomaUCk5ztLdGxSbnMnsF5 ctgx23DGs8xztmoyMthj8u4DDOK9HvAVJUEfEae0eUKFZiUM0p6INTCeqrULwsiu3rUm uVQw== X-Forwarded-Encrypted: i=1; AJvYcCXRfdhTzCN8d2xIBr7HgetkLUNQBTt5n1nLFfCa6iWsrwCXNBSg4K23x07NkGMMRFCpZfG9WPbeEktw1Fa/f7ZYgVjbxLu5AsMG X-Gm-Message-State: AOJu0YyWMNw4KRVX8VjDszJx1GN6IqudtH9nWIziGmDxBBatjtd/7u62 8V4gh9SVZm4yzYJL/57Mz4FV/udfNPWMWEtmy9rwiGUv0BE2x1yCbuNId0hhXNBxpMRmaAPpW3q kgQ== X-Google-Smtp-Source: AGHT+IHqdE3KIsgW0NC+8GHUODTOmDylpK2DdX8ikWVklG5BvSIeuNAnpXNIboNkdrJqpTmuvilDIVPPeCY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a65:6742:0:b0:5db:e194:873f with SMTP id c2-20020a656742000000b005dbe194873fmr35852pgu.10.1708378927816; Mon, 19 Feb 2024 13:42:07 -0800 (PST) Date: Mon, 19 Feb 2024 13:42:06 -0800 In-Reply-To: <20240215152916.1158-5-paul@xen.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240215152916.1158-1-paul@xen.org> <20240215152916.1158-5-paul@xen.org> Message-ID: Subject: Re: [PATCH v13 04/21] KVM: pfncache: add a mark-dirty helper From: Sean Christopherson To: Paul Durrant Cc: Paolo Bonzini , Jonathan Corbet , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Woodhouse , Shuah Khan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, Feb 15, 2024, Paul Durrant wrote: > +/** > + * kvm_gpc_mark_dirty_in_slot - mark a cached guest page as dirty. > + * > + * @gpc: struct gfn_to_pfn_cache object. Meh, just omit the kerneldoc comment. > + */ > +static inline void kvm_gpc_mark_dirty_in_slot(struct gfn_to_pfn_cache *gpc) > +{ > + lockdep_assert_held(&gpc->lock); > + if (gpc->memslot) > + mark_page_dirty_in_slot(gpc->kvm, gpc->memslot, > + gpc->gpa >> PAGE_SHIFT); It's kinda silly, but I think it's worth landing this below gpa_to_gfn() so that there's no need to open code the shift. And I have a (very) slight preference for an early return. static inline void kvm_gpc_mark_dirty_in_slot(struct gfn_to_pfn_cache *gpc) { lockdep_assert_held(&gpc->lock); if (!gpc->memslot) return; mark_page_dirty_in_slot(gpc->kvm, gpc->memslot, gpa_to_gfn(gpc->gpa)); } > +} > + > void kvm_sigset_activate(struct kvm_vcpu *vcpu); > void kvm_sigset_deactivate(struct kvm_vcpu *vcpu); > > -- > 2.39.2 >