From: Tejun Heo <tj@kernel.org>
To: Xuewen Yan <xuewen.yan94@gmail.com>
Cc: Xuewen Yan <xuewen.yan@unisoc.com>,
jiangshanlai@gmail.com, corbet@lwn.net, paulmck@kernel.org,
rdunlap@infradead.org, peterz@infradead.org, yanjiewtw@gmail.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
ke.wang@unisoc.com
Subject: Re: [PATCH] workqueue: Control the frequency of intensive warning through cmdline
Date: Tue, 20 Feb 2024 19:44:30 -1000 [thread overview]
Message-ID: <ZdWNvolkfPCyMNj9@slm.duckdns.org> (raw)
In-Reply-To: <CAB8ipk9R3hRSTTEEBn8nvOcTZGBtaDQfomXiQwji+DTKgLghwQ@mail.gmail.com>
Hello,
On Wed, Feb 21, 2024 at 10:01:17AM +0800, Xuewen Yan wrote:
> cnt = atomic64_inc_return_relaxed(&ent->cnt);
> - if (cnt >= 4 && is_power_of_2(cnt))
> + if (cnt == wq_cpu_intensive_warning_nth ||
> + (cnt > wq_cpu_intensive_warning_nth && is_power_of_2(cnt)))
If we do this the nth name doesn't really make sense. Maybe something like
wq_cpu_intensive_warning_thresh is better? Also, something like the
following might be more predictable. Let's say
wq_cpu_intensive_warning_thresh of 0 disables the warnings and it's
initialized to 4 by default.
if (cnt >= wq_cpu_intensive_warning_thresh &&
is_power_of_2(cnt + 1 - wq_cpu_intensive_warning_thresh))
Thanks.
--
tejun
next prev parent reply other threads:[~2024-02-21 5:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 7:46 [PATCH] workqueue: Control the frequency of intensive warning through cmdline Xuewen Yan
2024-02-19 16:00 ` Randy Dunlap
2024-02-20 16:46 ` Tejun Heo
2024-02-21 2:01 ` Xuewen Yan
2024-02-21 5:44 ` Tejun Heo [this message]
2024-02-21 11:00 ` Xuewen Yan
2024-02-21 17:44 ` Tejun Heo
2024-02-22 1:52 ` Xuewen Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdWNvolkfPCyMNj9@slm.duckdns.org \
--to=tj@kernel.org \
--cc=corbet@lwn.net \
--cc=jiangshanlai@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=xuewen.yan94@gmail.com \
--cc=xuewen.yan@unisoc.com \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).