From: Dominique Martinet <asmadeus@codewreck.org>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>,
Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
v9fs@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v3 2/3] net/9p/usbg: Add new usb gadget function transport
Date: Thu, 7 Mar 2024 04:54:21 +0900 [thread overview]
Message-ID: <ZejJ7W_yUMBtqi70@codewreck.org> (raw)
In-Reply-To: <915890fa-e763-470a-a82b-eda97c47c0c8@collabora.com>
Andrzej Pietrasiewicz wrote on Wed, Mar 06, 2024 at 04:18:54PM +0100:
> Reading the earlier discussions on v1 and v2 I was somehow under the impression
> that what you submitted here does not contain configfs support.
>
> But once I started reading the code I realized it does.
>
> It worked for me, both as a legacy gadget and when composed with configfs.
>
> I noticed that when you stop the forwarder at the host side when 9pfs remains
> mounted at the gadget side, umount hangs at the gadget side until the forwarder
> is restarted. I know that once the host-side software dies, not much can be
> done, however, unmounting a dead filesystem seems a reasonable thing to do
> and the way usb9pfs worked for me it is not possible to unmount in this
> situation. Any ideas on improving this?
If the trans_usbg code can detect the host device is gone it should mark
client->status as Disconnected then wake up all pending requests
(something like p9_conn_cancel in trans_fd.c)
Sorry I haven't found time to test/review either; I'd still be
interested in running this in qemu for non-reg over using a real device
so need to spend a few minutes figuring out the exact command line
required.. I'll try to find some time this weekend
--
Dominique
next prev parent reply other threads:[~2024-03-06 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 13:56 [PATCH v3 0/3] usb: gadget: 9pfs transport Michael Grzeschik
2024-02-26 13:56 ` [PATCH v3 1/3] usb: gadget: function: move u_f.h to include/linux/usb/ Michael Grzeschik
2024-02-26 13:56 ` [PATCH v3 2/3] net/9p/usbg: Add new usb gadget function transport Michael Grzeschik
2024-03-06 15:18 ` Andrzej Pietrasiewicz
2024-03-06 19:54 ` Dominique Martinet [this message]
2024-04-29 23:34 ` Michael Grzeschik
2024-04-30 8:06 ` Andrzej Pietrasiewicz
2024-02-26 13:56 ` [PATCH v3 3/3] tools: usb: p9_fwd: add usb gadget packet forwarder script Michael Grzeschik
2024-03-01 12:06 ` [PATCH v3 0/3] usb: gadget: 9pfs transport Andrzej Pietrasiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZejJ7W_yUMBtqi70@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=andrzej.p@collabora.com \
--cc=corbet@lwn.net \
--cc=ericvh@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=m.grzeschik@pengutronix.de \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).