From: Andy Shevchenko <andy@black.fi.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: David Ober <dober6023@gmail.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, jdelvare@suse.com, corbet@lwn.net,
dober@lenovo.com, mpearson@lenovo.com
Subject: Re: [PATCH v4] hwmon:Add EC Chip driver for Lenovo ThinkStation motherboards
Date: Mon, 25 Mar 2024 14:13:39 +0200 [thread overview]
Message-ID: <ZgFqc5Lz3P8BfPw7@black.fi.intel.com> (raw)
In-Reply-To: <f748574c-93cf-48ec-8e88-44d5b35fb107@roeck-us.net>
On Wed, Mar 20, 2024 at 10:59:34AM -0700, Guenter Roeck wrote:
> On Fri, Mar 15, 2024 at 07:58:10AM -0400, David Ober wrote:
> > This addition adds in the ability for the system to scan
> > the EC chip in the Lenovo ThinkStation systems to get the
> > current fan RPM speeds the Maximum speed value for each
> > fan also provides the CPU, DIMM other thermal statuses
> >
> > Signed-off-by: David Ober <dober@lenovo.com>
> > Signed-off-by: David Ober <dober6023@gmail.com>
>
> Applied to hwmon-next.
>
> Please note that I'll push the branch after the commit window closed.
Hmm... Was it even compiled?
lenovo-ec-sensors.c:154:31: error: expected '}'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
^
lenovo-ec-sensors.c:154:27: note: to match this '{'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
^
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-25 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 11:58 [PATCH v4] hwmon:Add EC Chip driver for Lenovo ThinkStation motherboards David Ober
2024-03-20 17:59 ` Guenter Roeck
2024-03-25 12:13 ` Andy Shevchenko [this message]
2024-03-25 12:29 ` Andy Shevchenko
2024-03-25 14:35 ` Guenter Roeck
2024-03-26 14:27 ` [External] " David Ober
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgFqc5Lz3P8BfPw7@black.fi.intel.com \
--to=andy@black.fi.intel.com \
--cc=corbet@lwn.net \
--cc=dober6023@gmail.com \
--cc=dober@lenovo.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mpearson@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).