From: Matthew Wilcox <willy@infradead.org>
To: qiurui <happyqiuqiu9604@gmail.com>
Cc: gregkh@linuxfoundation.org, corbet@lwn.net,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
qiurui@kylinos.cn
Subject: Re: [PATCH] docs: usb:gadget:hid: fix hid_gadget_test code in documentation of hid section
Date: Mon, 6 May 2024 06:34:35 +0100 [thread overview]
Message-ID: <Zjhr64kAcj5VBHrO@casper.infradead.org> (raw)
In-Reply-To: <20240506024408.19344-1-qiurui@kylinos.cn>
On Mon, May 06, 2024 at 10:44:08AM +0800, qiurui wrote:
> Fix bzero buffer before read()
why would we want to do that?
> Signed-off-by: qiurui <qiurui@kylinos.cn>
> ---
> Documentation/usb/gadget_hid.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/usb/gadget_hid.rst b/Documentation/usb/gadget_hid.rst
> index e623416de4f1..c4ee81a6b48e 100644
> --- a/Documentation/usb/gadget_hid.rst
> +++ b/Documentation/usb/gadget_hid.rst
> @@ -410,6 +410,7 @@ Sample code::
> }
>
> if (FD_ISSET(fd, &rfds)) {
> + bzero(buf, SIZE);
> cmd_len = read(fd, buf, BUF_LEN - 1);
> printf("recv report:");
> for (i = 0; i < cmd_len; i++)
> @@ -419,6 +420,7 @@ Sample code::
>
> if (FD_ISSET(STDIN_FILENO, &rfds)) {
> memset(report, 0x0, sizeof(report));
> + bzero(buf, SIZE);
> cmd_len = read(STDIN_FILENO, buf, BUF_LEN - 1);
>
> if (cmd_len == 0)
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2024-05-06 5:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 2:44 [PATCH] docs: usb:gadget:hid: fix hid_gadget_test code in documentation of hid section qiurui
2024-05-06 5:34 ` Matthew Wilcox [this message]
2024-05-10 9:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjhr64kAcj5VBHrO@casper.infradead.org \
--to=willy@infradead.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=happyqiuqiu9604@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qiurui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox