From: Christoph Hellwig <hch@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Hongbo Li <lihongbo22@huawei.com>,
viro@zeniv.linux.org.uk, jack@suse.cz, tytso@mit.edu,
adilger.kernel@dilger.ca, lczerner@redhat.com,
cmaiolino@redhat.com, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH v2 2/4] fs: add path parser for filesystem mount option.
Date: Mon, 27 May 2024 09:26:55 -0700 [thread overview]
Message-ID: <ZlS0Tw96cthn6pNf@infradead.org> (raw)
In-Reply-To: <20240527-groll-mythisch-8580c32ab296@brauner>
On Mon, May 27, 2024 at 04:32:00PM +0200, Christian Brauner wrote:
> That smells like a UAF:
>
> dfd = open("/bla");
> fsconfig(FSCONFIG_SET_PATH, dfd, "blub", 0);
> close(dfd);
> umount("/bla");
>
> and that result->ptr now has a dangling pointer which will be triggered by:
>
> fsconfig(FSCONFIG_CMD_CREATE);
Yeah. Also the whole path thing is entirely unused. The best thing
to do about it is to remove it, we can always resurrect if if/when we
actually need it.
next prev parent reply other threads:[~2024-05-27 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 7:58 [PATCH v2 0/4] enhance the path resolution capability in fs_parser Hongbo Li
2024-05-27 7:58 ` [PATCH v2 1/4] fs: add blockdev parser for filesystem mount option Hongbo Li
2024-05-27 7:58 ` [PATCH v2 2/4] fs: add path " Hongbo Li
2024-05-27 14:32 ` Christian Brauner
2024-05-27 16:26 ` Christoph Hellwig [this message]
2024-05-27 7:58 ` [PATCH v2 3/4] fs: ext4: support relative path for `journal_path` in " Hongbo Li
2024-05-27 15:39 ` Christian Brauner
2024-05-27 7:58 ` [PATCH v2 4/4] fs: remove fs_lookup_param and its description Hongbo Li
2024-05-27 15:08 ` [PATCH v2 0/4] enhance the path resolution capability in fs_parser Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlS0Tw96cthn6pNf@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=lihongbo22@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox