From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822D284A23 for ; Wed, 12 Jun 2024 23:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718236533; cv=none; b=IPgbtpEHjLdFBaB0anW5gEzbm89PCaQG88lGAVdZ3nvz5dXIFkpdKp1m9q2cKfRRm65D72DJ1G3m3Qju5+Y3uHWKpgMomqHtrXMnRHVtZhx7Z+j1U0ih4qE9nfRXs16Qih13DiPER9XgTo9KHot5+ioyRzDcFIe4ubBlepDPK1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718236533; c=relaxed/simple; bh=UExzSWlT64SRTujuwraGmriH1bXzmArZy7Cn25txElQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZFVu8fwNXorLr0DExRBaXJifhLUP0XBHcUWf4aGlg8Y+F/Idny0NlZt0colVmS6EzfKLee4MYhq/h1ishpQNNl51EV8bhbgkFKwywnzNAnPicBsyUpt5cPpwAPPIHKgMgz10uryKwvuwa5zckEs+/1h1ZL9EHIDVIT+ZYwpWbK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jirNIJYY; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jirNIJYY" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7042d4c7a21so285958b3a.3 for ; Wed, 12 Jun 2024 16:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718236532; x=1718841332; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=LbtqKKQm97BowZds9B5adCnW1KnZQCMsmfiIrci+y0c=; b=jirNIJYYKuHlN88ExgvTAXbzBT5huFy4GJFP0i7P5OP3701PKraGKtdsuHi9tq17uf rP4p+tjbRQFk2Pg7HYiyJoX34ie/ja4NbmDtp3jLVx1kAWhpgr0A080Ag86uERFnlpKd qNvnLn31puwbxsPh+KrOKJzAjMWAlNk5X2tdrmXlR9qNgtQL/kW7BBVHH/GGo1y+/wrh xwcPD0v+o1fijW9uK5iv3DQowwruNhsD5VP8JXpwv/azfaDoBREB3I6APEnpRhl8yKDJ pFaOL+Ta1zAArMnSzNup/eDXuynXsJ7li2kB9fNk7+o2ErtdnZHqqY/m/yMzjGAgn4hw /oVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718236532; x=1718841332; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LbtqKKQm97BowZds9B5adCnW1KnZQCMsmfiIrci+y0c=; b=L2VPqR9TUqF9MZKr7cIpZQxTPB5nua54nY26ThTBQfy+YoTGyG9dZFKegSboIzlV0T maEOgDZ/8+ThmJiVOwfVoJjzDAWFPGF5A0IbUlUlSPN5muP0tyKPac6A0FHlgtt89wa3 VLc5SWOztT32dodoCXSvQYUAKSYur1rhdXV80e+4FsLIszh0jrZHybSwKSnvAVo6EdXN iQvlDD/1eUKl8WRAfBLM9zA1IsmmROdT+1gUwTBMzbBrkvUy+iL+aEbd529xyAWAYSLV m9wulhDRAy+yS0OG4yjlILFVEbDcorBjh+Ts3VKQwifikhO26Ut7dFxcATM7h9wYOEyT r+Cw== X-Forwarded-Encrypted: i=1; AJvYcCW12Jez04jHSo1nLhh4dWyy/hPSu5rwZLSg9MbsTT/mZ/X8dkVBFCGHic/kQLK/UntYbh1qBO/BjEAfEkKZsvbAb1LhXaLUmKkj X-Gm-Message-State: AOJu0Yw26WAAWkZ4w1cA7wZDv69K1VaSx3YoPhgACk+WwWOKP5wPvcoQ 7NIO9VbXXDyh0A2PaXFiidnuxSrCVeaIWPLs/ZqcoTH1V9Wfmc+fkC4RndvNLe4taAFX5KvrPJZ dpg== X-Google-Smtp-Source: AGHT+IGuecHJt0nHiXhJJYQkDb8/xV2VtUD4kUhO0uw0vw6n+UwkxLnb8lI0ADIZLteFZY80tW1W5/H7pvs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:2d0f:b0:704:1a73:d008 with SMTP id d2e1a72fcca58-705bcddfb7emr13011b3a.1.1718236531660; Wed, 12 Jun 2024 16:55:31 -0700 (PDT) Date: Wed, 12 Jun 2024 16:55:30 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240207172646.3981-1-xin3.li@intel.com> <20240207172646.3981-16-xin3.li@intel.com> Message-ID: Subject: Re: [PATCH v2 15/25] KVM: VMX: Dump FRED context in dump_vmcs() From: Sean Christopherson To: Chao Gao Cc: Xin Li , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "pbonzini@redhat.com" , "corbet@lwn.net" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "shuah@kernel.org" , "vkuznets@redhat.com" , "peterz@infradead.org" , Ravi V Shankar , "xin@zytor.com" Content-Type: text/plain; charset="us-ascii" On Tue, Apr 30, 2024, Chao Gao wrote: > On Thu, Feb 08, 2024 at 01:26:35AM +0800, Xin Li wrote: > >@@ -6449,6 +6451,19 @@ void dump_vmcs(struct kvm_vcpu *vcpu) > > vmx_dump_sel("LDTR:", GUEST_LDTR_SELECTOR); > > vmx_dump_dtsel("IDTR:", GUEST_IDTR_LIMIT); > > vmx_dump_sel("TR: ", GUEST_TR_SELECTOR); > >+#ifdef CONFIG_X86_64 > >+ if (kvm_is_fred_enabled(vcpu)) { > > FRED MSRs are accessible even if CR4.FRED isn't set and #ifdef is ugly, I think > you can simply do: > > if (vmentry_ctrl & VM_ENTRY_LOAD_IA32_FRED) > > just like below handling for EFER/PAT etc. +1