From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64D8F14C5A1 for ; Thu, 13 Jun 2024 18:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718303896; cv=none; b=egliS29gWzUvshFtYu3j56nM9NWchQHTSJb9JeFy06MkvV9vKIYVwCT1PaRuAV/8ukRsR6cGjCaYUNNZiFJZ1dVBTFAL/fNlAx3M1D9OiMw3+OxK1//HCMb6zyhitcF6gNiLh+gdourU0UpCpXkaxIHUZypVVPzSbqDQC3ukMcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718303896; c=relaxed/simple; bh=L/I0jGSnKvfURjR9QPVZSHNpgzmXSr/7QAs2Yjq/MN4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=JcNUWZOEYftR3MRVRZ6Z7TxiQJBIhgXPIN3aX9vcsWwM0sN7j4R7GfJLZ9qIzLIQ6qqNDU3JAhXyCjFRu/imQWWT/V3RU6FrthJeeveDmO8ZOXj3cRPfG1eMrfUTXmQncjc7MEPwvPzoxLI8mJ/o/E8ifk9XNVtLbOrNaAKr1ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Pa62ppOQ; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Pa62ppOQ" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2c2fe3c4133so1205228a91.3 for ; Thu, 13 Jun 2024 11:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718303895; x=1718908695; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=Updc3JmEB9tDfSD6bTK5d81zUhVfnHUf04ep4+BiNE0=; b=Pa62ppOQ/dth7kPb21G3Nd8RYVyAjomc/DV4cmyRvKhw6ydKU6UluwZWcJQlRITjC8 B2UrSUsjKqZKLtan2C4jaxNc4zS+E3jFPZRYscMKFNkW6E/QLEf8suL1dVrPe1d5ocvg Oaj1tDKrgUR/S864nOxHPheE9uea2a6mRBREJJkmNYC1y4TNtYtHMHb6TkT298epb87Q uQ8yOhSDDHwZGV+nFQXdLc9cIlCnyxdORaXFPlkfKv1+jhuQh3Ky5ZNKmjuDF3KdvoBL vjyCXm2GCjp85TXC1cL2SdBZ0pF7fHfb6rReMJxcR+CIs5v4CPkZhREfrxIMYxry+qiM v9DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718303895; x=1718908695; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Updc3JmEB9tDfSD6bTK5d81zUhVfnHUf04ep4+BiNE0=; b=rABbZrc3Yfdm0cchGXKG2G0QFxXXn9dcdVB2jmBihprIxb17W0f6gJJqtlDIU6xCb3 xnrRLIkErBscztghRHTqdtd+vobBuxBGiawE4B1/Tpsi4mXiVVhh+k6wUeBDKUMzY1eC 2m6V0F5TZKUbfQADDC05MT6PMpaj8u5gXqqQHMoOnavvVSCPNTFDPJMsDAM4RV/GeXoO wiKLW+QZq781yo3bWbW15TbFYWLxU39KlNzrFJNVy2TLYSXykwDQzfoH2Rep6hcLfo8U 9UFEBUZOMGgRtabYdcpb8r0jLtUYBk5eMhqXTTo07WjzGaVEuXP8dyzEGMq+u36K9U5v E3LA== X-Forwarded-Encrypted: i=1; AJvYcCXvDfhUbd81y1ras602pA0qcLW/jz2e7YrdHc7n9vbgso+g3qw8Go8i3KyeVanw1AeTHZq+drDoyCHDZANhCsGOijEsiWoRBu5A X-Gm-Message-State: AOJu0YwpXfH1Bzuvy8Y6JzH7PNZtUo71ugy6aaEoWxPj37n2mgYPGHaZ ahFFj6+7R+wHovpE2uDv6VQ5YRFNGSpnipjaRVtZkxcuo6PWCPGhEBR8DYMuF9YSKDAGNF/gXAW mcg== X-Google-Smtp-Source: AGHT+IEoHsoXQ33CoHiGZZlVh3rR+/EUc+z3M2bB9VIq6N8UkxisrbO0XxnhPNgtzkGpaeE61uYDqNygW5Q= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:d2c8:b0:1f6:fbea:7976 with SMTP id d9443c01a7336-1f862a17756mr12475ad.10.1718303894500; Thu, 13 Jun 2024 11:38:14 -0700 (PDT) Date: Thu, 13 Jun 2024 11:38:13 -0700 In-Reply-To: <608b37dbc59a80d32719c8fde8b6979a2b839e10.camel@intel.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240207172646.3981-1-xin3.li@intel.com> <608b37dbc59a80d32719c8fde8b6979a2b839e10.camel@intel.com> Message-ID: Subject: Re: [PATCH v2 00/25] Enable FRED with KVM VMX From: Sean Christopherson To: Shan Kang Cc: Xin3 Li , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "corbet@lwn.net" , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "vkuznets@redhat.com" , "bp@alien8.de" , "mingo@redhat.com" , "tglx@linutronix.de" , "hpa@zytor.com" , "pbonzini@redhat.com" , "peterz@infradead.org" , "shuah@kernel.org" , Ravi V Shankar , "xin@zytor.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 27, 2024, Shan Kang wrote: > On Wed, 2024-02-07 at 09:26 -0800, Xin Li wrote: > > This patch set enables the Intel flexible return and event delivery > > (FRED) architecture with KVM VMX to allow guests to utilize FRED. > >=20 > We tested this FRED KVM patch set on a 7th Intel(R) Core(TM) CPU and the = Intel=20 > Simics=C2=AE Simulator with the following four configurations: That likely provides coverage for the happy cases, but I doubt it provides = negative testing, e.g. for VM-Enter consistency checks. KVM-Unit-Tests are currentl= y the best choice for concistency checks (unfortunately). And given the insanity of event re-injection, KVM selftests needs a dedicat= ed test for that, and another for the interactions with nVMX, e.g. a la svm_nested_= soft_inject_test.c. I haven't looked too closely at the selftest that's already provided, but m= y suspicion is that we'll want multiple tests, or alternatively one test that uses KVM_ONE_VCPU_TEST_SUITE().