From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0763514BFA2; Thu, 11 Jul 2024 14:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720706751; cv=none; b=Mhd/VXxKWvBHHPS57vkteWuKACwwrkho+13zUEfol8sDMWQ42LR9oag4gGdDFH5l/fEeRXVHTTPJ0EFI65nkgrxCcrFdNc2Ih4nSRIPWB7NskNenEf5uTMRTFX/b2i1vEedwW5iSUB3jd18hFLNHzL854BQwVfSHuDx8emKUB54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720706751; c=relaxed/simple; bh=PhHroz5/iQCubztv7+fwgm7+eMtiP9Lp0KUxRWIxtXU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kFQRnLZ+0dp5BDZY2IFSJKZ9DI1dTV8STu9DA85IK7oxCU3D9DGPYWrtSqRQi71VnsXAHt4eTvB98J+xEB/4MtHPf/rX1Ui4cdEk57v6MhiQzCcbmbXuGUMm/DMp6iSvsgKpXwoLz6gJyEzSPC5PakQ+6xNvHMxpcptBFXoxtY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F328FEC; Thu, 11 Jul 2024 07:06:13 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EEFC3F766; Thu, 11 Jul 2024 07:05:45 -0700 (PDT) Date: Thu, 11 Jul 2024 15:05:42 +0100 From: Cristian Marussi To: "Peng Fan (OSS)" Cc: Jonathan Corbet , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peng Fan , Alexandre Belloni , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, arm-scmi@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v5 0/7] firmware: support i.MX95 SCMI BBM/MISC Extenstion Message-ID: References: <20240621-imx95-bbm-misc-v2-v5-0-b85a6bf778cb@nxp.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621-imx95-bbm-misc-v2-v5-0-b85a6bf778cb@nxp.com> On Fri, Jun 21, 2024 at 03:04:35PM +0800, Peng Fan (OSS) wrote: > i.MX95 System Manager Firmware source: https://github.com/nxp-imx/imx-sm > To generate html from the repo: make html > Hi Peng, thanks for upstreaming this Vendor protocol. LGTM, beside minor nitpicks I mentioned. Please run checkpatch.pl --strict on series before next rebase, though, that I spotted a few minor not-so-stylish things :D Thanks, Cristian