From: Roman Gushchin <roman.gushchin@linux.dev>
To: David Finkel <davidf@vimeo.com>
Cc: "Muchun Song" <muchun.song@linux.dev>,
"Tejun Heo" <tj@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
core-services@vimeo.com, "Jonathan Corbet" <corbet@lwn.net>,
"Michal Hocko" <mhocko@kernel.org>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Shuah Khan" <shuah@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Zefan Li" <lizefan.x@bytedance.com>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH v7 2/2] mm, memcg: cg2 memory{.swap,}.peak write tests
Date: Tue, 6 Aug 2024 23:13:17 +0000 [thread overview]
Message-ID: <ZrKuDX848wDcBSly@google.com> (raw)
In-Reply-To: <20240730231304.761942-3-davidf@vimeo.com>
On Tue, Jul 30, 2024 at 07:13:04PM -0400, David Finkel wrote:
> Extend two existing tests to cover extracting memory usage through the
> newly mutable memory.peak and memory.swap.peak handlers.
>
> In particular, make sure to exercise adding and removing watchers with
> overlapping lifetimes so the less-trivial logic gets tested.
>
> The new/updated tests attempt to detect a lack of the write handler by
> fstat'ing the memory.peak and memory.swap.peak files and skip the tests
> if that's the case. Additionally, skip if the file doesn't exist at all.
>
> Signed-off-by: David Finkel <davidf@vimeo.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
next prev parent reply other threads:[~2024-08-06 23:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 23:13 [PATCH v7] mm, memcg: cg2 memory{.swap,}.peak write handlers David Finkel
2024-07-30 23:13 ` [PATCH v7 1/2] " David Finkel
2024-08-06 23:12 ` Roman Gushchin
2024-07-30 23:13 ` [PATCH v7 2/2] mm, memcg: cg2 memory{.swap,}.peak write tests David Finkel
2024-08-06 23:13 ` Roman Gushchin [this message]
2024-08-06 20:16 ` [PATCH v7] mm, memcg: cg2 memory{.swap,}.peak write handlers David Finkel
2024-08-06 20:18 ` Tejun Heo
2024-08-06 20:21 ` David Finkel
2024-08-06 22:36 ` Andrew Morton
2024-08-06 23:00 ` David Finkel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrKuDX848wDcBSly@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=core-services@vimeo.com \
--cc=davidf@vimeo.com \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).