From: Mike Rapoport <rppt@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org,
Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] pstore/ramoops: Fix typo as there is no "reserver"
Date: Thu, 8 Aug 2024 09:18:07 +0300 [thread overview]
Message-ID: <ZrRi7fdYo3yVPr1G@kernel.org> (raw)
In-Reply-To: <20240807170029.3c1ff651@gandalf.local.home>
On Wed, Aug 07, 2024 at 05:00:29PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> For some reason my finger always hits the 'r' after typing "reserve".
> Fix the typo in the Documentation example.
>
> Fixes: d9d814eebb1ae ("pstore/ramoops: Add ramoops.mem_name= command line option")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> Note, I did have this fixed, but the previous version was pulled:
> https://lore.kernel.org/linux-trace-kernel/20240613233446.283241953@goodmis.org/
>
> Documentation/admin-guide/ramoops.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/ramoops.rst b/Documentation/admin-guide/ramoops.rst
> index 6f534a707b2a..2eabef31220d 100644
> --- a/Documentation/admin-guide/ramoops.rst
> +++ b/Documentation/admin-guide/ramoops.rst
> @@ -129,7 +129,7 @@ Setting the ramoops parameters can be done in several different manners:
> takes a size, alignment and name as arguments. The name is used
> to map the memory to a label that can be retrieved by ramoops.
>
> - reserver_mem=2M:4096:oops ramoops.mem_name=oops
> + reserve_mem=2M:4096:oops ramoops.mem_name=oops
>
> You can specify either RAM memory or peripheral devices' memory. However, when
> specifying RAM, be sure to reserve the memory by issuing memblock_reserve()
> --
> 2.43.0
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2024-08-08 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 21:00 [PATCH] pstore/ramoops: Fix typo as there is no "reserver" Steven Rostedt
2024-08-07 21:57 ` Kees Cook
2024-08-08 6:18 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrRi7fdYo3yVPr1G@kernel.org \
--to=rppt@kernel.org \
--cc=corbet@lwn.net \
--cc=kees@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).