linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Sebastian Fricke <sebastian.fricke@collabora.com>,
	Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	hverkuil-cisco@xs4all.nl, mauro.chehab@linux.intel.com,
	kernel@collabora.com, bob.beckett@collabora.com,
	nicolas.dufresne@collabora.com
Subject: Re: [PATCH RFC v2 2/3] docs: Add guides section for debugging
Date: Wed, 25 Sep 2024 15:01:48 +0700	[thread overview]
Message-ID: <ZvPDbFatkelji1FM@archie.me> (raw)
In-Reply-To: <20240529-b4-media_docs_improve-v2-2-66318b2da726@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 3017 bytes --]

On Tue, Sep 24, 2024 at 10:45:58AM +0200, Sebastian Fricke wrote:
> +This document serves as a general starting point and lookup for debugging device
> +drivers.
> +While this guide focuses on debugging that requires re-compiling the
> +module/kernel, the `userspace-debugging-guide <userspace_debugging_guide.html>`__
> +will guide you through tools like dynamic debug, ftrace and other tools useful
> +for debugging issues and behavior.
> +For general debugging advice, see `general-debugging-guide <index.html>`__.

You can use :doc: syntax for linking to other docs with custom anchor text,
like:

```
:doc:`userspace debugging guide <userspace_debugging_guide>`
```

(note the file suffix omission).

Better yet, specify the full doc path (e.g.
`Documentation/debugging/userspace_debugging_guide.rst`) and Sphinx will
generate the anchor text with target doc's title.

> +====================================================
> +General debugging advice for Linux Kernel developers
> +====================================================
> +
> +.. toctree::
> +   :maxdepth: 1
> +
> +   driver_development_debugging_guide
> +   userspace_debugging_guide
> +
> +.. only::  subproject and html
> +
> +   Indices
> +   =======
> +
> +   * :ref:`genindex`
> +
> +General debugging advice
> +========================

Please split general debugging advice into its own doc (e.g. at
general-advice.rst). Most other docs have index.rst only for toctree
listing.

> +**When should you use this over** `Ftrace`_ **?**
> +
> +- When the code contains one of the :ref:`valid print statements <valid_dyndbg_prints_>`_ or when you have added multiple pr_debug() statements during development

Sphinx complains about stray underscores:

Documentation/debugging/userspace_debugging_guide.rst:54: WARNING: Mismatch: both interpreted text role prefix and reference suffix.

I have to trim them:

---- >8 ----
diff --git a/Documentation/debugging/userspace_debugging_guide.rst b/Documentation/debugging/userspace_debugging_guide.rst
index 4d269a9ef9..eac459e30f 100644
--- a/Documentation/debugging/userspace_debugging_guide.rst
+++ b/Documentation/debugging/userspace_debugging_guide.rst
@@ -51,7 +51,7 @@ Here is one example, that enables all available `pr_debug()`'s within the file:
 
 **When should you use this over** `Ftrace`_ **?**
 
-- When the code contains one of the :ref:`valid print statements <valid_dyndbg_prints_>`_ or when you have added multiple pr_debug() statements during development
+- When the code contains one of the :ref:`valid print statements <valid_dyndbg_prints>` or when you have added multiple pr_debug() statements during development
 - When timing is not an issue, meaning if multiple `pr_debug()` statements in the code won't cause delays
 - When you care more about receiving specific log messages than tracing the pattern of how a function is called
 
Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-09-25  8:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-24  8:45 [PATCH RFC v2 0/3] Documentation: Debugging guide Sebastian Fricke
2024-09-24  8:45 ` [PATCH RFC v2 1/3] docs: media: Create separate documentation folder for media Sebastian Fricke
2024-09-24  8:45 ` [PATCH RFC v2 2/3] docs: Add guides section for debugging Sebastian Fricke
2024-09-25  8:01   ` Bagas Sanjaya [this message]
2024-10-03 23:06   ` Steve Cho
2024-10-04 10:12     ` Sebastian Fricke
2024-10-04 23:30       ` Steve Cho
2024-10-24 22:20   ` Jonathan Corbet
2024-09-24  8:45 ` [PATCH RFC v2 3/3] docs: media: Debugging guide for the media subsystem Sebastian Fricke
2024-10-03 22:32   ` Steve Cho
2024-10-14 17:42   ` Daniel Almeida
2024-10-23 11:43   ` Hans Verkuil
2024-10-23 12:29     ` Laurent Pinchart
2024-10-23 12:37       ` Hans Verkuil
2024-10-23 13:04         ` Dave Stevenson
2024-10-22 15:23 ` [PATCH RFC v2 0/3] Documentation: Debugging guide Sebastian Fricke
2024-10-23  6:57   ` Bagas Sanjaya
2024-10-24 22:01 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvPDbFatkelji1FM@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=bob.beckett@collabora.com \
    --cc=corbet@lwn.net \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mauro.chehab@linux.intel.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=sebastian.fricke@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).