From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5972E1E0DD1 for ; Tue, 8 Oct 2024 18:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728411771; cv=none; b=mUGIlnQ/4Vcdz1gN4IYq5JNc4CAcxiwWjsTiQ7A0bzKBom1Xdctf9T0Cb36Fa1jMBMGMszVRbVpDllbq/08rLSVGOa0NSdmNrGLld1tBy7f+6HiGUYSq5FMbhKRFLPCxq+jMJ7aFsIG5c9dWkHIMLB3dS/o7iJsufY5Yosc1oZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728411771; c=relaxed/simple; bh=Soj8mFaLd1Cyy0ejjBioY9cxLP9QIIW58JDFeiu2ts0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JMWcOWCqpsrFn07drD/g4W1Gu8M7X+M/GYJdMky7gSjndifHzU/Iysn5F/xta7M8OLT9VqLt7HQQ8rfyRWmUYu6clgTtGnBd5fEIoZ1Jv2CIR3gamTkDqoNSsTOpZncUE4uvkLNShlV4f/P0F2i8vWew4g4o7CIFp2R9q9UmGsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=Ao4PoGI9; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="Ao4PoGI9" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-20b9b35c7c3so62564905ad.3 for ; Tue, 08 Oct 2024 11:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1728411770; x=1729016570; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=mfgCpS5PaaDvZjkTJaE/xBzcbJqmdBm8+yyCnyw3De8=; b=Ao4PoGI9vwBp2XBS9TbUrC82t+VibfUVIqpnOWesXqezv0Br5BL3Ty6wA+tIYl1bwg Gl3KwX7OxATwATQ4aFYcSBL764vZgdr5lfvNManB36kYOHUNNMjmJjglTqDhY7hkgNAh S6g4uoFnk9dwmJfotqQFxrZf4dItl8v4X5YDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728411770; x=1729016570; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mfgCpS5PaaDvZjkTJaE/xBzcbJqmdBm8+yyCnyw3De8=; b=mQGWgs210/SUiV1mynJVDW93Bg44Jb6iz3p8GiwVpXI3Bu2Q60Vr3OO+r4EVUKzuct 38Jq57rXOhMINvDju6SXzLqhvr8FrsL4WcVQhGxLAAwgJP4p9Q7lR9x3uEJbLKRU4r09 Vnk/JGfqGkM6m8diYfovkuUwkauoFk3WnlEYo3eSQfX9RojuLjcdLLg+pXj2ccN7Hfe2 VS1qgDpz2q9CnUdF+J9HfWFTjZv4zIGFoO+Fgoh3MZV/5knDF9FZIiTfiWv/DEz/QQRZ wds97awPyRozIhXQt9CiNLHs7XmMniYVRdQ7t7OJCXfWxJolynBORynEq75vDl4u74Wl wxFA== X-Forwarded-Encrypted: i=1; AJvYcCX4u/rFukx9eNq9AOXu4wqtEw9beGJ0CUaN0UHxEFI28b4NWNzrwNtBc6VYKfcGNt3zQQzFgXjouGI=@vger.kernel.org X-Gm-Message-State: AOJu0YzRt7prCDrIRyC9jFCXjuyAqlbwTkHIj0vj5fABUpGDzmFkGqly LAqtE/ypZHyOcyx9Mc/M/FZYRQqG65lc3HFW6mE1pPc0iY6EFA9UlpjahhG7PA4= X-Google-Smtp-Source: AGHT+IGLwKH5D8GmqT91lF+IEqFV1bkPlXaOCwMdX6WQyBYQ2vbuWPbJ2h7utnI4zy5Lzw/E/iDnDg== X-Received: by 2002:a17:902:ea0f:b0:20b:a431:8f17 with SMTP id d9443c01a7336-20bff1c4055mr294243605ad.58.1728411769685; Tue, 08 Oct 2024 11:22:49 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c1395a408sm58422345ad.193.2024.10.08.11.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 11:22:49 -0700 (PDT) Date: Tue, 8 Oct 2024 11:22:45 -0700 From: Joe Damato To: netdev@vger.kernel.org Cc: mkarsten@uwaterloo.ca, skhawaja@google.com, sdf@fomichev.me, bjorn@rivosinc.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Tony Nguyen , Przemek Kitszel , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , David Ahern , Kory Maincent , Johannes Berg , Breno Leitao , Alexander Lobakin , "open list:DOCUMENTATION" , open list , "moderated list:INTEL ETHERNET DRIVERS" Subject: Re: [RFC net-next v4 3/9] net: napi: Make gro_flush_timeout per-NAPI Message-ID: Mail-Followup-To: Joe Damato , netdev@vger.kernel.org, mkarsten@uwaterloo.ca, skhawaja@google.com, sdf@fomichev.me, bjorn@rivosinc.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Tony Nguyen , Przemek Kitszel , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , David Ahern , Kory Maincent , Johannes Berg , Breno Leitao , Alexander Lobakin , "open list:DOCUMENTATION" , open list , "moderated list:INTEL ETHERNET DRIVERS" References: <20241001235302.57609-1-jdamato@fastly.com> <20241001235302.57609-4-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001235302.57609-4-jdamato@fastly.com> On Tue, Oct 01, 2024 at 11:52:34PM +0000, Joe Damato wrote: [...] > Note that idpf has embedded napi_struct in its internals and has > established some series of asserts that involve the size of napi > structure. Since this change increases the napi_struct size from 400 to > 416 (according to pahole on my system), I've increased the assertion in > idpf by 16 bytes. No attention whatsoever was paid to the cacheline > placement of idpf internals as a result of this change. > > Signed-off-by: Joe Damato > --- > .../networking/net_cachelines/net_device.rst | 2 +- > drivers/net/ethernet/intel/idpf/idpf_txrx.h | 2 +- > include/linux/netdevice.h | 3 +- > net/core/dev.c | 12 +++--- > net/core/dev.h | 40 +++++++++++++++++++ > net/core/net-sysfs.c | 2 +- > 6 files changed, 51 insertions(+), 10 deletions(-) [...] > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h b/drivers/net/ethernet/intel/idpf/idpf_txrx.h > index f0537826f840..fcdf73486d46 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.h > @@ -438,7 +438,7 @@ struct idpf_q_vector { > __cacheline_group_end_aligned(cold); > }; > libeth_cacheline_set_assert(struct idpf_q_vector, 112, > - 424 + 2 * sizeof(struct dim), > + 440 + 2 * sizeof(struct dim), > 8 + sizeof(cpumask_var_t)); > > struct idpf_rx_queue_stats { Now that idpf was fixed separately [1], this will be removed in the v5. [1]: https://lore.kernel.org/netdev/20241004105407.73585-1-jdamato@fastly.com/