From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, mkarsten@uwaterloo.ca,
skhawaja@google.com, sdf@fomichev.me, bjorn@rivosinc.com,
amritha.nambiar@intel.com, sridhar.samudrala@intel.com,
willemdebruijn.kernel@gmail.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Jiri Pirko <jiri@resnulli.us>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next v4 5/9] net: napi: Add napi_config
Date: Tue, 8 Oct 2024 15:28:01 -0700 [thread overview]
Message-ID: <ZwWx8V1kQBDLFT6i@LQ3V64L9R2> (raw)
In-Reply-To: <20241008151701.6f8bb389@kernel.org>
On Tue, Oct 08, 2024 at 03:17:01PM -0700, Jakub Kicinski wrote:
> On Tue, 1 Oct 2024 23:52:36 +0000 Joe Damato wrote:
> > static inline void netdev_set_defer_hard_irqs(struct net_device *netdev,
> > u32 defer)
> > {
> > + unsigned int count = max(netdev->num_rx_queues,
> > + netdev->num_tx_queues);
> > struct napi_struct *napi;
> > + int i;
> >
> > WRITE_ONCE(netdev->napi_defer_hard_irqs, defer);
> > list_for_each_entry(napi, &netdev->napi_list, dev_list)
> > napi_set_defer_hard_irqs(napi, defer);
> > +
> > + if (netdev->napi_config)
>
> Could this ever be NULL ?
Ah, good catch. I think this was an artifact from a previous
revision where it could have been. But, I'll double check.
In the current proposed implementation, however, I don't think it
can be NULL as it is always allocated.
next prev parent reply other threads:[~2024-10-08 22:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 23:52 [RFC net-next v4 0/9] Add support for per-NAPI config via netlink Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 1/9] net: napi: Make napi_defer_hard_irqs per-NAPI Joe Damato
2024-10-08 22:08 ` Jakub Kicinski
2024-10-01 23:52 ` [RFC net-next v4 3/9] net: napi: Make gro_flush_timeout per-NAPI Joe Damato
2024-10-08 18:22 ` Joe Damato
2024-10-08 22:10 ` Jakub Kicinski
2024-10-01 23:52 ` [RFC net-next v4 5/9] net: napi: Add napi_config Joe Damato
2024-10-08 18:19 ` Joe Damato
2024-10-08 22:17 ` Jakub Kicinski
2024-10-08 22:28 ` Joe Damato [this message]
2024-10-03 23:29 ` [RFC net-next v4 0/9] Add support for per-NAPI config via netlink Stanislav Fomichev
2024-10-03 23:53 ` Joe Damato
2024-10-04 2:33 ` Joe Damato
2024-10-04 16:22 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwWx8V1kQBDLFT6i@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=amritha.nambiar@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bjorn@rivosinc.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox