From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5105D1D95BE; Mon, 28 Oct 2024 09:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.178.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730109058; cv=none; b=FkC1pEI+FdaA8n0hii5/rCjLOIJil3fkHXxS8j3J4hrWp13q/SehbxoM4oPaxSdea8rbPo2eMpQkCvLCsHSgzCqSz9LrZ4NlrmIWxS3GOaOwrOGNO4pcmA4dzGGskoaAi1jAGO/dAgue5PyjTZLFDPxF20xv3qUGIiq4vijG2fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730109058; c=relaxed/simple; bh=LfVQuB/WLqPaPCpXPkT77PgzRCUObwYGWxP9FvMV96A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f5hn68S0ezUsZQxRd7NP0zlkl4RQQ9rXkm6QGCsboZ/LXGamQEyAH2zq7O72ZofAyvxeLvpAEbYgVI/RP+X5fVwRtESMZZMqEAFcEGnep1raZRAM4NrQc4lyHidgzjpnPwi33QzjW9ygjTe7uKvfi5FCJJi6XhM55sFeLzNPZnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=SeZA7dLh; arc=none smtp.client-ip=217.70.178.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="SeZA7dLh" Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id CD7F2C2482; Mon, 28 Oct 2024 09:50:46 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9C3E0C0002; Mon, 28 Oct 2024 09:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1730109038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ygwefzZm0X7crB1kSh4UYJ0HwJIwFEtTPF1aw1C4w/s=; b=SeZA7dLhDS7D1EZbMB2iOlLN35lvktN9jpFGEeyc6TjBMd4rodrqsVBGnIOer1sGR7VLOZ VTg2iMVJC+XS0eLUVvTEsqpJ/Z8hxNMe2tkslEINHczbhSwRUZmv6N7qbc+a1r+RIRv/kX ljsJ0nIKpAzEEsbIpqYG5dI+1TY74WOx+WR13CrxBQh4hhlJfCTKsxCkHk8E8xC+jDtb4n U6Qs/YnmGXlv+JMMhjswURMtB6YkT8bgnnpab3JKueglxaB/MJS0gHmatOGVsaXO+2QNku BFT2WKMMUn7jx9Ruy9umOv/buSUD2/nVpHxS7fnWTDN7kW4r1+56zM59lquPzw== Date: Mon, 28 Oct 2024 10:50:35 +0100 From: Louis Chauvet To: =?iso-8859-1?Q?Ma=EDra?= Canal Cc: Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Jonathan Corbet , Simona Vetter , rdunlap@infradead.org, arthurgrillo@riseup.net, pekka.paalanen@haloniitty.fi, Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, thomas.petazzoni@bootlin.com, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com Subject: Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify Message-ID: Mail-Followup-To: =?iso-8859-1?Q?Ma=EDra?= Canal , Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Jonathan Corbet , Simona Vetter , rdunlap@infradead.org, arthurgrillo@riseup.net, pekka.paalanen@haloniitty.fi, Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, thomas.petazzoni@bootlin.com, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com References: Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-GND-Sasl: louis.chauvet@bootlin.com On 26/10/24 - 09:10, Maíra Canal wrote: > Hi Louis, > > On 14/10/24 05:39, Louis Chauvet wrote: > > On 11/10/24 - 10:53, Maira Canal wrote: > > > Hi Louis, > > > > > > On 10/11/24 06:36, Louis Chauvet wrote: > > > > > > > > Hi all, > > > > > > > > Until this point, this series has not received any major comments since > > > > v9. I will commit patches 1-9 next week if there are no further comments. > > > > > > > > > > Although we are maintainers of VKMS, it isn't recommended that we push > > > our own changes without even the Ack of another person. Please, read the > > > "drm-misc Committer Guidelines" [1]. > > > > Hi Maíra, Maxime, > > > > I apologize for this rushed commit request. I sent the initial email with > > a delay before the commit action because I was not sure about the > > procedure and wanted to give others a chance to raise any concerns. > > Unfortunately, I overlooked the need to collect an Ack/Review for each > > patch, even when there hadn't been any responses for several months. I'm > > sorry for this oversight. > > > > > I can ack patches 05/15, 07/15, and 09/15, but it would be more > > > beneficial for the community if you ask for an ack (from me or from the > > > DRM maintainers, which are always around), instead of saying that you > > > are going to commit the patches without any review. > > > > I will be happy to ask for acknowledgments if needed, but as you mentioned > > multiple times: nobody is paid to maintain VKMS. Since you did not comment > > these series since July, when you told me you would review my patches, I > > assumed it was either okay or you no longer had the time to maintain > > (which I completely understand). > > Yeah, I'm a volunteer and no longer have time to maintain VKMS. A couple > of weeks ago I sent a patch removing myself as VKMS maintainer. This > doesn't imply that patches can be pushed without review. I will acked-by and push your patch, it will be an easy "first commit". If I do something wrong during the process, please tell me. Thanks for this precision, I understood this, and I will not push without reviews, don't worry! Thanks a lot for all your reviews! > We are a community with several active developers. Although I don't have > time to properly review your patches, you can try to gather other > developers to review your patches. You can try to use #dri-devel to get > reviewers. Thanks for the tip, I will do this! > That said, you can add my ACK to patches 05/15, 07/15, and 09/15 and > push the patches. I won't ack the YUV patches as I don't feel > comfortable reviewing/acking those. Perfect for the patches 1..9, it will be a very nice step forward and will reduce my conflicts a lot with the rest of my work! > Acked-by: Maíra Canal > > BTW if the patches are fixing IGT tests, please update the list of fails > and skips on DRM CI. For this, how should I do? Commit the series and wait for the bot results? Run tests on my computer (I only have a x86 VM)? Is there some doc somewhere? Thanks a lot, Louis Chauvet > Best Regards, > - Maíra > > > > > So, I hereby formally request reviews/ACKs for the following series: > > > > [this series]:https://lore.kernel.org/all/20241007-yuv-v12-0-01c1ada6fec8@bootlin.com/ > > [2]:https://lore.kernel.org/all/20241007-b4-new-color-formats-v2-0-d47da50d4674@bootlin.com/ > > [3]:https://lore.kernel.org/all/20240516-writeback_line_by_line-v1-0-7b2e3bf9f1c9@bootlin.com/ > > > > (I have to send a v2 for [3] because of rebase conflict, but nothing else > > changed) > > > > Thanks a lot, > > Louis Chauvet > > > [1] https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html > > > > > > Best Regards, > > > - Maíra > > > > > > > For patches 10-15, I am currently waiting for feedback from Maxime to > > > > send the next iteration with a fix for kunit tests. > > > > > > > > Thanks, > > > > Louis Chauvet > > > > > > > > On 07/10/24 - 18:10, Louis Chauvet wrote: > > > > > As all the rotation are now supported by VKMS, this simplification does > > > > > not make sense anymore, so remove it. > > > > > > > > > > Signed-off-by: Louis Chauvet > > > > > --- > > > > > drivers/gpu/drm/vkms/vkms_plane.c | 7 +------ > > > > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > > > > > index 8875bed76410..5a028ee96c91 100644 > > > > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > > > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > > > > @@ -115,12 +115,7 @@ static void vkms_plane_atomic_update(struct drm_plane *plane, > > > > > frame_info->fb = fb; > > > > > memcpy(&frame_info->map, &shadow_plane_state->data, sizeof(frame_info->map)); > > > > > drm_framebuffer_get(frame_info->fb); > > > > > - frame_info->rotation = drm_rotation_simplify(new_state->rotation, DRM_MODE_ROTATE_0 | > > > > > - DRM_MODE_ROTATE_90 | > > > > > - DRM_MODE_ROTATE_270 | > > > > > - DRM_MODE_REFLECT_X | > > > > > - DRM_MODE_REFLECT_Y); > > > > > - > > > > > + frame_info->rotation = new_state->rotation; > > > > > vkms_plane_state->pixel_read_line = get_pixel_read_line_function(fmt); > > > > > } > > > > > > > > > > -- > > > > > 2.46.2 > > > > >