From: Hangbin Liu <liuhangbin@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Andrii Nakryiko <andriin@fb.com>, Jussi Maki <joamaki@gmail.com>,
Jay Vosburgh <jv@jvosburgh.net>,
Andy Gospodarek <andy@greyhouse.net>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCHv2 net-next 2/3] bonding: use correct return value
Date: Fri, 18 Oct 2024 00:46:18 +0000 [thread overview]
Message-ID: <ZxGv2s4bl5VQV4g-@fedora> (raw)
In-Reply-To: <878qumzszs.fsf@toke.dk>
On Thu, Oct 17, 2024 at 04:47:19PM +0200, Toke Høiland-Jørgensen wrote:
> > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> > index f0f76b6ac8be..6887a867fe8b 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -5699,7 +5699,7 @@ static int bond_xdp_set(struct net_device *dev, struct bpf_prog *prog,
> > if (dev_xdp_prog_count(slave_dev) > 0) {
> > SLAVE_NL_ERR(dev, slave_dev, extack,
> > "Slave has XDP program loaded, please unload before enslaving");
> > - err = -EOPNOTSUPP;
> > + err = -EEXIST;
>
> Hmm, this has been UAPI since kernel 5.15, so can we really change it
> now? What's the purpose of changing it, anyway?
I just think it should return EXIST when the error is "Slave has XDP program
loaded". No special reason. If all others think we should not change it, I
can drop this patch.
Thanks
Hangbin
next prev parent reply other threads:[~2024-10-18 0:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 2:06 [PATCHv2 net-next 0/3] Bonding: returns detailed error about XDP failures Hangbin Liu
2024-10-17 2:06 ` [PATCHv2 net-next 1/3] bonding: return detailed error when loading native XDP fails Hangbin Liu
2024-10-17 14:45 ` Toke Høiland-Jørgensen
2024-10-17 2:06 ` [PATCHv2 net-next 2/3] bonding: use correct return value Hangbin Liu
2024-10-17 14:47 ` Toke Høiland-Jørgensen
2024-10-18 0:46 ` Hangbin Liu [this message]
2024-10-18 9:41 ` Simon Horman
2024-10-18 11:29 ` Toke Høiland-Jørgensen
2024-10-18 14:21 ` Simon Horman
2024-10-19 0:51 ` Hangbin Liu
2024-10-19 9:19 ` Simon Horman
2024-10-17 2:06 ` [PATCHv2 net-next 3/3] Documentation: bonding: add XDP support explanation Hangbin Liu
2024-10-17 8:42 ` Nikolay Aleksandrov
2024-10-17 8:40 ` [PATCHv2 net-next 0/3] Bonding: returns detailed error about XDP failures Nikolay Aleksandrov
2024-10-17 9:26 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxGv2s4bl5VQV4g-@fedora \
--to=liuhangbin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andriin@fb.com \
--cc=andy@greyhouse.net \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jiri@resnulli.us \
--cc=joamaki@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).