From: Guillaume Nault <gnault@redhat.com>
To: Breno Leitao <leitao@debian.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Akinobu Mita <akinobu.mita@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v6] net: Implement fault injection forcing skb reallocation
Date: Fri, 8 Nov 2024 17:02:53 +0100 [thread overview]
Message-ID: <Zy42LfWaiWHJ12Nw@debian> (raw)
In-Reply-To: <20241107-fault_v6-v6-1-1b82cb6ecacd@debian.org>
On Thu, Nov 07, 2024 at 08:11:44AM -0800, Breno Leitao wrote:
> Introduce a fault injection mechanism to force skb reallocation. The
> primary goal is to catch bugs related to pointer invalidation after
> potential skb reallocation.
Nice to see this kind of debug option being worked on!
> +static bool should_fail_net_realloc_skb(struct sk_buff *skb)
> +{
> + struct net_device *net = skb->dev;
It's confusing to see a variable called "net" pointing to a struct
net_device. "net" generally refers to struct net.
In case v7 is needed, it'd be nice to call this variable "dev".
Looks good to me otherwise.
Acked-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2024-11-08 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 16:11 [PATCH net-next v6] net: Implement fault injection forcing skb reallocation Breno Leitao
2024-11-08 16:02 ` Guillaume Nault [this message]
2024-11-12 11:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy42LfWaiWHJ12Nw@debian \
--to=gnault@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).