Re: [PATCH net-next v5 5/7] bnxt_en: add support for header-data-split-thresh ethtool command

Taehee Yoo
2024-11-15T16:18:19Z

On Fri, Nov 15, 2024 at 9:27 AM Michael Chan <michael.chan@broadcom.com> wrote:
>

Hi Michael,
Thank you so much for the review!

> On Thu, Nov 14, 2024 at 2:54 PM Andy Gospodarek
> <andrew.gospodarek@broadcom.com> wrote:
> >
> > On Wed, Nov 13, 2024 at 05:32:19PM +0000, Taehee Yoo wrote:
> > > The bnxt_en driver has configured the hds_threshold value automatically
> > > when TPA is enabled based on the rx-copybreak default value.
> > > Now the header-data-split-thresh ethtool command is added, so it adds an
> > > implementation of header-data-split-thresh option.
> > >
> > > Configuration of the header-data-split-thresh is allowed only when
> > > the header-data-split is enabled. The default value of
> > > header-data-split-thresh is 256, which is the default value of
> > > rx-copybreak, which used to be the hds_thresh value.
> > >
> > > # Example:
> > > # ethtool -G enp14s0f0np0 tcp-data-split on header-data-split-thresh 256
> > > # ethtool -g enp14s0f0np0
> > > Ring parameters for enp14s0f0np0:
> > > Pre-set maximums:
> > > ...
> > > Header data split thresh: 256
> > > Current hardware settings:
> > > ...
> > > TCP data split: on
> > > Header data split thresh: 256
> > >
> > > Tested-by: Stanislav Fomichev <sdf@fomichev.me>
> > > Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> >
> > Tested-by: Andy Gospodarek <gospo@broadcom.com>
> >
>
> > > @@ -2362,6 +2362,8 @@ struct bnxt {
> > > u8 q_ids[BNXT_MAX_QUEUE];
> > > u8 max_q;
> > > u8 num_tc;
> > > +#define BNXT_HDS_THRESHOLD_MAX 256
>
> As mentioned in my comments for patch #1, our NIC can support HDS
> threshold of up to 1023, so we can set this to 1023. Thanks.

Thanks for checking, I will change it to 1023.

Thanks a lot!
Taehee Yoo