Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh

Taehee Yoo
2024-11-15T18:05:46Z

On Fri, Nov 15, 2024 at 1:24 PM Jakub Kicinski <kuba@kernel.org> wrote:
>

Hi Jakub,
Thanks a lot for the review!

> On Wed, 13 Nov 2024 17:32:18 +0000 Taehee Yoo wrote:
> > + ``ETHTOOL_A_RINGS_HEADER_DATA_SPLIT_THRESH`` u32 threshold of
> > + header / data split
> > + ``ETHTOOL_A_RINGS_HEADER_DATA_SPLIT_THRESH_MAX`` u32 max threshold of
>
> nit: s/_HEADER_DATA_SPLIT_/_HDS_/ ;)
>
> We can explain in the text that HDS stands for header data split.
> Let's not bloat the code with 40+ character names...

I'm not familiar with the ynl, but I think there are some dependencies
between Documentation/netlink/spec/ethtool.yaml.
Because It seems to generate ethtool-user.c code automatically based
on ethtool.yaml spec. I think If we change this name to HDS, it need to
change ethtool spec form "header-data-split-thresh" to "hds-thresh" too.

However, I agree with changing ethtool option name from
"header-data-split-thresh" to "hds-thresh". So, If I understand correctly,
what about changing ethtool option name from "header-data-split-thresh"
to "hds-thresh"?

Thanks a lot!
Taehee Yoo