Re: [PATCH v9 1/9] x86/resctrl: Introduce resctrl_file_fflags_init() to initialize fflags

Luck, Tony
2024-11-21T17:21:59Z

On Tue, Nov 19, 2024 at 04:38:15PM -0800, Reinette Chatre wrote:
> Hi Tony,
>
> On 11/13/24 4:17 PM, Tony Luck wrote:
> > From: Babu Moger <babu.moger@amd.com>
> >
> > thread_throttle_mode_init() and mbm_config_rftype_init() both initialize
> > fflags for resctrl files.
> >
> > Adding new files will involve adding another function to initialize
> > the fflags. This can be simplified by adding a new function
> > resctrl_file_fflags_init() and passing the file name and flags
> > to be initialized.
> >
> > Consolidate fflags initialization into resctrl_file_fflags_init() and
> > remove thread_throttle_mode_init() and mbm_config_rftype_init().
> >
> > Signed-off-by: Babu Moger <babu.moger@amd.com>
> > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> > Signed-off-by: Tony Luck <tony.luck@intel.com>
>
> Please place "Signed-off-by" tag before "Reviewed-by" tag. For reference,
> "Ordering of commit tags" in Documentation/process/maintainer-tip.rst

Hi Reinette,

I had misremembered what that Documentation file said. There is a
section that describes keeping the Signed-off-by: tags in the order
they were applied so that the commit comment describes the path that
the patch took before final acceptance. I thought that ordering applied
to other tags.

But while I was there refreshing my memory I also noted the section
about documenting changes made when adopting patches from other
people. So I've added:

[Tony: Drop __init attribute so resctrl_file_fflags_init() can be used
at run time]
>
> Reinette

-Tony