From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A645816E866 for ; Thu, 11 Jul 2024 19:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720726207; cv=none; b=vAaQMnLVqFeiawgE+g9YxxNSA9inMUGTjyzJyVRJ1/sdnfq6KpcAPhwG/4Yk+t4ZmYaInSQ3PYTKW7bQl6OW1zzpgVexRGmBRoVt0lByZrH3EVRi6C/WXOB3Q1Yu80SJGYVyQWZWDWVATTd251vtWXhiZekiIcxOTd+R/l7sgAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720726207; c=relaxed/simple; bh=6PZa26qh4ymqFwVL8Iv7QFaHKJWBv371YVweZ2Zn+Z4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L7ILyFby5gFrVmsT2Qk6d+wXcH9DEaIqknhg5wHOtJxvm35PGjDcB92pJ+9y/DGxyl+wWfqIAJYon0ifp8Z2DfuGN77g2IFLK0oX6UEjvhwPC6i2B+EnswDXIgsKI5qhNwYJtLtbLqA/2AIJthf/fIm8szD8p8CMYU8qMmc7V2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bpl2OKdX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bpl2OKdX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720726204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O/kdd0m2F7APQz5PEDRpjUvqai4YyztOcotNYxJFWVw=; b=Bpl2OKdX+XRcobu0IMNpDQwmaUgjG6A43QPX2MqLxLlllHQNHTqv04CURCOTcvYDBUeSJY JNeL5Z6Nhk0PfGtGS69UpCvq5EK4aBCNiH0dy3Xmr/UKDPpDTsE4G63ZJfHvGMVwyytDmI u19WIC69OEHZpSFMMsDLYevWNwVQmvg= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-sovNFfwoN3ijfo5emT_STg-1; Thu, 11 Jul 2024 15:30:01 -0400 X-MC-Unique: sovNFfwoN3ijfo5emT_STg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 53DCD19560B1; Thu, 11 Jul 2024 19:29:59 +0000 (UTC) Received: from [10.22.64.119] (unknown [10.22.64.119]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 59AF43000181; Thu, 11 Jul 2024 19:29:57 +0000 (UTC) Message-ID: Date: Thu, 11 Jul 2024 15:29:56 -0400 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] cgroup: Show # of subsystem CSSes in cgroup.stat To: Tejun Heo Cc: Johannes Weiner , Zefan Li , Jonathan Corbet , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Kamalesh Babulal , Roman Gushchin References: <20240710182353.2312025-1-longman@redhat.com> <20240711134927.GB456706@cmpxchg.org> <4e1078d6-6970-4eea-8f73-56a3815794b5@redhat.com> <76e70789-986a-44c2-bfdc-d636f425e5ae@redhat.com> Content-Language: en-US From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 7/11/24 15:21, Tejun Heo wrote: > Hello, > > On Thu, Jul 11, 2024 at 03:13:12PM -0400, Waiman Long wrote: >> That will means cgroup subsystems that are seldomly used like rdma, misc or >> even hugetlb will always be shown in all the cgroup.stat output. I actually > Hmm... yeah, that does increase the amount of output, but I don't know. The > trade-off is between consistency and brevity and I think I'd go for > consistency here. > >> prefer just showing those that are enabled. As for dying memory cgroups, >> they will only be shown in its online ancestors. We currently don't know how > So, one peculiarity with memory is that when you enable io, it gets > implicitly enabled together and we likely wanna show that. If memory is implicitly enabled, it is treated as enabled as the corresponding cgroup->subsys[] entry should be set. I currently don't filter out those in the cgrp_dfl_implicit_ss_mask. So perf_event, which is implicitly enabled, is shown in all the cgroup.stat. If you still want to display all even if some of them are not enabled, I can certainly do that. Cheers, Longman