From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADA2123C8CB for ; Thu, 17 Apr 2025 12:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744893424; cv=none; b=pJCBbqkgwJPaDtRGgdkb3S9ebwPPzZFGOmaC/+a7CC9iOYesmq8xuVmQwf5jws5Ow66OrkhHD2uGkrKuUDHvhuBSs55aAMvxJnDgeE8heCa2R1klT7x8XrGIb38OILtfcYB/dh2DdfXrlRNT0eWdeEGBExKyvKo+3qhu9umzZ2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744893424; c=relaxed/simple; bh=z8BywmB7U7TmFZECdgY4Am3vkqHwYELaHUoKH8WUIW4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b6ZvWnwQ/QJVV5KPaSfaVeXN1Jd9Tn8zUsq9zWzUCj8RqTkdkkoIUhCv6e1Qatidh9f3MUc/bwd4jJhfWjPu1bm6g3coAJc2MxPwQ7YW3JEdIFpYq/M/xjRKt86Df5Ez4ClXYVvl9PF+np/yHrOwkRphH3ET3DBXN6kUj+E71Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TKYfQPU2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TKYfQPU2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744893421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SAJBhTbOABggX16wvpv2vgV0fRUNwe643nUmUBYY404=; b=TKYfQPU2Mthg91Rd7/dakSZsc1KllHjXHN4EnaqgvpDk+4oJawIUr5o7LUCCymQt9+0eVg I9KVIPwiTZoYnSUs+0K+t2rY8RfoE946/yBKJkMoQcUi2lxMpbzvBViXbEqdfBRD8CyFST S+kuo218814T+HwBDn1S3aYoRSOdewc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-GXZ4MJl5Me6xa8TO85Hdqw-1; Thu, 17 Apr 2025 08:37:00 -0400 X-MC-Unique: GXZ4MJl5Me6xa8TO85Hdqw-1 X-Mimecast-MFC-AGG-ID: GXZ4MJl5Me6xa8TO85Hdqw_1744893420 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c5c9abdbd3so60856585a.1 for ; Thu, 17 Apr 2025 05:37:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744893420; x=1745498220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SAJBhTbOABggX16wvpv2vgV0fRUNwe643nUmUBYY404=; b=A50oc/GB2rshECwF44jlNeFpzBroAuB39WJtd4sIi0KXnqVG4MrXVrfXw6C3iuaOFw J9Q6h84SD8lJrih3/FT4IuVeW4oh+B0AMdwtVfhIksQsb8ey6Fn+spZztu/UgmcyWDSa G+jDhx/B8DdyrzCs0OtaBrR4+MH85BbOY9NmOseuHai7hb+wZUUnA5y9CKe7iNGS5O11 jU973ooYF7urq6PUQIxtzAXLakXHKzz9De2ItFLf69DCzUXxzCqifYLQn1zL3ldg6Zcj IIo2+zJBpia7LycvldGF8dsKVnSAfcx6sTlTOsv+GzFVAoMofDjaeG1+lcKEBmPDoYIX 8UTQ== X-Forwarded-Encrypted: i=1; AJvYcCV9GkiBevziHDqB7ehpUJBgyAzvHatCY+A7mWG7/WL+yGy+dfFeliYf1uPKAUm1YSa8LESEftNf/bg=@vger.kernel.org X-Gm-Message-State: AOJu0YzAyPzJh3sT1wEPJcLUeTZwSpUdzwwS2XZzjdk47J9R/6DaKfe6 tu5chNFIF+bTGvhckDBvkGNTPLuLITtEaqduM0aCSxuPbM2XHO6+yI2hIYKNyskqVA9Pc15Hdo4 LCZArJJk64QrtwcF6Fj0NDD8/SaMuHt2M/an4wBiv9B84Po4ofon5e3AeEQ== X-Gm-Gg: ASbGncsUWp8UXgoweyk9sRiv0ysjhUq/K6rhtVirBA8WnAWVwFWlQYCmjAm4dnzEgNp YOqbOSlb83VcknGk65MUaqIPAI93h5htOikPzlWfYKwI+YdKcpWOKgitMd5V+YCaMWYMDTpzsxh tjbdDfpXOFHgD/AquKJK4DvAaC2LQDx46MPOlsq5/AwIN4vHkuDxXmFktOSstf5kOpphMFyD0rH 1Cf5WqCJgd/UzWKC5YBZvOgd68+QEPIjRnlN5xfEmYn0pobUnYQnLJ0B+S5V3d9hVAkrAAQG4de VfKL0L4U0MrxpKmL8/mGlm5RDuB1IXdJdf54d9f7O7lZjjhOF7uenQ== X-Received: by 2002:a05:620a:2629:b0:7c7:ad79:a087 with SMTP id af79cd13be357-7c9190875f7mr865551985a.57.1744893419777; Thu, 17 Apr 2025 05:36:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuHxFULT3nNni+vu8M3Vjd+F9IkWUkQuz6UZU9DS4yGU16eKaT0xWtw67tyWocpLYiA1XROw== X-Received: by 2002:a05:620a:2629:b0:7c7:ad79:a087 with SMTP id af79cd13be357-7c9190875f7mr865548585a.57.1744893419359; Thu, 17 Apr 2025 05:36:59 -0700 (PDT) Received: from athena.aquini.home (c-76-23-219-111.hsd1.me.comcast.net. [76.23.219.111]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c7a89f98eesm1173067885a.83.2025.04.17.05.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 05:36:58 -0700 (PDT) Date: Thu, 17 Apr 2025 08:36:55 -0400 From: Rafael Aquini To: Kees Cook Cc: Petr Mladek , Sergio Perez Gonzalez , Vlastimil Babka , David Rientjes , Bagas Sanjaya , Jonathan Corbet , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Roman Gushchin , Harry Yoo , "Paul E. McKenney" , Randy Dunlap , Tamir Duberstein , Miguel Ojeda , Alice Ryhl , linux-doc@vger.kernel.org, linux-mm@kvack.org, Thomas Huth , "Borislav Petkov (AMD)" , Ard Biesheuvel , Greg Kroah-Hartman , Andreas Hindborg , Stephen Boyd , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] slab: Decouple slab_debug and no_hash_pointers Message-ID: References: <20250415170232.it.467-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415170232.it.467-kees@kernel.org> On Tue, Apr 15, 2025 at 10:02:33AM -0700, Kees Cook wrote: > Some system owners use slab_debug=FPZ (or similar) as a hardening option, > but do not want to be forced into having kernel addresses exposed due > to the implicit "no_hash_pointers" boot param setting.[1] > > Introduce the "hash_pointers" boot param, which defaults to "auto" > (the current behavior), but also includes "always" (forcing on hashing > even when "slab_debug=..." is defined), and "never". The existing > "no_hash_pointers" boot param becomes an alias for "hash_pointers=never". > > This makes it possible to boot with "slab_debug=FPZ hash_pointers=always". > > Link: https://github.com/KSPP/linux/issues/368 [1] > Fixes: 792702911f58 ("slub: force on no_hash_pointers when slub_debug is enabled") > Co-developed-by: Sergio Perez Gonzalez > Signed-off-by: Sergio Perez Gonzalez > Acked-by: Vlastimil Babka > Acked-by: David Rientjes > Reviewed-by: Bagas Sanjaya > Signed-off-by: Kees Cook > --- > v2: use switch state to avoid missing states (pmladek) > v1: https://lore.kernel.org/lkml/20250410174428.work.488-kees@kernel.org/ > Cc: Petr Mladek > Cc: Vlastimil Babka > Cc: Jonathan Corbet > Cc: Steven Rostedt > Cc: Andy Shevchenko > Cc: Rasmus Villemoes > Cc: Sergey Senozhatsky > Cc: Andrew Morton > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Roman Gushchin > Cc: Harry Yoo > Cc: "Paul E. McKenney" > Cc: Randy Dunlap > Cc: Tamir Duberstein > Cc: Miguel Ojeda > Cc: Alice Ryhl > Cc: linux-doc@vger.kernel.org > Cc: linux-mm@kvack.org > --- > .../admin-guide/kernel-parameters.txt | 34 +++++++---- > include/linux/sprintf.h | 2 +- > lib/vsprintf.c | 61 +++++++++++++++++-- > mm/slub.c | 5 +- > 4 files changed, 82 insertions(+), 20 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 76e538c77e31..d0fd9c745db9 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -1798,6 +1798,27 @@ > backtraces on all cpus. > Format: 0 | 1 > > + hash_pointers= > + [KNL,EARLY] > + By default, when pointers are printed to the console > + or buffers via the %p format string, that pointer is > + "hashed", i.e. obscured by hashing the pointer value. > + This is a security feature that hides actual kernel > + addresses from unprivileged users, but it also makes > + debugging the kernel more difficult since unequal > + pointers can no longer be compared. The choices are: > + Format: { auto | always | never } > + Default: auto > + > + auto - Hash pointers unless slab_debug is enabled. > + always - Always hash pointers (even if slab_debug is > + enabled). > + never - Never hash pointers. This option should only > + be specified when debugging the kernel. Do > + not use on production kernels. The boot > + param "no_hash_pointers" is an alias for > + this mode. > + > hashdist= [KNL,NUMA] Large hashes allocated during boot > are distributed across NUMA nodes. Defaults on > for 64-bit NUMA, off otherwise. > @@ -4120,18 +4141,7 @@ > > no_hash_pointers > [KNL,EARLY] > - Force pointers printed to the console or buffers to be > - unhashed. By default, when a pointer is printed via %p > - format string, that pointer is "hashed", i.e. obscured > - by hashing the pointer value. This is a security feature > - that hides actual kernel addresses from unprivileged > - users, but it also makes debugging the kernel more > - difficult since unequal pointers can no longer be > - compared. However, if this command-line option is > - specified, then all normal pointers will have their true > - value printed. This option should only be specified when > - debugging the kernel. Please do not use on production > - kernels. > + Alias for "hash_pointers=never". > > nohibernate [HIBERNATION] Disable hibernation and resume. > > diff --git a/include/linux/sprintf.h b/include/linux/sprintf.h > index 51cab2def9ec..521bb2cd2648 100644 > --- a/include/linux/sprintf.h > +++ b/include/linux/sprintf.h > @@ -22,7 +22,7 @@ __scanf(2, 0) int vsscanf(const char *, const char *, va_list); > > /* These are for specific cases, do not use without real need */ > extern bool no_hash_pointers; > -int no_hash_pointers_enable(char *str); > +void hash_pointers_finalize(bool slub_debug); > > /* Used for Rust formatting ('%pA') */ > char *rust_fmt_argument(char *buf, char *end, const void *ptr); > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 01699852f30c..22cbd75266ef 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -60,6 +60,20 @@ > bool no_hash_pointers __ro_after_init; > EXPORT_SYMBOL_GPL(no_hash_pointers); > > +/* > + * Hashed pointers policy selected by "hash_pointers=..." boot param > + * > + * `auto` - Hashed pointers enabled unless disabled by slub_debug_enabled=true > + * `always` - Hashed pointers enabled unconditionally > + * `never` - Hashed pointers disabled unconditionally > + */ > +enum hash_pointers_policy { > + HASH_PTR_AUTO = 0, > + HASH_PTR_ALWAYS, > + HASH_PTR_NEVER > +}; > +static enum hash_pointers_policy hash_pointers_mode __initdata; > + > noinline > static unsigned long long simple_strntoull(const char *startp, char **endp, unsigned int base, size_t max_chars) > { > @@ -2271,12 +2285,23 @@ char *resource_or_range(const char *fmt, char *buf, char *end, void *ptr, > return resource_string(buf, end, ptr, spec, fmt); > } > > -int __init no_hash_pointers_enable(char *str) > +void __init hash_pointers_finalize(bool slub_debug) > { > - if (no_hash_pointers) > - return 0; > + switch (hash_pointers_mode) { > + case HASH_PTR_ALWAYS: > + no_hash_pointers = false; > + break; > + case HASH_PTR_NEVER: > + no_hash_pointers = true; > + break; > + case HASH_PTR_AUTO: > + default: > + no_hash_pointers = slub_debug; > + break; > + } > > - no_hash_pointers = true; > + if (!no_hash_pointers) > + return; > > pr_warn("**********************************************************\n"); > pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); > @@ -2289,11 +2314,39 @@ int __init no_hash_pointers_enable(char *str) > pr_warn("** the kernel, report this immediately to your system **\n"); > pr_warn("** administrator! **\n"); > pr_warn("** **\n"); > + pr_warn("** Use hash_pointers=always to force this mode off **\n"); > + pr_warn("** **\n"); > pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); > pr_warn("**********************************************************\n"); > +} > + > +static int __init hash_pointers_mode_parse(char *str) > +{ > + if (!str) { > + pr_warn("Hash pointers mode empty; falling back to auto.\n"); > + hash_pointers_mode = HASH_PTR_AUTO; > + } else if (strncmp(str, "auto", 4) == 0) { > + pr_info("Hash pointers mode set to auto.\n"); > + hash_pointers_mode = HASH_PTR_AUTO; > + } else if (strncmp(str, "never", 5) == 0) { > + pr_info("Hash pointers mode set to never.\n"); > + hash_pointers_mode = HASH_PTR_NEVER; > + } else if (strncmp(str, "always", 6) == 0) { > + pr_info("Hash pointers mode set to always.\n"); > + hash_pointers_mode = HASH_PTR_ALWAYS; > + } else { > + pr_warn("Unknown hash_pointers mode '%s' specified; assuming auto.\n", str); > + hash_pointers_mode = HASH_PTR_AUTO; > + } > > return 0; > } > +early_param("hash_pointers", hash_pointers_mode_parse); > + > +static int __init no_hash_pointers_enable(char *str) > +{ > + return hash_pointers_mode_parse("never"); > +} > early_param("no_hash_pointers", no_hash_pointers_enable); > > /* > diff --git a/mm/slub.c b/mm/slub.c > index b46f87662e71..f3d61b330a76 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6314,9 +6314,8 @@ void __init kmem_cache_init(void) > if (debug_guardpage_minorder()) > slub_max_order = 0; > > - /* Print slub debugging pointers without hashing */ > - if (__slub_debug_enabled()) > - no_hash_pointers_enable(NULL); > + /* Inform pointer hashing choice about slub debugging state. */ > + hash_pointers_finalize(__slub_debug_enabled()); > > kmem_cache_node = &boot_kmem_cache_node; > kmem_cache = &boot_kmem_cache; > -- > 2.34.1 > > Thank you, Kees. Acked-by: Rafael Aquini