Re: [PATCH v2 09/22] iommufd/viommu: Introduce IOMMUFD_OBJ_VCMDQ and its related struct

Nicolin Chen
2025-05-05T15:45:46Z

On Mon, May 05, 2025 at 12:02:14PM -0300, Jason Gunthorpe wrote:
> On Mon, Apr 28, 2025 at 11:10:40AM -0700, Nicolin Chen wrote:
> > > > +struct iommufd_vcmdq {
> > > > + struct iommufd_object obj;
> > > > + struct iommufd_ctx *ictx;
> > > > + struct iommufd_viommu *viommu;
> > > > + dma_addr_t addr;
> > >
> > > It's better to add a comment to state that @addr is a guest physical
> > > address. Or not?
> >
> > Yea. Let's add one:
> >
> > dma_addr_t addr; /* in guest physical address space */
>
> If it is a guest physical in a nested page table it should technically
> be u64 not dma_addr_t

OK. Will change that in v4.

Thanks
Nicolin