RE: [PATCH v2 10/22] iommufd/viommmu: Add IOMMUFD_CMD_VCMDQ_ALLOC ioctl

Tian, Kevin
2025-05-06T09:26:21Z

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, April 30, 2025 1:15 AM
>
> On Tue, Apr 29, 2025 at 03:52:48PM +0530, Vasant Hegde wrote:
> > On 4/29/2025 12:15 PM, Nicolin Chen wrote:
> > > On Tue, Apr 29, 2025 at 11:04:06AM +0530, Vasant Hegde wrote:
> > >
> > > Will the hardware replace the physical device ID in the event with
> > > the virtual device ID when injecting the event to a guest event/PPR
> > > queue?
> > > If so, yea, I think you can define them separately using the> vCMDQ
> > infrastructures:
> > > - IOMMU_VCMDQ_TYPE_AMD_VIOMMU_CMDBUF
> > > - IOMMU_VCMDQ_TYPE_AMD_VIOMMU_EVENTLOG
> > > - IOMMU_VCMDQ_TYPE_AMD_VIOMMU_PPRLOG
> > > (@Kevin @Jason Hmm, in this case we might want to revert the naming
> > > "vCMDQ" back to "vQEUEUE", once Vasant confirms.)
>
> I think I should rename IOMMUFD_OBJ_VCMDQ back to
> IOMMUFD_OBJ_VQUEUE
> since the same object fits three types of queue now in the AMD case.
>
> Or any better naming suggestion?
>

What about IOMMUFD_OBJ_HQUEUE to differentiate from other
pure software queue structs? 'H" stands for direct hw access to
the queue object.