From: Bagas Sanjaya <bagasdotme@gmail.com>
To: George Anthony Vernon <contact@gvernon.com>,
dmitry.torokhov@gmail.com, corbet@lwn.net,
skhan@linuxfoundation.org
Cc: linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2 4/4] input: docs: Make headings compliant w/ guidelines
Date: Thu, 29 May 2025 08:20:49 +0700 [thread overview]
Message-ID: <aDe2ccCxG8I24gsQ@archie.me> (raw)
In-Reply-To: <20250526135957.180254-5-contact@gvernon.com>
[-- Attachment #1: Type: text/plain, Size: 4011 bytes --]
On Mon, May 26, 2025 at 02:59:52PM +0100, George Anthony Vernon wrote:
> diff --git a/Documentation/input/devices/amijoy.rst b/Documentation/input/devices/amijoy.rst
> index cbc5240f8af3..a81e9de481c7 100644
> --- a/Documentation/input/devices/amijoy.rst
> +++ b/Documentation/input/devices/amijoy.rst
> @@ -1,10 +1,12 @@
> -~~~~~~~~~~~~~~~
> +===============
> Amiga joysticks
> -~~~~~~~~~~~~~~~
> +===============
>
> +Pinouts
> +=======
>
> Amiga 4-joystick parallel port extension
> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +----------------------------------------
>
> Parallel port pins:
>
> @@ -19,8 +21,8 @@ Pin Meaning Pin Meaning
> 19 Gnd1 18 Gnd2
> ===== ======== ==== ==========
>
> -Amiga digital joystick pinout
> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +Amiga digital joystick
> +----------------------
>
> === ============
> Pin Meaning
> @@ -36,8 +38,8 @@ Pin Meaning
> 9 Thumb button
> === ============
>
> -Amiga mouse pinout
> -~~~~~~~~~~~~~~~~~~
> +Amiga mouse
> +-----------
>
> === ============
> Pin Meaning
> @@ -53,8 +55,8 @@ Pin Meaning
> 9 Right button
> === ============
>
> -Amiga analog joystick pinout
> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +Amiga analog joystick
> +---------------------
>
> === ==============
> Pin Meaning
> @@ -70,8 +72,8 @@ Pin Meaning
> 9 Analog Y
> === ==============
>
> -Amiga lightpen pinout
> -~~~~~~~~~~~~~~~~~~~~~
> +Amiga lightpen
> +--------------
>
> === =============
> Pin Meaning
> @@ -87,7 +89,11 @@ Pin Meaning
> 9 Stylus button
> === =============
>
> --------------------------------------------------------------------------------
> +Register addresses
> +==================
> +
> +JOY0DAT/JOY1DAT
> +---------------
>
> ======== === ==== ==== ====== ===========================================
> NAME rev ADDR type chip Description
> @@ -159,7 +165,8 @@ JOY1DAT Y7 Y6 Y5 Y4 Y3 Y2 Y1 Y0 X7 X6 X5 X4 X3 X2 X1 X0
> | Right | 4 | X1 |
> +------------+------+---------------------------------+
>
> --------------------------------------------------------------------------------
> +JOYTEST
> +-------
>
> ======== === ==== ==== ====== =================================================
> NAME rev ADDR type chip Description
> @@ -176,7 +183,8 @@ JOYTEST 036 W Denise Write to all 4 joystick-mouse counters at once.
> JOYxDAT Y7 Y6 Y5 Y4 Y3 Y2 xx xx X7 X6 X5 X4 X3 X2 xx xx
> ========= === === === === === === === === ====== === === === === === === ===
>
> --------------------------------------------------------------------------------
> +POT0DAT/POT1DAT
> +---------------
>
> ======= === ==== ==== ====== ===========================================
> NAME rev ADDR type chip Description
> @@ -217,7 +225,8 @@ POT1DAT h 014 R Paula Pot counter data right pair (vert., horiz.)
> the counters will count proportionally faster.
> This should be noted when doing variable beam displays.
>
> --------------------------------------------------------------------------------
> +POTGO
> +-----
>
> ====== === ==== ==== ====== ================================================
> NAME rev ADDR type chip Description
> @@ -226,7 +235,8 @@ POTGO 034 W Paula Pot port (4 bit) bi-direction and data, and pot
> counter start.
> ====== === ==== ==== ====== ================================================
>
> --------------------------------------------------------------------------------
> +POTINP
> +------
>
> ====== === ==== ==== ====== ================================================
> NAME rev ADDR type chip Description
LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-05-29 1:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 13:59 [PATCH v2 0/4] Multiple fixes to Amiga joystick documentation George Anthony Vernon
2025-05-26 13:59 ` [PATCH v2 1/4] input: docs: Fix broken table formatting George Anthony Vernon
2025-05-26 13:59 ` [PATCH v2 2/4] input: docs: Correct Amiga 4-jstick adapter pinout George Anthony Vernon
2025-05-26 13:59 ` [PATCH v2 3/4] input: docs: Fix Amiga joysticks grammar George Anthony Vernon
2025-05-29 1:20 ` Bagas Sanjaya
2025-05-29 1:23 ` Bagas Sanjaya
2025-05-26 13:59 ` [PATCH v2 4/4] input: docs: Make headings compliant w/ guidelines George Anthony Vernon
2025-05-29 1:20 ` Bagas Sanjaya [this message]
2025-05-30 22:35 ` [PATCH v2 0/4] Multiple fixes to Amiga joystick documentation Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDe2ccCxG8I24gsQ@archie.me \
--to=bagasdotme@gmail.com \
--cc=contact@gvernon.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).