From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9321E7C23; Mon, 16 Jun 2025 06:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.66 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750056460; cv=fail; b=hNv6atgGzAJUz2pMnSTs1+88QzQgCDBZfg3hytqnhnC2gzJBctVdKhMDlCiO/K9crCbEt10g4RcBgx/RJ/koEFI3LR6kY45VfQNn8u1RNmSqxYtdPvS/E3+rrZODVVaIwYK2zrIUsHpfKtb0v/oQJocfHPjZW/oO6vAbYhz5iiU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750056460; c=relaxed/simple; bh=JGMJQjCHJWYt7jNtOC6ILqZLmR5oC1nMR4q5h601VTU=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dJQeNZAyIH5489CCxXlvlhaRAHZqkf/8wdZ8CBK6sf0L9QsSnJR2d3JHt6ppBq//ta0zqEuGdosOXxFVnq6zTKtsCt4pHZQ9kEPsDiK/+K5VNOaXsygbrmAMnw9XEVin3mqEnwQXD53wGphHR5MgZi8eoraHNR2nKQjMaSaw+/k= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ZYTq7djh; arc=fail smtp.client-ip=40.107.93.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ZYTq7djh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ggJatRjYfoZVtzQRQAS779M+hFt13EISj2ISyFUZeniYOsylfqC5+t2yP0oX10vuHKdV3BUiFCF1DWbZW8vs2NSeKUoa5r9XabhJPJupuxE/oq5T/PSpFrI+yYIf2+d02rJJ6VuwciSD+kXBAN9KUuD1CXG+U5qxJad5TwuMOHSPB75nNQ6g/5bWam779lS5CXWs51lC7PU18oxVXeTLHADondOj1xWeOHJpqklh/GHcr/ZkoICyby3FPIdJ5VRiNV3Nx14f5E6Q4+meQD+W5ROX11KxlU5S947X+hHjD5qeTozfkcfNmnosqxbqUXTO5NhRqAlivDBYABl1o0Z6Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LDbZTTRrRalFNUJNx7F13nnXd0WwvyKGpjTIfJ+WlFM=; b=FQhfyBKWywyuvQvtbQjOnxhFi/kZK0dvR3q9HvNuuM1IofJAQkr02hH1L6lEHaA8zkaax3Jj9ZJcYKwlaEi2hKA3O04OwkNW3HLKvsqekDC9mWl01TwPI4ygW0G1PQKaVZsQvB+Ge/61c+xgYgjkNDTpK2a8LKOCVZFcnK6WL+mRAtn8NtoqIwFoXleAggZSpKxsM73pxF2Z3gtwGmi5QWLbulIcCe41n/pbIXa8HB2Bm3NbPpko4kelfatUQxT/WczRTVJsIde65bys1neml7xbFiz9ZaOuYfMuSGpqGkdYm3KbkeMJUlPk5sOL1RrB1u4V5R0E7M9kfD2BcEfERw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LDbZTTRrRalFNUJNx7F13nnXd0WwvyKGpjTIfJ+WlFM=; b=ZYTq7djhlL7GCG2Gwc0ZAc+RBjhNzNltpl7X18D9U460MApIv88oRAyVzvLl3MYJJDmztCNWnFD3tGYp40bckX8xWISGi6VtPU/FmZ+dVOXyX6eE+78RRhTHEgRAU+eS3x8k3xteafa/abVLtQOrj/nAKa0QDCupyiGzG+UygHRdqMALRH6RvHCJRKlNaVAHXzCzs2liNcy1EcnRmv6tEvqIh/ul+y/usC5sD7bGXjI/qUkfYnY/Jh2zSlymK4EsYxyaGgQ7LhCenBitAAgZa+aZaeMdE5T6QN+cY2ACnoywclq83eI0pVRctNvKi9jhe3XvyB0Wgi+HbmPojOZeQA== Received: from MW2PR16CA0051.namprd16.prod.outlook.com (2603:10b6:907:1::28) by MW5PR12MB5650.namprd12.prod.outlook.com (2603:10b6:303:19e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.28; Mon, 16 Jun 2025 06:47:35 +0000 Received: from SJ5PEPF000001EB.namprd05.prod.outlook.com (2603:10b6:907:1:cafe::c7) by MW2PR16CA0051.outlook.office365.com (2603:10b6:907:1::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.23 via Frontend Transport; Mon, 16 Jun 2025 06:47:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001EB.mail.protection.outlook.com (10.167.242.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.15 via Frontend Transport; Mon, 16 Jun 2025 06:47:34 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Jun 2025 23:47:21 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 15 Jun 2025 23:47:20 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Sun, 15 Jun 2025 23:47:14 -0700 Date: Sun, 15 Jun 2025 23:47:11 -0700 From: Nicolin Chen To: Baolu Lu CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 10/25] iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE_ALLOC ioctl Message-ID: References: <7dfb002613f224f57a069d27e7bf2b306b0a5ba0.1749884998.git.nicolinc@nvidia.com> <1ab8030b-8d2f-4ebe-a280-6d0e4e1d17c7@linux.intel.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1ab8030b-8d2f-4ebe-a280-6d0e4e1d17c7@linux.intel.com> X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EB:EE_|MW5PR12MB5650:EE_ X-MS-Office365-Filtering-Correlation-Id: 55e81667-edcc-45ab-fa18-08ddaca1aca4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9Qqa4uLqSwy0sYhnbIcU7LRbr05x68IiFs41+/F6EURNZIx75DDD/5vvt0Qd?= =?us-ascii?Q?+CUsCpYeBpjvKk4Q1x0nzoSJzYgnzCridGFZujXixgprt5V6OqL2mQaYHusl?= =?us-ascii?Q?IfiRLEj2sFCdCVUtm9ACnOTXVYoFKje1+fkSAjHy4GQ0Gc2LjizhEL+vLK1V?= =?us-ascii?Q?nO1j/aFja75SzLBipjRaslOP7eJo/1MDBqvXtYr9Dv9R5lbA+5es07GCksD4?= =?us-ascii?Q?0fuzNKjiuL84HedophAmNdMmt47802AOR6rvwPhtRPVtoxSppdlO0+b3+q49?= =?us-ascii?Q?YpilzC/AURY4m6RqPyNGVys61ZXxdWHf9iF8UgMTogQ4VS1Jdv+tKoIBjckk?= =?us-ascii?Q?Sp7jPKLfdNmWWianlg3TJXGx26WxgODAmYOTuRviCmqVq+fe9jBxWmNARM4q?= =?us-ascii?Q?g9u0PYIGRy7YL+TRNh6g2VByqmsiQru+1j4E/kYkYtUMszxRjFf09jKmSxNw?= =?us-ascii?Q?OsQnUWoyCEE8PTHDQ6M5rNxR5LDXXoHSr7gHqv6i5lYL6JmmDxuzyiyzjnGY?= =?us-ascii?Q?FQgMI3OoHczea22oJmzyrfrDTVoA5xTV9mtEy47CupdTAimkhk/yANKu1Sdc?= =?us-ascii?Q?JnnPmOl3rpuu3VXbMfoVIaQadLkZ0DWNgTI14iEN7kVEhDDn8xuvFMYE5N4l?= =?us-ascii?Q?mWy5XnzKoNWofOvEG7zZPyrDOk+J3uLj80K9sC0ur5EHVts/t49SAXRX3WWi?= =?us-ascii?Q?VgpNMduxHO619ebdTTL3eVXKOAwrcSJuR7Zrex4G2y8f04cpW5J4vi/i/xm/?= =?us-ascii?Q?tH1UrjoV1HM8dRBjWwVvnN4swsKAvKuTuSFQaWF+IuA9PCZ+wrixFZknob1A?= =?us-ascii?Q?GadTWPfnvTij4btY6WkR1ZF1bAL1iAXZCExHkZNGt6qXdj1snTp959ydMe5e?= =?us-ascii?Q?zswmRgRwIVlZfg8LpzYOrp//GWsVS0BwZyZpUGcl2pspMtm2r078e0l+bm/a?= =?us-ascii?Q?IgJdLEzhZ5/yVQitxXw9xWaT6/yWbp3pMrXhgTa79MulLly6Oznq1Rwm1RiI?= =?us-ascii?Q?/bCyFB+i+MJEt1Fp90NRmw5cRFbLxtJuZ90BGaDdgLN99khNuTg9u6ipvDyT?= =?us-ascii?Q?9d5uXZ7f2Y886r2lEjHEPO3/CUSbyXymI9nCw1hs4Mml7jMu3MhMY1NYzCos?= =?us-ascii?Q?bM2QI8KE5Y49XrviHdgADdqhdSLn0BHEWcYDDgWFDFZy0mJRaEJ6/bwCohCP?= =?us-ascii?Q?/cHssG0HbRr1cmsR4CEoEz4sSCDlugANIR91ltAasGNcy2+1e9YaIg5e/PrD?= =?us-ascii?Q?hNk6/wcNdSMiBUUUg/sdOsZu1mgdk/IPtgBVecz80W2FmY+RfNoZ/wjKwAQi?= =?us-ascii?Q?T8BUiHQ4z0ZnTJctRbzl67IRZioFM/8J6M3RuJB4GlJkbsQLlpCNHfErVGGY?= =?us-ascii?Q?Ttq6eOrgLfkLnzqBmpDrteUp4FUqw8dxgy+WdE8eP6Zeh9JS7ApB3e1vlMo+?= =?us-ascii?Q?flldShUPr53zK8Cip7+vfotJm3qmslAXE0DZTZUJGTe7iiX0HeHxCSysui9z?= =?us-ascii?Q?5arEK4itL6DxTv/WGJSw618ZDEd/Dg23h0cC?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 06:47:34.2357 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55e81667-edcc-45ab-fa18-08ddaca1aca4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5650 On Mon, Jun 16, 2025 at 02:12:04PM +0800, Baolu Lu wrote: > On 6/14/25 15:14, Nicolin Chen wrote: > > + if (!viommu->ops || !viommu->ops->get_hw_queue_size || > > + !viommu->ops->hw_queue_init_phys) { > > + rc = -EOPNOTSUPP; > > + goto out_put_viommu; > > + } Hmm, here it does abort when !viommu->ops->hw_queue_init_phys .. > > + /* > > + * FIXME once ops->hw_queue_init is introduced, this should check "if > > + * ops->hw_queue_init_phys". And "access" should be initialized to NULL. > > + */ > > I just don't follow here. Up until now, only viommu->ops-> > hw_queue_init_phys has been added, which means the current code only > supports hardware queues that access guest memory using physical > addresses. The access object is not needed for the other type of > hardware queue that uses guest IOVA. > > So, why not just abort here if ops->hw_queue_init_phys is not supported > by the IOMMU driver? .. so, it already does. > Leave other logics to the patches that introduce > ops->hw_queue_init? I guess that would make this patch more readible. The patch is doing in the way to support the hw_queue_init_phys case only. It is just adding some extra FIXMEs as the guideline for the future patch adding hw_queue_init op. I personally don't feel these are confusing. Maybe you can help point out what specific wording feels odd here? Maybe "FIXME"s should be "TODO"s? I could also drop all of these guideline if they are considered very unnecessary. Thanks Nicolin