From: Matthew Wilcox <willy@infradead.org>
To: Yunshui Jiang <jiangyunshui@kylinos.cn>
Cc: alexander.deucher@amd.com, chriistian.koenig@amd.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: use kmalloc_array() instead of kmalloc()
Date: Mon, 16 Jun 2025 04:14:55 +0100 [thread overview]
Message-ID: <aE-ML8rLXnLaqHVA@casper.infradead.org> (raw)
In-Reply-To: <20250616025559.2766331-1-jiangyunshui@kylinos.cn>
On Mon, Jun 16, 2025 at 10:55:59AM +0800, Yunshui Jiang wrote:
> @@ -2719,7 +2719,7 @@ static int amdgpu_ras_realloc_eh_data_space(struct amdgpu_device *adev,
> unsigned int old_space = data->count + data->space_left;
> unsigned int new_space = old_space + pages;
> unsigned int align_space = ALIGN(new_space, 512);
> - void *bps = kmalloc(align_space * sizeof(*data->bps), GFP_KERNEL);
> + void *bps = kmalloc(align_space, sizeof(*data->bps), GFP_KERNEL);
... did you compile this?
next prev parent reply other threads:[~2025-06-16 3:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 2:55 [PATCH] drm/amdgpu: use kmalloc_array() instead of kmalloc() Yunshui Jiang
2025-06-16 3:14 ` Matthew Wilcox [this message]
2025-07-24 1:37 ` [PATCH v2] " Yunshui Jiang
2025-07-24 1:48 ` Jeff Johnson
2025-06-16 7:30 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aE-ML8rLXnLaqHVA@casper.infradead.org \
--to=willy@infradead.org \
--cc=alexander.deucher@amd.com \
--cc=chriistian.koenig@amd.com \
--cc=jiangyunshui@kylinos.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).