From: Matthew Wilcox <willy@infradead.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] kernel-doc: Fix symbol matching for dropped suffixes
Date: Mon, 9 Jun 2025 21:53:21 +0100 [thread overview]
Message-ID: <aEdJwQAZrTiKWBFI@casper.infradead.org> (raw)
In-Reply-To: <877c1kbr4z.fsf@trenco.lwn.net>
On Mon, Jun 09, 2025 at 02:23:56PM -0600, Jonathan Corbet wrote:
> "Matthew Wilcox (Oracle)" <willy@infradead.org> writes:
>
> > The support for dropping "_noprof" missed dropping the suffix from
> > exported symbols. That meant that using the :export: feature would
> > look for kernel-doc for (eg) krealloc_noprof() and not find the
> > kernel-doc for krealloc().
> >
> > Fixes: 51a7bf0238c2 (scripts/kernel-doc: drop "_noprof" on function prototypes)
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > ---
> > scripts/lib/kdoc/kdoc_parser.py | 8 ++++++++
> > 1 file changed, 8 insertions(+)
>
> I've applied this. Naturally, it gifts us with a new docs build
> warning:
>
> > Documentation/core-api/mm-api:40: ./mm/slub.c:4936: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> > Documentation/core-api/mm-api:40: ./mm/slub.c:4936: ERROR: Undefined substitution referenced: "--------". [docutils]
>
> I was hoping your other slab patch series address this, but it doesn't
> look that way...?
Indeed it does.
It's a pre-existing bug, that's only unmaked by this patch. Honestly,
I'm not that great at kerneldoc and I was hoping someone like Randy
would notice and fix it ;-)
next prev parent reply other threads:[~2025-06-09 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 14:15 [PATCH] kernel-doc: Fix symbol matching for dropped suffixes Matthew Wilcox (Oracle)
2025-06-07 12:21 ` Mauro Carvalho Chehab
2025-06-09 20:23 ` Jonathan Corbet
2025-06-09 20:53 ` Matthew Wilcox [this message]
2025-06-09 21:09 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEdJwQAZrTiKWBFI@casper.infradead.org \
--to=willy@infradead.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).