From: Matthew Wilcox <willy@infradead.org>
To: "陈涛涛 Taotao Chen" <chentaotao@didiglobal.com>
Cc: "tytso@mit.edu" <tytso@mit.edu>,
"hch@infradead.org" <hch@infradead.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"brauner@kernel.org" <brauner@kernel.org>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com>,
"tursulin@ursulin.net" <tursulin@ursulin.net>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chentao325@qq.com" <chentao325@qq.com>,
"frank.li@vivo.com" <frank.li@vivo.com>
Subject: Re: [PATCH v3 3/4] fs: change write_begin/write_end interface to take struct kiocb *
Date: Fri, 27 Jun 2025 16:52:15 +0100 [thread overview]
Message-ID: <aF6-L5Eu7XieS8aM@casper.infradead.org> (raw)
In-Reply-To: <20250627110257.1870826-4-chentaotao@didiglobal.com>
On Fri, Jun 27, 2025 at 11:03:11AM +0000, 陈涛涛 Taotao Chen wrote:
> @@ -1399,13 +1400,10 @@ static int write_end_fn(handle_t *handle, struct inode *inode,
> }
>
> /*
> - * We need to pick up the new inode size which generic_commit_write gave us
> - * `file' can be NULL - eg, when called from page_symlink().
> - *
Why delete this? It seems still true to me, other than s/file/iocb/
> * ext4 never places buffers on inode->i_mapping->i_private_list. metadata
> * buffers are managed internally.
> */
> -static int ext4_write_end(struct file *file,
> +static int ext4_write_end(const struct kiocb *iocb,
> struct address_space *mapping,
> loff_t pos, unsigned len, unsigned copied,
> struct folio *folio, void *fsdata)
next prev parent reply other threads:[~2025-06-27 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 11:02 [PATCH v3 0/4] fs: refactor write_begin/write_end and add ext4 IOCB_DONTCACHE support 陈涛涛 Taotao Chen
2025-06-27 11:03 ` [PATCH v3 1/4] drm/i915: Use kernel_write() in shmem object create 陈涛涛 Taotao Chen
2025-06-27 11:03 ` [PATCH v3 2/4] drm/i915: Refactor shmem_pwrite() to use kiocb and write_iter 陈涛涛 Taotao Chen
2025-06-27 11:03 ` [PATCH v3 3/4] fs: change write_begin/write_end interface to take struct kiocb * 陈涛涛 Taotao Chen
2025-06-27 15:45 ` Matthew Wilcox
2025-07-02 14:12 ` Taotao Chen
2025-06-27 15:52 ` Matthew Wilcox [this message]
2025-07-02 14:51 ` Taotao Chen
2025-06-27 11:03 ` [PATCH v3 4/4] ext4: support uncached buffered I/O 陈涛涛 Taotao Chen
2025-06-27 17:03 ` Matthew Wilcox
2025-06-30 6:41 ` hch
2025-07-03 11:45 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF6-L5Eu7XieS8aM@casper.infradead.org \
--to=willy@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=airlied@gmail.com \
--cc=brauner@kernel.org \
--cc=chentao325@qq.com \
--cc=chentaotao@didiglobal.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.li@vivo.com \
--cc=hch@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).