From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E2CF2459DC for ; Thu, 19 Jun 2025 14:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750341738; cv=none; b=f/07NHfwueFCfFdiHxI1CdkUUaVb0UwpTXySZViwn8Fvr2/PB4MMcddJj9FBXdOBs3Oq5dyrkuTTKGkCCfCTuBsCTTZN8nckmduLAzxndoeWDjxQefYmLIsRqs2fwV8+ulq054kB23OOXWyH1tAEYx+0jRNnZPgx95u24yiCjMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750341738; c=relaxed/simple; bh=Wezz9bOmQBcQ1TUJ8Bn0jTeSjZaBZvH184Tg1O/8m8c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VnRx0Kb+Mu4l8AHNAsnyrnoG7mifQjpXOzqZKlvRX/jtVofto1UBC+SZMEpm2Ae/3MMrl01bcxapllXCZmxkhbbVrQ0h1WZVJrbKh17Tq5FC4VuQwv8dnm1gko7d1DFIi44QvuV0CwiTzDrYKTwh4sO3CeVYkZtSWstIOPI7GtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=L4cFP12u; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="L4cFP12u" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-55350d0eedeso808390e87.2 for ; Thu, 19 Jun 2025 07:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750341734; x=1750946534; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aVriD3LvP+pMWvbTjI5kbfItE2BHS3ery/f+bu7NdfQ=; b=L4cFP12uTMk8JwfeO0v3GW+A+YPyvB6q4ldEMMIqkzWrA6mrG2mbkpvgLvnH/MvX3z QbTGB+L8OQy+SX9+ByTM++0fJXTsogKi1hFQboJiCvDZZoVhx6EPmt0QHmt1eFN+M8db 1QE+Vtf1bxpzj9WSfjMffuIUT/lIgDzIru17F/wZOEpfKRr8gU/tglCq7DHdBgjfsHoE sKbizAWFathofHFBdLCHMOv+JNRoxbN5+VhFCucJf3Yo4zVHWG18PtPcIFDnH2jDhB6d R6e4QSoaZKy0pskD8DABQ5fxG0vrZZJn+EhlwDWF2dzO1cR23zaNGs5xsZHgbdFJr/te DjEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750341734; x=1750946534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aVriD3LvP+pMWvbTjI5kbfItE2BHS3ery/f+bu7NdfQ=; b=Tc3ZZTZ3pUHnSLWcH85oxkLwmN0aW8PPoeFJDEgEFzlIWIcqzSQCaS+I+lC7gFFshG EIbWO9TOZ4MbzeDMkSq3IzQFruUpfTjVGDJ8G/jZ0vSffyDfbGmoPbNCvU5YUhUYJ9j9 MKRGqGKo2qfSoVf9a+W7ywCa+gl9XJQSCaCVsmOot3daCnqY1N/g1ksivx/a9whZMUEV qtES5ktJSc/lZnomK2RgJEeznv814CYnJeS2NOd3oZq+KQTtLFXuZtEtnpbdeY0myw9G RCq4tvPAtwf9EYIgRsaXhIRzUI9XE3Ckk9nUZfBTKTS3udFhyL2dA174iKSqpgHz7rT1 imow== X-Forwarded-Encrypted: i=1; AJvYcCVG656WR3EILg+dxyvkCzlAzp/1gTFkPnvpsInLSmaz5DcXYX7A1US4/mURLjzM9a1sv7S+/BMJQCo=@vger.kernel.org X-Gm-Message-State: AOJu0YzMeA3bRaSEYDUZcfeBsIJWptmhaSOEV1nEVSsg6Mf3tykkg3jJ jC58VkvMGCvXFsxwQxNNbH3OPtPX0332ytomDX6qucIP/s1HidKQH1Th/w5YyxopeDc= X-Gm-Gg: ASbGncvQ2GKQSZuse6Ro+ePGEXuSLcHmVtT93O0EE+mpxOKnhmKfvHf/ev0dy0Ugg0u B6kOWgLGmL9X7wnilMKurGtEI+t57uJJ1OF9xGMnt7MJ6bas5SpyOGeAM+DwoQMB085EFLuyj9I pF2ps3X+u+ox+VA+sTTIprRzL9hibIrdgYSCtAX3wqiOls7YRDdfoATUfOFcef4it4mlXE6qrRr aZIwN1SraDZp71iePOLUfSFgXECKWHfJ1bO82OrnC7eeTDmGD2r3iG0Dq2VTyxMyrYa/2TVQppP XlvtcYX9rDQkiw958drJ/XyrwN7m0m8MESS4WDR2oQAnv177PtKDZv71BlIdGoxb+PZr3sC1epY = X-Google-Smtp-Source: AGHT+IE8zVuCTN888UI9y/00n231FNOHGEnuXXDDP1EcNgSBpNMrZXqn05vmM5Fu8xUtJ3hiDai1XA== X-Received: by 2002:a05:6512:33ca:b0:553:543d:d963 with SMTP id 2adb3069b0e04-553b6f1ead0mr6203514e87.36.1750341732009; Thu, 19 Jun 2025 07:02:12 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3159b909a81sm253188a91.5.2025.06.19.07.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 07:02:11 -0700 (PDT) Date: Thu, 19 Jun 2025 16:01:56 +0200 From: Petr Mladek To: Anshuman Khandual Cc: linux-mm@kvack.org, Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618041235.1716143-2-anshuman.khandual@arm.com> On Wed 2025-06-18 09:42:34, Anshuman Khandual wrote: > Add a new format for printing page table entries. How many users do you explect, please? This patch adds only one caller. It does not justify the added complexity. > @@ -2542,6 +2545,23 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, > default: > return error_string(buf, end, "(einval)", spec); > } > + case 'p': Please, do not opencode this in the already very long switch(). Move it to a helper function. > + if (fmt[1] == 't' && fmt[2] == 'e') { > + pte_t *pte = (pte_t *)ptr; If the value (pointer) gets dereferenced then please add a basic check: if (check_pointer(&buf, end, ptr, spec)) return buf; > + spec.field_width = 10; > + spec.precision = 8; Is she precision = 8 really needed? I guess that .field_width + ZEROPAD would do the trick. And them maybe special_hex_number() might be used instead of number() and safe a lot of code. > + spec.base = 16; > + spec.flags = SPECIAL | SMALL | ZEROPAD; > + if (sizeof(pte_t) == sizeof(u64)) { > + u64 val = pte_val(*pte); > + > + return number(buf, end, val, spec); > + } > + WARN_ONCE(1, "Non standard pte_t\n"); This is nasty. It should be a compile-time check. And the code should get fixed on all architectures. If it is not easy then it might be a signal that the generic %ppte flag is not a good idea. > + return error_string(buf, end, "(einval)", spec); > + } > + fallthrough; > default: > return default_pointer(buf, end, ptr, spec); > } Best Regards, Petr