linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: corbet@lwn.net, linux-doc@vger.kernel.org,
	workflows@vger.kernel.org, josh@joshtriplett.org,
	kees@kernel.org, konstantin@linuxfoundation.org,
	linux-kernel@vger.kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH 0/4] Add agent coding assistant configuration to Linux kernel
Date: Mon, 28 Jul 2025 07:57:16 -0400	[thread overview]
Message-ID: <aIdlnHcNHvOxVxGF@lappy> (raw)
In-Reply-To: <75d86e96-cb18-4996-998c-da7ac0e97468@suse.cz>

On Mon, Jul 28, 2025 at 09:58:44AM +0200, Vlastimil Babka wrote:
>On 7/27/25 21:57, Sasha Levin wrote:
>> This patch series adds unified configuration and documentation for coding
>> agents working with the Linux kernel codebase. As coding agents
>> become increasingly common in software development, it's important to
>> establish clear guidelines for their use in kernel development.
>
>Hi,
>
>this series seems to me somewhat premature. I think we first need a clear
>policy wrt LLM usage for the *humans* to follow. It seemed this thread [1]
>was going into that direction wrt usage disclosure. BTW I was quite shocked
>by Steven's reply there [2] that he learned from the LWN coverage of a
>conference talk that he had received a patch fully written by LLM without
>any such indication. Now I'm not naive to believe that it's not been
>happening already from e.g. first-time contributors, but if that coverage
>was accurate, the patch came from a very seasoned kernel contributor and I
>really wouldn't expect that to happen.

You mean that you had a concern that the same person who wrote
hashtable.h was using tooling to convert open coded implementations of a
hashtable to the API provided by hashtable.h?

I've been doing this since 2012 (see 42f8570f437b ("workqueue: use new
hashtable implementation")) with the various tools that the we have for
mechanical transmormations of code.

I understand Steve's point of view on this, and this series is here to
tackle the concerns raised both by him and the rest of the community.

>Also I don't know e.g. the copyright and licensing implications of LLM usage
>beyond, say, a smarter automplete are clear? (again, such as writing the
>full patch?) The thread [1] touched on it somewhat but not completely. If
>that's clear already (IANAL), I'd hope that to be also part of such policy.

The LF already has guidance
(https://www.linuxfoundation.org/legal/generative-ai) for this type of
contributions that was created by LF's lawyers.

Clearly we can override, expand, or affirm it if we want to, but just
like you, IANAL.

>I know that your series has patch 4, but that seems to be part of what the
>LLM is supposed to include for its prompt (does it make sense to call it
>"legal requirements" then?). If it fails to e.g. add the "Co-developed-by:"
>there seems to be nothing saying the human should check these things in the
>output.

Right - as pointed to later in the thread, that part is already in
progress.

The approach in this series would be to cover the technical aspects of
supporting whatever policy we end up with.

>So without such policy first, I fear just merging this alone would send the
>message that the kernel is now officially accepting contributions done with
>coding assistants, and those assistants will do the right things based on
>these configuration files, and the developers using the assistants don't
>need to concern themselves with anything more, as it's all covered by the
>configuration.

Note that at the current state of our policies and documentation, if you
were to pretend to be a developer completely unfamiliar with the Linux
Kernel project, the conclusion you'd reach is that the project
"officially" accepts contributions that are in line with LF's policies.

If anything, this series clamps down on that.

-- 
Thanks,
Sasha

  parent reply	other threads:[~2025-07-28 11:57 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 19:57 [PATCH 0/4] Add agent coding assistant configuration to Linux kernel Sasha Levin
2025-07-27 19:57 ` [PATCH 1/4] agents: add unified agent coding assistant configuration Sasha Levin
2025-07-28  2:37   ` Kees Cook
2025-07-28  4:43     ` Sasha Levin
2025-07-28  5:16       ` Kees Cook
2025-07-28  5:39         ` Sasha Levin
2025-07-30 22:06   ` Kevin Hilman
2025-07-30 23:47     ` Sasha Levin
2025-08-01 20:53     ` Rob Herring
2025-08-08 18:07       ` Kevin Hilman
2025-07-27 19:58 ` [PATCH 2/4] agents: add core development references Sasha Levin
2025-07-28  2:39   ` Kees Cook
2025-07-28  5:00     ` Sasha Levin
2025-07-28  5:10       ` Kees Cook
2025-07-28  5:59         ` Sasha Levin
2025-07-28  6:18           ` Kees Cook
2025-07-28 12:35             ` Sasha Levin
2025-07-30 16:25             ` Sasha Levin
2025-07-30 17:35               ` Al Viro
2025-07-30 18:29                 ` Sasha Levin
2025-07-30 18:18               ` Matthew Wilcox
2025-07-30 18:41                 ` Sasha Levin
2025-07-28  4:24   ` Greg KH
2025-07-28  4:52     ` Sasha Levin
2025-07-28  5:02       ` Kees Cook
2025-07-27 19:58 ` [PATCH 3/4] agents: add coding style documentation and rules Sasha Levin
2025-07-28  2:40   ` Kees Cook
2025-07-28  5:10     ` Sasha Levin
2025-07-28  5:21       ` Kees Cook
2025-07-28  6:03         ` Sasha Levin
2025-07-30  9:31           ` Krzysztof Kozlowski
2025-07-30 14:48             ` Jakub Kicinski
2025-07-30 15:10             ` Steven Rostedt
2025-07-27 19:58 ` [PATCH 4/4] agents: add legal requirements and agent attribution guidelines Sasha Levin
2025-07-28  2:43   ` Kees Cook
2025-08-05 22:08   ` Jeff Johnson
2025-08-05 23:11     ` Laurent Pinchart
2025-08-05 23:33       ` Sasha Levin
2025-08-06 14:12   ` Konstantin Ryabitsev
2025-08-06 21:53     ` Sasha Levin
2025-07-28  7:58 ` [PATCH 0/4] Add agent coding assistant configuration to Linux kernel Vlastimil Babka
2025-07-28  9:27   ` David Hildenbrand
2025-07-28 10:37     ` Greg KH
2025-07-28 10:47       ` David Hildenbrand
2025-07-28 13:05         ` Sasha Levin
2025-08-04  9:23           ` Michal Hocko
2025-08-04  9:41             ` Michal Hocko
2025-08-04 13:25             ` Sasha Levin
2025-08-04 22:03               ` Jiri Kosina
2025-08-04 22:14                 ` Steven Rostedt
2025-08-04 22:30                   ` Jiri Kosina
2025-08-04 22:53                   ` dan.j.williams
2025-08-04 23:30                     ` Sasha Levin
2025-08-04 23:39                       ` Laurent Pinchart
2025-08-05 13:29                         ` Steven Rostedt
2025-07-28 11:57   ` Sasha Levin [this message]
2025-07-28  8:42 ` Lorenzo Stoakes
2025-07-28 10:35   ` Greg KH
2025-07-28 10:52     ` Lorenzo Stoakes
2025-07-28 12:45       ` Sasha Levin
2025-07-28 13:13         ` Lorenzo Stoakes
2025-07-28 13:23           ` Sasha Levin
2025-07-28 13:28             ` Lorenzo Stoakes
2025-07-30 15:27       ` Steven Rostedt
2025-07-30 15:34         ` Lorenzo Stoakes
2025-07-30 16:18           ` Steven Rostedt
2025-07-30 16:33             ` Mauro Carvalho Chehab
2025-07-30 16:36             ` Sasha Levin
2025-07-30 16:59               ` Lorenzo Stoakes
2025-07-30 17:12                 ` Sasha Levin
2025-07-30 17:23                   ` Lorenzo Stoakes
2025-07-30 17:32                     ` Steven Rostedt
2025-07-30 18:03                       ` Sasha Levin
2025-07-30 18:18                         ` Lorenzo Stoakes
2025-07-30 18:04                       ` Lorenzo Stoakes
2025-07-30 19:16                         ` Mark Brown
2025-07-30 17:25                   ` Steven Rostedt
2025-07-30 17:34                 ` Mark Brown
2025-07-30 17:36                 ` Kees Cook
2025-08-04 10:20                 ` Jiri Kosina
2025-07-30 17:05               ` Steven Rostedt
2025-07-30 17:46                 ` Sasha Levin
2025-07-30 17:59                   ` Al Viro
2025-07-30 18:10                     ` Sasha Levin
2025-07-30 18:24                       ` Lorenzo Stoakes
2025-07-30 18:59                         ` Sasha Levin
2025-07-30 19:10                     ` Theodore Ts'o
2025-07-30 19:40                       ` Steven Rostedt
2025-07-30 19:51                       ` Al Viro
2025-07-30 19:27                   ` Steven Rostedt
2025-07-31  0:02                   ` Mauro Carvalho Chehab
2025-07-30 16:40             ` Dr. David Alan Gilbert
2025-07-30 17:10               ` Lorenzo Stoakes
2025-07-30 17:20                 ` Steven Rostedt
2025-07-30 17:33                   ` Lorenzo Stoakes
2025-07-30 17:12               ` Steven Rostedt
2025-07-30 17:39                 ` Dr. David Alan Gilbert
2025-07-30 17:51               ` Kees Cook
2025-07-30 16:58             ` Lorenzo Stoakes
2025-07-28 10:56     ` Laurent Pinchart
2025-08-12 18:13 ` Nicolas Frattaroli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aIdlnHcNHvOxVxGF@lappy \
    --to=sashal@kernel.org \
    --cc=corbet@lwn.net \
    --cc=josh@joshtriplett.org \
    --cc=kees@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vbabka@suse.cz \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).