From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: add max17616
Date: Thu, 2 Oct 2025 19:15:09 -0300 [thread overview]
Message-ID: <aN75bfJINa3nV57Y@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20250930-upstream-max17616-v1-1-1525a85f126c@analog.com>
Hi Kim,
For completeness, the dt doc could also have the SMBALERT interrupt.
Though, I see the patch has been accepted and I don't want to make upstreaming
take longer than needed. Maybe the comment below can be taken as follow up
patch suggestion. Though, if you end up doing a v2 for any reason, you can add
my review tag.
Reviewed-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
On 09/30, Kim Seer Paller wrote:
> Add device tree documentation for MAX17616/MAX17616A current-limiter
> with overvoltage/surge, undervoltage, reverse polarity, loss of ground
> protection with PMBus interface.
>
> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> ---
> .../bindings/hwmon/pmbus/adi,max17616.yaml | 48 ++++++++++++++++++++++
> MAINTAINERS | 7 ++++
...
> +properties:
> + compatible:
> + const: adi,max17616
> +
> + reg:
> + maxItems: 1
> +
> + vcc-supply: true
interrupts:
description: Fault condition signal provided on SMBALERT pin.
maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - vcc-supply
> +
Best regards,
Marcelo
next prev parent reply other threads:[~2025-10-02 22:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 5:02 [PATCH 0/2] Add support for MAX17616/MAX17616A hwmon device Kim Seer Paller
2025-09-30 5:02 ` [PATCH 1/2] dt-bindings: hwmon: pmbus: add max17616 Kim Seer Paller
2025-09-30 18:54 ` Conor Dooley
2025-10-02 20:55 ` Guenter Roeck
2025-10-02 22:15 ` Marcelo Schmitt [this message]
2025-09-30 5:02 ` [PATCH 2/2] hwmon: (pmbus/max17616): add driver for max17616 Kim Seer Paller
2025-09-30 10:26 ` Guenter Roeck
2025-10-01 8:17 ` Paller, Kim Seer
2025-10-02 20:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN75bfJINa3nV57Y@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=kimseer.paller@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox