From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1261C189B84; Wed, 15 Oct 2025 16:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760546809; cv=none; b=UkRUStio8P1Bp5LHRCUcIfWBDodm96tNw8I7ZyzPz//3Lr7huMNsjwEj5sAPdjmQup8UGqrqWIU75oDLTAMmFAzwHBCAUQnm497VCxmtMEsVwjmRQXtlfO8a+Jb5EoDP+Zd46RYh57eRmhGjM2BOPB3JbbcfGZQATczWszUz9JE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760546809; c=relaxed/simple; bh=0FFNgUviHoyceqwAxmTDFq28OH826jRwx6eKiDBtnic=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ADzeWmN1MfHoRm0nyJ/ALTrSR7cUUt486qpjwk++4ngICm/8olPkULag3Tu+rj0nAhMleYpvsbwgDvJbKhZ+WxEebmPdrWn5DqYh6tYDVlfbnWZvqLhxVC23XexAzxwYvojaSZ9aE0Apudxm9tZB4VS0NV3wPtGyZVOoRJAqRAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OfXji97u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OfXji97u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7179AC4CEF8; Wed, 15 Oct 2025 16:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760546807; bh=0FFNgUviHoyceqwAxmTDFq28OH826jRwx6eKiDBtnic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OfXji97uoG3XgHw5juL0tZXh1xnYncQ0aojjso9wV/kpxikKg37uBjRkYxztPwIvG w6CBKKmWmoLzPAFdSqUHwKfZMZ23NaZkkisyHySya5v0041rkqYsS+PUKO72BZjHx+ ytagA9wccAVraEB7lA4/ING+gj3PiUFQ2ubnl7QR64JVYBhYOXZ6ljQDgcxcBS+Gme l4twauTa+1rsib58oWR8BY7tSGY9eQkfNKo7U7jQpYg9SRgvNNs9KcFf/A9Q5KgpSN gMPmr11o19K4023AuZ1vcNtZ+BImSAmvzpvW+w54erBx4/HjjZT54jmFqY1eqJHB/T bk3s91j+CVhvQ== Date: Wed, 15 Oct 2025 17:46:40 +0100 From: Simon Horman To: Markus Elfring Cc: Fan Gong , Zhu Yikai , netdev@vger.kernel.org, linux-doc@vger.kernel.org, LKML , Andrew Lunn , Bjorn Helgaas , Christophe Jaillet , Jonathan Corbet , "David S. Miller" , Eric Dumazet , Gur Stavi , Jakub Kicinski , Joe Damato , Lee Trager , luosifu@huawei.com, luoyang82@h-partners.com, Meny Yossefi , Michael Ellerman , Paolo Abeni , Przemek Kitszel , Shen Chenyang , Shi Jing , Suman Ghosh , Vadim Fedorenko , Wu Like , Xin Guo , Zhou Shuai Subject: Re: [PATCH net-next 2/9] hinic3: Add PF management interfaces Message-ID: References: <68ddc5e9191fcb12d1adb666a3e451af6404ec76.1760502478.git.zhuyikai1@h-partners.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Oct 15, 2025 at 12:00:33PM +0200, Markus Elfring wrote: > > To: Fan Gong … > > Please reconsider the distribution of recipient information between message fields > once more. > > > … > > +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.c > > @@ -3,19 +3,325 @@ > … > > +static void mgmt_resp_msg_handler(struct hinic3_msg_pf_to_mgmt *pf_to_mgmt, > > + struct hinic3_recv_msg *recv_msg) > > +{ > … > > + spin_lock(&pf_to_mgmt->sync_event_lock); > > + if (recv_msg->msg_id != pf_to_mgmt->sync_msg_id) { > … > > + } > > + spin_unlock(&pf_to_mgmt->sync_event_lock); > > +} > … > > Will development interests grow to apply a call like “scoped_guard(spinlock, &pf_to_mgmt->sync_event_lock)”? > https://elixir.bootlin.com/linux/v6.17.1/source/include/linux/spinlock.h#L565-L567 Hi Markus, all. It's up to the developer. But there is a still a weak preference for open-coding, as is done above, in Networking code. So in the absence of some other motivation (I have not reviewed this code) I would suggest leaving this as-is. https://docs.kernel.org/process/maintainer-netdev.html#using-device-managed-and-cleanup-h-constructs