From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26FD2F1FD9 for ; Mon, 27 Oct 2025 09:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761557743; cv=none; b=mNWNh1me406WVjicPSHP0aPKU4e8uaVIY8LhI7DI/yRSkLcsj6ADPdIP5K0/L8VvVKrRsrSZ3ElhuM8af0Jq649RnvfBlRNnM5JohUS36qkOSOfCiS0rfsLV1UGi0fNhQDznJyUuEZ2Wajp/5Mtv5g1TS0sxIGBndFgrojyT4C4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761557743; c=relaxed/simple; bh=8etwBx7q2FHyvk00oRcpeTbpjBXjPekvo0X8OpVOLD0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nEkCPdZenPaH32OClVHu8AtpP2qMhJihGoAhVELkxd5iPouNTaiG/fgeKE1OcT+l3WZfE/d7j+tmCokJbOc699yjkkX0EvH4kRRZ3NR0yS0Ng4T7Tiyt55ZVmcX9NBRmTAHfj/tPAaBElMrPvx8Ra1gul2CBBUF6Xodew41HYFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lAledwRt; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lAledwRt" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4710a1f9e4cso36602675e9.0 for ; Mon, 27 Oct 2025 02:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761557740; x=1762162540; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6YOqLOsjgvD3HmEpKNNqQwgAToijdl+SaKUuDAAgKUE=; b=lAledwRt4aOLlOQ4xgMJks5isu7cCTqIsxUUVBDmpLQIIyCDLefKq9UkL5yMf54w64 PM8ICLOT6g0OIf/hgKCX007Ii3O/Mxgv9UsKTOLAbVHVW/atSxlCZR0AbjpCXr5D6Dgq Bru5ZKQG/s9GABNiGxBqGLph5L9emN9aPHcSJkRMWgQ5DKwWcJfpykleLLvIrhK53fRa 4v8KzQeYNrDgwlmgqVFLHiNUSCCBI71O6YZiJlOObHalvgMG+gmbjUv/9gBRUOFuW+Fg y5WiRTPghPEvPiGqZmAUg6+Xh30fk2HUD8zJyp3EhuBhA6/+LS2KUDxeM5U++QgFaT59 by6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761557740; x=1762162540; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6YOqLOsjgvD3HmEpKNNqQwgAToijdl+SaKUuDAAgKUE=; b=FwpfczVnv1ar0dO5HUr+bLFys76Ihtn91gS2qv2qbV/d0/FQt7rrBzeuQsWgCQTHx/ 8YDvzQlP/s+QRNIZ0lj95iSirdOO0PLvdmZn63UP4AINuGFgMCMRXhZYNkQvH5xIfPiX l7VyerPIhVU2ieVwTbSP4G3rzdy+alW6XbDOqJx4tedkL4bZu+cAOpmOzfoi/8Wrtm/Q 76dm5hNMkY8hdLhtr0mUZ4QmQdVGs0GN53eH47zZMOXuBn5KQ8SxOTUfKB26fzrZAJd9 8n9exQ0YifdDRMI02yuUfXGm3/+FSyklXaeZjYmAffP52xj7DuTkfufqXUVa6IG0Uhzz ZOqw== X-Forwarded-Encrypted: i=1; AJvYcCWWFXYY53F4OiOu7s4MJRVFeOK5QtqkHdSnni7Y8GYikWXMqDkBA2rHlWiUscarKmseimks6soeVqk=@vger.kernel.org X-Gm-Message-State: AOJu0YzriT4tEPjjoswhdcOohYmoMSi9uxMiVIfA3RXbZX5nHUxEPwY/ Hh7Dz5EFjOhzrTNeknsRQOH5fWRP4jbNHsw00hqxvtCoeIkbDXeY/CQN X-Gm-Gg: ASbGncu9SXrNOioSbVZjhMaDjtC+Vf5PTYBWiA6gJ0R5l40v4OuKedeTU7smrPz56Gf ZLUn+VmxnLIXLM2UIETx8+lGQLNhl1ToSf255XCAA+4QkpPw/qWulCsTFtKLqglQvmW5b+wp50l xH47Lv3Z8u5fsijoSkMqt2u+pC/ceFbbHvOVyGbF7LzEYxs/cOS1rIeZWKy1sfoKZ5/r1WwALz/ YROh735tNgplvUQnYEN18PgD0hDxIEtnwBrb/f5oC72IjhuXjMoyjcB+mgRJohHbfPW/aP/Gmmv 0+nAq85HzcQG5vUW+LFG4+MZ8+79lGH0WfyCgET5EVEcSxThMQIloz4yHWe5e3MpJhpfAR5XxX3 JnsaDj1kMtWD50ULDwS9EnQuaZRwnRIF+hvEcznHhM/SdIUGBDR8XDhYPIeVxYrOwViTyLnZQ4a mBb8KlFt1t X-Google-Smtp-Source: AGHT+IFmnLTW/ZjkapgUduw0uLpX3pFJyDGuV0GxSTKLvnyxWajP7bnM7PWAmAx3tMJP6BGM4OVYbw== X-Received: by 2002:a05:600c:540b:b0:46e:7247:cbc0 with SMTP id 5b1f17b1804b1-475d2e95fe2mr95277105e9.18.1761557740195; Mon, 27 Oct 2025 02:35:40 -0700 (PDT) Received: from fedora ([94.73.38.14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dcbe5587sm146645965e9.0.2025.10.27.02.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 02:35:39 -0700 (PDT) Date: Mon, 27 Oct 2025 10:35:38 +0100 From: =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= To: Louis Chauvet Cc: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Jonathan Corbet , victoria@system76.com, sebastian.wick@redhat.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 16/22] drm/vkms: Introduce config for connector supported colorspace Message-ID: References: <20251018-vkms-all-config-v1-0-a7760755d92d@bootlin.com> <20251018-vkms-all-config-v1-16-a7760755d92d@bootlin.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251018-vkms-all-config-v1-16-a7760755d92d@bootlin.com> On Sat, Oct 18, 2025 at 04:01:16AM +0200, Louis Chauvet wrote: > To emulate some HDR features of displays, it is required to expose some > properties on HDMI, eDP and DP connectors. > > Signed-off-by: Louis Chauvet > --- > drivers/gpu/drm/vkms/tests/vkms_config_test.c | 3 +++ > drivers/gpu/drm/vkms/vkms_config.c | 1 + > drivers/gpu/drm/vkms/vkms_config.h | 26 ++++++++++++++++++++++++++ > drivers/gpu/drm/vkms/vkms_connector.c | 15 +++++++++++++++ > 4 files changed, 45 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/tests/vkms_config_test.c b/drivers/gpu/drm/vkms/tests/vkms_config_test.c > index 8633210342a4..a89ccd75060d 100644 > --- a/drivers/gpu/drm/vkms/tests/vkms_config_test.c > +++ b/drivers/gpu/drm/vkms/tests/vkms_config_test.c > @@ -187,6 +187,9 @@ static void vkms_config_test_default_config(struct kunit *test) > vkms_config_for_each_connector(config, connector_cfg) { > KUNIT_EXPECT_EQ(test, vkms_config_connector_get_type(connector_cfg), > DRM_MODE_CONNECTOR_VIRTUAL); > + KUNIT_EXPECT_EQ(test, > + vkms_config_connector_get_supported_colorspaces(connector_cfg), > + 0); > } > > KUNIT_EXPECT_TRUE(test, vkms_config_is_valid(config)); > diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c > index 20750c9f6d08..56e2082b91c9 100644 > --- a/drivers/gpu/drm/vkms/vkms_config.c > +++ b/drivers/gpu/drm/vkms/vkms_config.c > @@ -772,6 +772,7 @@ struct vkms_config_connector *vkms_config_create_connector(struct vkms_config *c > connector_cfg->config = config; > connector_cfg->status = connector_status_connected; > vkms_config_connector_set_type(connector_cfg, DRM_MODE_CONNECTOR_VIRTUAL); > + vkms_config_connector_set_supported_colorspaces(connector_cfg, 0); > xa_init_flags(&connector_cfg->possible_encoders, XA_FLAGS_ALLOC); > > list_add_tail(&connector_cfg->link, &config->connectors); > diff --git a/drivers/gpu/drm/vkms/vkms_config.h b/drivers/gpu/drm/vkms/vkms_config.h > index 36d289a010f6..ec614c2d4a30 100644 > --- a/drivers/gpu/drm/vkms/vkms_config.h > +++ b/drivers/gpu/drm/vkms/vkms_config.h > @@ -141,6 +141,7 @@ struct vkms_config_connector { > > int type; > enum drm_connector_status status; > + u32 supported_colorspaces; I don't know much about the specifics of colorspaces, so I'd appreciate some additional feedback in the connector code. Here we could add some docs and also print the value in vkms_config_show(). > struct xarray possible_encoders; > > /* Internal usage */ > @@ -239,6 +240,31 @@ struct vkms_config *vkms_config_default_create(bool enable_cursor, > */ > void vkms_config_destroy(struct vkms_config *config); > > +/** > + * vkms_config_connector_set_supported_colorspaces() - Set the supported colorspaces for a connector > + * @connector_cfg: Connector configuration to modify > + * @supported_colorspaces: Bitmask of supported colorspaces (DRM_COLOR_YCBCR_*) > + */ > +static inline void > +vkms_config_connector_set_supported_colorspaces(struct vkms_config_connector *connector_cfg, > + u32 supported_colorspaces) > +{ > + connector_cfg->supported_colorspaces = supported_colorspaces; > +} > + > +/** > + * vkms_config_connector_get_supported_colorspaces() - Get the supported colorspaces for a connector > + * @connector_cfg: Connector configuration to query > + * > + * Returns: > + * Bitmask of supported colorspaces (DRM_COLOR_YCBCR_*) > + */ > +static inline u32 > +vkms_config_connector_get_supported_colorspaces(struct vkms_config_connector *connector_cfg) > +{ > + return connector_cfg->supported_colorspaces; > +} > + > /** > * vkms_config_get_device_name() - Return the name of the device > * @config: Configuration to get the device name from > diff --git a/drivers/gpu/drm/vkms/vkms_connector.c b/drivers/gpu/drm/vkms/vkms_connector.c > index 5a87dc2d4c63..cc59d13c2d22 100644 > --- a/drivers/gpu/drm/vkms/vkms_connector.c > +++ b/drivers/gpu/drm/vkms/vkms_connector.c > @@ -84,6 +84,21 @@ struct vkms_connector *vkms_connector_init(struct vkms_device *vkmsdev, > if (ret) > return ERR_PTR(ret); > > + if (vkms_config_connector_get_supported_colorspaces(connector_cfg)) { > + if (connector_cfg->type == DRM_MODE_CONNECTOR_HDMIA) { > + drm_mode_create_hdmi_colorspace_property(&connector->base, > + vkms_config_connector_get_supported_colorspaces(connector_cfg)); > + drm_connector_attach_hdr_output_metadata_property(&connector->base); > + drm_connector_attach_colorspace_property(&connector->base); > + } else if (connector_cfg->type == DRM_MODE_CONNECTOR_DisplayPort || > + connector_cfg->type == DRM_MODE_CONNECTOR_eDP) { > + drm_mode_create_dp_colorspace_property(&connector->base, > + vkms_config_connector_get_supported_colorspaces(connector_cfg)); > + drm_connector_attach_hdr_output_metadata_property(&connector->base); > + drm_connector_attach_colorspace_property(&connector->base); > + } > + } > + > drm_connector_helper_add(&connector->base, &vkms_conn_helper_funcs); > > return connector; > > -- > 2.51.0 >