Re: [PATCH net] net: rmnet: Fix checksum offload header v5 and aggregation packet formatting

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3423 bytes --]

On Wed, Oct 15, 2025 at 05:31:53PM +0100, Simon Horman wrote:
> I would like to add the following, which I noticed during review, for your
> consideration.
> 
> diff --git a/Documentation/networking/device_drivers/cellular/qualcomm/rmnet.rst b/Documentation/networking/device_drivers/cellular/qualcomm/rmnet.rst
> index 6877a3260582..b532128ee709 100644
> --- a/Documentation/networking/device_drivers/cellular/qualcomm/rmnet.rst
> +++ b/Documentation/networking/device_drivers/cellular/qualcomm/rmnet.rst
> @@ -27,7 +27,8 @@ these MAP frames and send them to appropriate PDN's.
>  2. Packet format
>  ================
> 
> -a. MAP packet v1 (data / control)
> +A. MAP packet v1 (data / control)
> +---------------------------------
> 
>  MAP header fields are in big endian format.
> 
> @@ -53,7 +54,8 @@ Multiplexer ID is to indicate the PDN on which data has to be sent.
>  Payload length includes the padding length but does not include MAP header
>  length.
> 
> -b. Map packet v4 (data / control)
> +B. Map packet v4 (data / control)
> +---------------------------------
> 
>  MAP header fields are in big endian format.
> 
> @@ -80,7 +82,7 @@ Payload length includes the padding length but does not include MAP header
>  length.
> 
>  Checksum offload header, has the information about the checksum processing done
> -by the hardware.Checksum offload header fields are in big endian format.
> +by the hardware. Checksum offload header fields are in big endian format.
> 
>  Packet format::
> 
> @@ -106,7 +108,8 @@ over which checksum is computed.
> 
>  Checksum value, indicates the checksum computed.
> 
> -c. MAP packet v5 (data / control)
> +C. MAP packet v5 (data / control)
> +---------------------------------
> 
>  MAP header fields are in big endian format.
> 
> @@ -133,7 +136,8 @@ Multiplexer ID is to indicate the PDN on which data has to be sent.
>  Payload length includes the padding length but does not include MAP header
>  length.
> 
> -d. Checksum offload header v5
> +D. Checksum offload header v5
> +-----------------------------
> 
>  Checksum offload header fields are in big endian format.
> 
> @@ -158,7 +162,10 @@ indicates that the calculated packet checksum is invalid.
> 
>  Reserved bits must be zero when sent and ignored when received.
> 
> -e. MAP packet v1/v5 (command specific)::
> +E. MAP packet v1/v5 (command specific)
> +--------------------------------------
> +
> +Packet format::
> 
>      Bit             0             1         2-7      8 - 15           16 - 31
>      Function   Command         Reserved     Pad   Multiplexer ID    Payload length
> @@ -169,7 +176,7 @@ e. MAP packet v1/v5 (command specific)::
>      Bit          96 - 127
>      Function   Command data
> 
> -Command 1 indicates disabling flow while 2 is enabling flow
> +Command 1 indicates disabling flow while 2 enables flow.
> 
>  Command types
> 
> @@ -180,7 +187,8 @@ Command types
>  3 is for error during processing of commands
>  = ==========================================
> 
> -f. Aggregation
> +F. Aggregation
> +--------------
> 
>  Aggregation is multiple MAP packets (can be data or command) delivered to
>  rmnet in a single linear skb. rmnet will process the individual
> 

I think that can go on separate net-next patch.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]