From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux.dev>
Cc: Jonathan Corbet <corbet@lwn.net>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
Samiullah Khawaja <skhawaja@google.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v2 0/2] genpt documentation fixes
Date: Sat, 8 Nov 2025 06:15:26 +0700 [thread overview]
Message-ID: <aQ59jnOE3pFyZPkn@archie.me> (raw)
In-Reply-To: <49ff6f64-b664-4628-af2a-1b46e0fd62ad@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Fri, Nov 07, 2025 at 11:16:36AM -0800, Randy Dunlap wrote:
>
>
> On 11/7/25 12:12 AM, Bagas Sanjaya wrote:
> > Changes since v1 [2]:
> >
> > - s/to set/to read/ (Randy)
>
> That's not quite what I said (wrote):
>
> > @@ -354,6 +354,7 @@ static inline unsigned int pt_max_sw_bit(struct pt_common *common);
> > /**
> > * pt_test_sw_bit_acquire() - Read a software bit in an item
> > * @pts: Entry to set
> > + * @bitnr: Bit to set
>
> | Shouldn't both of these (above) to "to read" instead of "to set"?
>
>
>
> No changes to pt_set_sw_bit_release() [which should say "to set" in 2 places].
>
Oops, I misunderstood the review. Will send the fixup shortly.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-11-07 23:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 8:12 [PATCH v2 0/2] genpt documentation fixes Bagas Sanjaya
2025-11-07 8:13 ` [PATCH v2 1/2] Documentation: genpt: Don't use code block marker before iommu_amdv1.c include listing Bagas Sanjaya
2025-11-07 8:13 ` [PATCH v2 2/2] iommupt: Describe @bitnr parameter Bagas Sanjaya
2025-11-07 19:09 ` Randy Dunlap
2025-11-07 10:07 ` [PATCH v2 0/2] genpt documentation fixes Joerg Roedel
2025-11-07 19:16 ` Randy Dunlap
2025-11-07 23:15 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ59jnOE3pFyZPkn@archie.me \
--to=bagasdotme@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=corbet@lwn.net \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).