* [PATCH] xfs-doc: Fix typo error
@ 2025-11-04 9:34 Gou Hao
2025-11-04 10:57 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Gou Hao @ 2025-11-04 9:34 UTC (permalink / raw)
To: cem, corbet; +Cc: linux-xfs, linux-doc, linux-kernel, gouhaojake, guanwentao
online fsck may take longer than offline fsck...
Signed-off-by: Gou Hao <gouhao@uniontech.com>
---
Documentation/filesystems/xfs/xfs-online-fsck-design.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
index 8cbcd3c26434..55e727b5f12e 100644
--- a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
+++ b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
@@ -249,7 +249,7 @@ sharing and lock acquisition rules as the regular filesystem.
This means that scrub cannot take *any* shortcuts to save time, because doing
so could lead to concurrency problems.
In other words, online fsck is not a complete replacement for offline fsck, and
-a complete run of online fsck may take longer than online fsck.
+a complete run of online fsck may take longer than offline fsck.
However, both of these limitations are acceptable tradeoffs to satisfy the
different motivations of online fsck, which are to **minimize system downtime**
and to **increase predictability of operation**.
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs-doc: Fix typo error
2025-11-04 9:34 [PATCH] xfs-doc: Fix typo error Gou Hao
@ 2025-11-04 10:57 ` Christoph Hellwig
2025-11-04 16:56 ` Darrick J. Wong
2025-11-05 1:35 ` [PATCH V2] " Gou Hao
2 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2025-11-04 10:57 UTC (permalink / raw)
To: Gou Hao
Cc: cem, corbet, linux-xfs, linux-doc, linux-kernel, gouhaojake,
guanwentao
On Tue, Nov 04, 2025 at 05:34:06PM +0800, Gou Hao wrote:
> online fsck may take longer than offline fsck...
The o in online should be capitalized.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs-doc: Fix typo error
2025-11-04 9:34 [PATCH] xfs-doc: Fix typo error Gou Hao
2025-11-04 10:57 ` Christoph Hellwig
@ 2025-11-04 16:56 ` Darrick J. Wong
2025-11-05 1:35 ` [PATCH V2] " Gou Hao
2 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2025-11-04 16:56 UTC (permalink / raw)
To: Gou Hao
Cc: cem, corbet, linux-xfs, linux-doc, linux-kernel, gouhaojake,
guanwentao
On Tue, Nov 04, 2025 at 05:34:06PM +0800, Gou Hao wrote:
> online fsck may take longer than offline fsck...
>
> Signed-off-by: Gou Hao <gouhao@uniontech.com>
With hch's comments about the commit message addressed,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> Documentation/filesystems/xfs/xfs-online-fsck-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
> index 8cbcd3c26434..55e727b5f12e 100644
> --- a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
> +++ b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
> @@ -249,7 +249,7 @@ sharing and lock acquisition rules as the regular filesystem.
> This means that scrub cannot take *any* shortcuts to save time, because doing
> so could lead to concurrency problems.
> In other words, online fsck is not a complete replacement for offline fsck, and
> -a complete run of online fsck may take longer than online fsck.
> +a complete run of online fsck may take longer than offline fsck.
> However, both of these limitations are acceptable tradeoffs to satisfy the
> different motivations of online fsck, which are to **minimize system downtime**
> and to **increase predictability of operation**.
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] xfs-doc: Fix typo error
2025-11-04 9:34 [PATCH] xfs-doc: Fix typo error Gou Hao
2025-11-04 10:57 ` Christoph Hellwig
2025-11-04 16:56 ` Darrick J. Wong
@ 2025-11-05 1:35 ` Gou Hao
2025-11-10 19:50 ` Jonathan Corbet
2 siblings, 1 reply; 5+ messages in thread
From: Gou Hao @ 2025-11-05 1:35 UTC (permalink / raw)
To: cem, corbet, hch, djwong
Cc: linux-xfs, linux-doc, linux-kernel, gouhaojake, guanwentao
Hi Christoph, Darrick,
Thank you for the reviews. Here is the v2 patch with the commit message fixed as suggested.
Subject: [PATCH V2] xfs-doc: Fix typo error
Online fsck may take longer than offline fsck...
Signed-off-by: Gou Hao <gouhao@uniontech.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
---
Documentation/filesystems/xfs/xfs-online-fsck-design.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
index 8cbcd3c26434..55e727b5f12e 100644
--- a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
+++ b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
@@ -249,7 +249,7 @@ sharing and lock acquisition rules as the regular filesystem.
This means that scrub cannot take *any* shortcuts to save time, because doing
so could lead to concurrency problems.
In other words, online fsck is not a complete replacement for offline fsck, and
-a complete run of online fsck may take longer than online fsck.
+a complete run of online fsck may take longer than offline fsck.
However, both of these limitations are acceptable tradeoffs to satisfy the
different motivations of online fsck, which are to **minimize system downtime**
and to **increase predictability of operation**.
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2] xfs-doc: Fix typo error
2025-11-05 1:35 ` [PATCH V2] " Gou Hao
@ 2025-11-10 19:50 ` Jonathan Corbet
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Corbet @ 2025-11-10 19:50 UTC (permalink / raw)
To: Gou Hao, cem, hch, djwong
Cc: linux-xfs, linux-doc, linux-kernel, gouhaojake, guanwentao
Gou Hao <gouhao@uniontech.com> writes:
> Hi Christoph, Darrick,
> Thank you for the reviews. Here is the v2 patch with the commit message fixed as suggested.
This kind of stuff should go below the "---" line so that whoever
applies the patch doesn't need to edit it out.
> Subject: [PATCH V2] xfs-doc: Fix typo error
>
> Online fsck may take longer than offline fsck...
>
> Signed-off-by: Gou Hao <gouhao@uniontech.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
> Documentation/filesystems/xfs/xfs-online-fsck-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've applied it, thanks.
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-11-10 19:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 9:34 [PATCH] xfs-doc: Fix typo error Gou Hao
2025-11-04 10:57 ` Christoph Hellwig
2025-11-04 16:56 ` Darrick J. Wong
2025-11-05 1:35 ` [PATCH V2] " Gou Hao
2025-11-10 19:50 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).