* [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
@ 2025-11-12 22:48 Andy Shevchenko
2025-11-12 23:04 ` Linus Walleij
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Andy Shevchenko @ 2025-11-12 22:48 UTC (permalink / raw)
To: Andy Shevchenko, Levente Révész, linux-gpio, linux-doc,
linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Jonathan Corbet
From: Levente Révész <levente.revesz@eilabs.com>
I went through all the datasheets and created this note listing
chip functions and register layouts.
Signed-off-by: Levente Révész <levente.revesz@eilabs.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
inline reply --> v1: made a formal patch, converted to reST format
Documentation/driver-api/gpio/index.rst | 1 +
Documentation/driver-api/gpio/pca953x.rst | 552 ++++++++++++++++++++++
2 files changed, 553 insertions(+)
create mode 100644 Documentation/driver-api/gpio/pca953x.rst
diff --git a/Documentation/driver-api/gpio/index.rst b/Documentation/driver-api/gpio/index.rst
index 87929840e85a..bee58f709b9a 100644
--- a/Documentation/driver-api/gpio/index.rst
+++ b/Documentation/driver-api/gpio/index.rst
@@ -15,6 +15,7 @@ Contents:
legacy-boards
drivers-on-gpio
bt8xxgpio
+ pca953x
Core
====
diff --git a/Documentation/driver-api/gpio/pca953x.rst b/Documentation/driver-api/gpio/pca953x.rst
new file mode 100644
index 000000000000..4bd7cf1120cb
--- /dev/null
+++ b/Documentation/driver-api/gpio/pca953x.rst
@@ -0,0 +1,552 @@
+============================================
+PCA953x I²C GPIO expander compatibility list
+============================================
+
+:Author: Levente Révész <levente.revesz@eilabs.com>
+
+I went through all the datasheets and created this note listing
+chip functions and register layouts.
+
+Overview of chips
+=================
+
+Chips with the basic 4 registers
+--------------------------------
+
+These chips have 4 register banks: input, output, invert and direction.
+Each of these banks contains (lines/8) registers, one for each GPIO port.
+
+Banks offset is always a power of 2:
+
+- 4 lines -> bank offset is 1
+- 8 lines -> bank offset is 1
+- 16 lines -> bank offset is 2
+- 24 lines -> bank offset is 4
+- 32 lines -> bank offset is 4
+- 40 lines -> bank offset is 8
+
+For example, register layout of GPIO expander with 24 lines:
+
++------+-----------------+--------+
+| addr | function | bank |
++======+=================+========+
+| 00 | input port0 | |
++------+-----------------+ |
+| 01 | input port1 | bank 0 |
++------+-----------------+ |
+| 02 | input port2 | |
++------+-----------------+--------+
+| 03 | n/a | |
++------+-----------------+--------+
+| 04 | output port0 | |
++------+-----------------+ |
+| 05 | output port1 | bank 1 |
++------+-----------------+ |
+| 06 | output port2 | |
++------+-----------------+--------+
+| 07 | n/a | |
++------+-----------------+--------+
+| 08 | invert port0 | |
++------+-----------------+ |
+| 09 | invert port1 | bank 2 |
++------+-----------------+ |
+| 0A | invert port2 | |
++------+-----------------+--------+
+| 0B | n/a | |
++------+-----------------+--------+
+| 0C | direction port0 | |
++------+-----------------+ |
+| 0D | direction port1 | bank 3 |
++------+-----------------+ |
+| 0E | direction port2 | |
++------+-----------------+--------+
+| 0F | n/a | |
++------+-----------------+--------+
+
+.. note::
+ This is followed by all supported chips, except by pcal6534.
+
+The table below shows the offsets for each of the compatible chips:
+
+========== ===== ========= ===== ====== ====== =========
+compatible lines interrupt input output invert direction
+========== ===== ========= ===== ====== ====== =========
+pca9536 4 no 00 01 02 03
+pca9537 4 yes 00 01 02 03
+pca6408 8 yes 00 01 02 03
+tca6408 8 yes 00 01 02 03
+pca9534 8 yes 00 01 02 03
+pca9538 8 yes 00 01 02 03
+pca9554 8 yes 00 01 02 03
+tca9554 8 yes 00 01 02 03
+pca9556 8 no 00 01 02 03
+pca9557 8 no 00 01 02 03
+pca6107 8 yes 00 01 02 03
+pca6416 16 yes 00 02 04 06
+tca6416 16 yes 00 02 04 06
+pca9535 16 yes 00 02 04 06
+pca9539 16 yes 00 02 04 06
+tca9539 16 yes 00 02 04 06
+pca9555 16 yes 00 02 04 06
+max7318 16 yes 00 02 04 06
+tca6424 24 yes 00 04 08 0C
+========== ===== ========= ===== ====== ====== =========
+
+Chips with additional timeout_en register
+-----------------------------------------
+
+These Maxim chips have a bus timeout function which can be enabled in
+the timeout_en register. This is present in only two chips. Defaults to
+timeout disabled.
+
+========== ===== ========= ===== ====== ====== ========= ==========
+compatible lines interrupt input output invert direction timeout_en
+========== ===== ========= ===== ====== ====== ========= ==========
+max7310 8 no 00 01 02 03 04
+max7312 16 yes 00 02 04 06 08
+========== ===== ========= ===== ====== ====== ========= ==========
+
+Chips with additional int_mask register
+---------------------------------------
+
+These chips have an interrupt mask register in addition to the 4 basic
+registers. The interrupt masks default to all interrupts disabled. To
+use interrupts with these chips, the driver has to set the int_mask
+register.
+
+========== ===== ========= ===== ====== ====== ========= ========
+compatible lines interrupt input output invert direction int_mask
+========== ===== ========= ===== ====== ====== ========= ========
+pca9505 40 yes 00 08 10 18 20
+pca9506 40 yes 00 08 10 18 20
+========== ===== ========= ===== ====== ====== ========= ========
+
+Chips with additional int_mask and out_conf registers
+-----------------------------------------------------
+
+This chip has an interrupt mask register, and an output port
+configuration register, which can select between push-pull and
+open-drain modes. Each bit controls two lines. Both of these registers
+are present in PCAL chips as well, albeit the out_conf works
+differently.
+
+========== ===== ========= ===== ====== ====== ========= ======== ========
+compatible lines interrupt input output invert direction int_mask out_conf
+========== ===== ========= ===== ====== ====== ========= ======== ========
+pca9698 40 yes 00 08 10 18 20 28
+========== ===== ========= ===== ====== ====== ========= ======== ========
+
+pca9698 also has a "master output" register for setting all outputs per
+port to the same value simultaneously, and a chip specific mode register
+for various additional chip settings.
+
+========== ============= ====
+compatible master_output mode
+========== ============= ====
+pca9698 29 2A
+========== ============= ====
+
+Chips with LED blink and intensity control
+------------------------------------------
+
+These Maxim chips have no invert register.
+
+They have two sets of output registers (output0 and output1). An internal
+timer alternates the effective output between the values set in these
+registers, if blink mode is enabled in the blink register. The
+master_intensity register and the intensity registers together define
+the PWM intensity value for each pair of outputs.
+
+These chips can be used as simple GPIO expanders if the driver handles the
+input, output0 and direction registers.
+
+========== ===== ========= ===== ======= ========= ======= ================ ===== =========
+compatible lines interrupt input output0 direction output1 master_intensity blink intensity
+========== ===== ========= ===== ======= ========= ======= ================ ===== =========
+max7315 8 yes 00 01 03 09 0E 0F 10
+max7313 16 yes 00 02 06 0A 0E 0F 10
+========== ===== ========= ===== ======= ========= ======= ================ ===== =========
+
+Basic PCAL chips
+----------------
+
+========== ===== ========= ===== ====== ====== =========
+compatible lines interrupt input output invert direction
+========== ===== ========= ===== ====== ====== =========
+pcal6408 8 yes 00 01 02 03
+pcal9554b 8 yes 00 01 02 03
+pcal6416 16 yes 00 02 04 06
+pcal9535 16 yes 00 02 04 06
+pcal9555a 16 yes 00 02 04 06
+========== ===== ========= ===== ====== ====== =========
+
+These chips have several additional features:
+
+ 1. output drive strength setting (out_strength)
+ 2. input latch (in_latch)
+ 3. pull-up/pull-down (pull_in, pull_sel)
+ 4. push-pull/open-drain outputs (out_conf)
+ 5. interrupt mask and interrupt status (int_mask, int_status)
+
+========== ============ ======== ======= ======== ======== ========== ========
+compatible out_strength in_latch pull_en pull_sel int_mask int_status out_conf
+========== ============ ======== ======= ======== ======== ========== ========
+pcal6408 40 42 43 44 45 46 4F
+pcal9554b 40 42 43 44 45 46 4F
+pcal6416 40 44 46 48 4A 4C 4F
+pcal9535 40 44 46 48 4A 4C 4F
+pcal9555a 40 44 46 48 4A 4C 4F
+========== ============ ======== ======= ======== ======== ========== ========
+
+Currently the driver has support for the input latch, pull-up/pull-down
+and uses int_mask and int_status for interrupts.
+
+PCAL chips with extended interrupt and output configuration functions
+---------------------------------------------------------------------
+
+========== ===== ========= ===== ====== ====== =========
+compatible lines interrupt input output invert direction
+========== ===== ========= ===== ====== ====== =========
+pcal6524 24 yes 00 04 08 0C
+pcal6534 34 yes 00 05 0A 0F
+========== ===== ========= ===== ====== ====== =========
+
+These chips have the full PCAL register set, plus the following functions:
+
+ 1. interrupt event selection: level, rising, falling, any edge
+ 2. clear interrupt status per line
+ 3. read input without clearing interrupt status
+ 4. individual output config (push-pull/open-drain) per output line
+ 5. debounce inputs
+
+========== ============ ======== ======= ======== ======== ========== ========
+compatible out_strength in_latch pull_en pull_sel int_mask int_status out_conf
+========== ============ ======== ======= ======== ======== ========== ========
+pcal6524 40 48 4C 50 54 58 5C
+pcal6534 30 3A 3F 44 49 4E 53
+========== ============ ======== ======= ======== ======== ========== ========
+
+========== ======== ========= ============ ============== ======== ==============
+compatible int_edge int_clear input_status indiv_out_conf debounce debounce_count
+========== ======== ========= ============ ============== ======== ==============
+pcal6524 60 68 6C 70 74 76
+pcal6534 54 5E 63 68 6D 6F
+========== ======== ========= ============ ============== ======== ==============
+
+As can be seen in the table above, pcal6534 does not follow the usual
+bank spacing rule. Its banks are closely packed instead.
+
+PCA957X chips with a completely different register layout
+---------------------------------------------------------
+
+These chips have the basic 4 registers, but at unusual addresses.
+
+Additionally, they have:
+
+ 1. pull-up/pull-down (pull_sel)
+ 2. a global pull enable, defaults to disabled (config)
+ 3. interrupt mask, interrupt status (int_mask, int_status)
+
+========== ===== ========= ===== ====== ====== ======== ========= ====== ======== ==========
+compatible lines interrupt input invert config pull_sel direction output int_mask int_status
+========== ===== ========= ===== ====== ====== ======== ========= ====== ======== ==========
+pca9574 8 yes 00 01 02 03 04 05 06 07
+pca9575 16 yes 00 02 04 06 08 0A 0C 0E
+========== ===== ========= ===== ====== ====== ======== ========= ====== ======== ==========
+
+Currently the driver supports none of the advanced features.
+
+XRA1202
+-------
+
+Basic 4 registers, plus advanced features:
+
+ 1. interrupt mask, defaults to interrupts disabled
+ 2. interrupt status
+ 3. interrupt event selection, level, rising, falling, any edge
+ (int_mask, rising_mask, falling_mask)
+ 4. pull-up (no pull-down)
+ 5. tri-state
+ 6. debounce
+
+========== ===== ========= ===== ====== ====== ========= =========
+compatible lines interrupt input output invert direction pullup_en
+========== ===== ========= ===== ====== ====== ========= =========
+xra1202 8 yes 00 01 02 03 04
+========== ===== ========= ===== ====== ====== ========= =========
+
+========== ======== ======== ========== =========== ============ ========
+compatible int_mask tristate int_status rising_mask falling_mask debounce
+========== ======== ======== ========== =========== ============ ========
+xra1202 05 06 07 08 09 0A
+========== ======== ======== ========== =========== ============ ========
+
+Overview of functions
+=====================
+
+This section lists chip functions that are supported by the driver
+already, or are at least common in multiple chips.
+
+Input, Output, Invert, Direction
+--------------------------------
+
+The basic 4 GPIO functions are present in all but one chip category, i.e.
+`Chips with LED blink and intensity control`_ are missing the invert
+register.
+
+3 different layouts are used for these registers:
+
+ 1. banks 0, 1, 2, 3 with bank offsets of 2^n
+ - all other chips
+
+ 2. banks 0, 1, 2, 3 with closely packed banks
+ - pcal6534
+
+ 3. banks 0, 5, 1, 4 with bank offsets of 2^n
+ - pca9574
+ - pca9575
+
+Interrupts
+----------
+
+Only an interrupt mask register
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The same layout is used for all of these:
+
+ 1. bank 5 with bank offsets of 2^n
+ - pca9505
+ - pca9506
+ - pca9698
+
+Interrupt mask and interrupt status registers
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+These work the same way in all of the chips: mask and status have
+one bit per line, 1 in the mask means interrupt enabled.
+
+Layouts:
+
+ 1. base offset 0x40, bank 5 and bank 6, bank offsets of 2^n
+ - pcal6408
+ - pcal6416
+ - pcal9535
+ - pcal9554b
+ - pcal9555a
+ - pcal6524
+
+ 2. base offset 0x30, bank 5 and 6, closely packed banks
+ - pcal6534
+
+ 3. bank 6 and 7, bank offsets of 2^n
+ - pca9574
+ - pca9575
+
+ 4. bank 5 and 7, bank offsets of 2^n
+ - xra1202
+
+Interrupt on specific edges
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+`PCAL chips with extended interrupt and output configuration functions`_
+have an int_edge register. This contains 2 bits per line, one of 4 events
+can be selected for each line:
+
+ 0: level, 1: rising edge, 2: falling edge, 3: any edge
+
+Layouts:
+
+ 1. base offset 0x40, bank 7, bank offsets of 2^n
+
+ - pcal6524
+
+ 2. base offset 0x30, bank 7 + offset 0x01, closely packed banks
+ (out_conf is 1 byte, not (lines/8) bytes, hence the 0x01 offset)
+
+ - pcal6534
+
+`XRA1202`_ chips have a different mechanism for the same thing: they have
+a rising mask and a falling mask, with one bit per line.
+
+Layout:
+
+ 1. bank 5, bank offsets of 2^n
+
+Input latch
+-----------
+
+Only `Basic PCAL chips`_ and
+`PCAL chips with extended interrupt and output configuration functions`_
+have this function. When the latch is enabled, the interrupt is not cleared
+until the input port is read. When the latch is disabled, the interrupt
+is cleared even if the input register is not read, if the input pin returns
+to the logic value it had before generating the interrupt. Defaults to latch
+disabled.
+
+Currently the driver enables the latch for each line with interrupt
+enabled.
+
+ 1. base offset 0x40, bank 2, bank offsets of 2^n
+ - pcal6408
+ - pcal6416
+ - pcal9535
+ - pcal9554b
+ - pcal9555a
+ - pcal6524
+
+ 2. base offset 0x30, bank 2, closely packed banks
+ - pcal6534
+
+Pull-up and pull-down
+---------------------
+
+`Basic PCAL chips`_ and
+`PCAL chips with extended interrupt and output configuration functions`_
+use the same mechanism: their pull_en register enables the pull-up or pull-down
+function, and their pull_sel register chooses the direction. They all use one
+bit per line.
+
+ 0: pull-down, 1: pull-up
+
+Layouts:
+
+ 1. base offset 0x40, bank 3 (en) and 4 (sel), bank offsets of 2^n
+ - pcal6408
+ - pcal6416
+ - pcal9535
+ - pcal9554b
+ - pcal9555a
+ - pcal6524
+
+ 2. base offset 0x30, bank 3 (en) and 4 (sel), closely packed banks
+ - pcal6534
+
+`PCA957X chips with a completely different register layout`_ have a pull_sel
+register with one bit per line, and a global pull_en bit in their config
+register.
+
+Layout:
+
+ 1. bank 2 (config), bank 3 (sel), bank offsets of 2^n
+ - pca9574
+ - pca9575
+
+`XRA1202`_ chips can only pull-up. They have a pullup_en register.
+
+Layout:
+
+ 1. bank 4, bank offsets of 2^n
+ - xra1202
+
+Push-pull and open-drain
+------------------------
+
+`Chips with additional int_mask and out_conf registers`_ have this function,
+but only for select IO ports. Register has 1 bit per 2 lines. In pca9698,
+only port0 and port1 have this function.
+
+ 0: open-drain, 1: push-pull
+
+Layout:
+
+ 1. base offset 5*bankoffset
+ - pca9698
+
+`Basic PCAL chips`_ have 1 bit per port in one single out_conf register.
+Only whole ports can be configured.
+
+ 0: push-pull, 1: open-drain
+
+Layout:
+
+ 1. base offset 0x4F
+ - pcal6408
+ - pcal6416
+ - pcal9535
+ - pcal9554b
+ - pcal9555a
+
+`PCAL chips with extended interrupt and output configuration functions`_
+can set this for each line individually. They have the same per-port out_conf
+register as `Basic PCAL chips`_, but they also have an indiv_out_conf register
+with one bit per line, which inverts the effect of the port-wise setting.
+
+ 0: push-pull, 1: open-drain
+
+Layouts:
+
+ 1. base offset 0x40 + 7*bankoffset (out_conf),
+ base offset 0x60, bank 4 (indiv_out_conf) with bank offset of 2^n
+
+ - pcal6524
+
+ 2. base offset 0x30 + 7*banksize (out_conf),
+ base offset 0x54, bank 4 (indiv_out_conf), closely packed banks
+
+ - pcal6534
+
+This function is currently not supported by the driver.
+
+Output drive strength
+---------------------
+
+Only PCAL chips have this function. 2 bits per line.
+
+==== ==============
+bits drive strength
+==== ==============
+ 00 0.25x
+ 01 0.50x
+ 10 0.75x
+ 11 1.00x
+==== ==============
+
+ 1. base offset 0x40, bank 0 and 1, bank offsets of 2^n
+ - pcal6408
+ - pcal6416
+ - pcal9535
+ - pcal9554b
+ - pcal9555a
+ - pcal6524
+
+ 2. base offset 0x30, bank 0 and 1, closely packed banks
+ - pcal6534
+
+Currently not supported by the driver.
+
+Datasheets
+==========
+
+- MAX7310: https://datasheets.maximintegrated.com/en/ds/MAX7310.pdf
+- MAX7312: https://datasheets.maximintegrated.com/en/ds/MAX7312.pdf
+- MAX7313: https://datasheets.maximintegrated.com/en/ds/MAX7313.pdf
+- MAX7315: https://datasheets.maximintegrated.com/en/ds/MAX7315.pdf
+- MAX7318: https://datasheets.maximintegrated.com/en/ds/MAX7318.pdf
+- PCA6107: https://pdf1.alldatasheet.com/datasheet-pdf/view/161780/TI/PCA6107.html
+- PCA6408A: https://www.nxp.com/docs/en/data-sheet/PCA6408A.pdf
+- PCA6416A: https://www.nxp.com/docs/en/data-sheet/PCA6416A.pdf
+- PCA9505: https://www.nxp.com/docs/en/data-sheet/PCA9505_9506.pdf
+- PCA9505: https://www.nxp.com/docs/en/data-sheet/PCA9505_9506.pdf
+- PCA9534: https://www.nxp.com/docs/en/data-sheet/PCA9534.pdf
+- PCA9535: https://www.nxp.com/docs/en/data-sheet/PCA9535_PCA9535C.pdf
+- PCA9536: https://www.nxp.com/docs/en/data-sheet/PCA9536.pdf
+- PCA9537: https://www.nxp.com/docs/en/data-sheet/PCA9537.pdf
+- PCA9538: https://www.nxp.com/docs/en/data-sheet/PCA9538.pdf
+- PCA9539: https://www.nxp.com/docs/en/data-sheet/PCA9539_PCA9539R.pdf
+- PCA9554: https://www.nxp.com/docs/en/data-sheet/PCA9554_9554A.pdf
+- PCA9555: https://www.nxp.com/docs/en/data-sheet/PCA9555.pdf
+- PCA9556: https://www.nxp.com/docs/en/data-sheet/PCA9556.pdf
+- PCA9557: https://www.nxp.com/docs/en/data-sheet/PCA9557.pdf
+- PCA9574: https://www.nxp.com/docs/en/data-sheet/PCA9574.pdf
+- PCA9575: https://www.nxp.com/docs/en/data-sheet/PCA9575.pdf
+- PCA9698: https://www.nxp.com/docs/en/data-sheet/PCA9698.pdf
+- PCAL6408A: https://www.nxp.com/docs/en/data-sheet/PCAL6408A.pdf
+- PCAL6416A: https://www.nxp.com/docs/en/data-sheet/PCAL6416A.pdf
+- PCAL6524: https://www.nxp.com/docs/en/data-sheet/PCAL6524.pdf
+- PCAL6534: https://www.nxp.com/docs/en/data-sheet/PCAL6534.pdf
+- PCAL9535A: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf
+- PCAL9554B: https://www.nxp.com/docs/en/data-sheet/PCAL9554B_PCAL9554C.pdf
+- PCAL9555A: https://www.nxp.com/docs/en/data-sheet/PCAL9555A.pdf
+- TCA6408A: https://www.ti.com/lit/gpn/tca6408a
+- TCA6416: https://www.ti.com/lit/gpn/tca6416
+- TCA6424: https://www.ti.com/lit/gpn/tca6424
+- TCA9539: https://www.ti.com/lit/gpn/tca9539
+- TCA9554: https://www.ti.com/lit/gpn/tca9554
+- XRA1202: https://assets.maxlinear.com/web/documents/xra1202_1202p_101_042213.pdf
--
2.50.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-12 22:48 [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x Andy Shevchenko
@ 2025-11-12 23:04 ` Linus Walleij
2025-11-13 0:32 ` Randy Dunlap
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2025-11-12 23:04 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Levente Révész, linux-gpio, linux-doc, linux-kernel,
Bartosz Golaszewski, Jonathan Corbet
On Wed, Nov 12, 2025 at 11:49 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> From: Levente Révész <levente.revesz@eilabs.com>
>
> I went through all the datasheets and created this note listing
> chip functions and register layouts.
>
> Signed-off-by: Levente Révész <levente.revesz@eilabs.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Impressive.
Just taking the time and adding some docs for this very popular
GPIO expander is worth an applause because of the general
friendliness for developers.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-12 22:48 [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x Andy Shevchenko
2025-11-12 23:04 ` Linus Walleij
@ 2025-11-13 0:32 ` Randy Dunlap
2025-11-15 1:25 ` Bagas Sanjaya
2025-11-19 11:08 ` Bartosz Golaszewski
3 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2025-11-13 0:32 UTC (permalink / raw)
To: Andy Shevchenko, Levente Révész, linux-gpio, linux-doc,
linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Jonathan Corbet
On 11/12/25 2:48 PM, Andy Shevchenko wrote:
> From: Levente Révész <levente.revesz@eilabs.com>
>
> I went through all the datasheets and created this note listing
> chip functions and register layouts.
>
> Signed-off-by: Levente Révész <levente.revesz@eilabs.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> inline reply --> v1: made a formal patch, converted to reST format
>
> Documentation/driver-api/gpio/index.rst | 1 +
> Documentation/driver-api/gpio/pca953x.rst | 552 ++++++++++++++++++++++
> 2 files changed, 553 insertions(+)
> create mode 100644 Documentation/driver-api/gpio/pca953x.rst
Wowsa. That's a lot of info.
Looks good. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-12 22:48 [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x Andy Shevchenko
2025-11-12 23:04 ` Linus Walleij
2025-11-13 0:32 ` Randy Dunlap
@ 2025-11-15 1:25 ` Bagas Sanjaya
2025-11-18 18:55 ` Andy Shevchenko
2025-11-19 11:08 ` Bartosz Golaszewski
3 siblings, 1 reply; 10+ messages in thread
From: Bagas Sanjaya @ 2025-11-15 1:25 UTC (permalink / raw)
To: Andy Shevchenko, Levente Révész, linux-gpio, linux-doc,
linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Jonathan Corbet
[-- Attachment #1: Type: text/plain, Size: 23756 bytes --]
On Wed, Nov 12, 2025 at 11:48:20PM +0100, Andy Shevchenko wrote:
> diff --git a/Documentation/driver-api/gpio/pca953x.rst b/Documentation/driver-api/gpio/pca953x.rst
> new file mode 100644
> index 000000000000..4bd7cf1120cb
> --- /dev/null
> +++ b/Documentation/driver-api/gpio/pca953x.rst
> @@ -0,0 +1,552 @@
> +============================================
> +PCA953x I²C GPIO expander compatibility list
> +============================================
> +
> +:Author: Levente Révész <levente.revesz@eilabs.com>
> +
> +I went through all the datasheets and created this note listing
> +chip functions and register layouts.
Nit: above first-person intro can be instead edited to:
This document lists chip functions and register layouts for all chips
supported by PCA953x driver.
> +
> +Overview of chips
> +=================
> +
> +Chips with the basic 4 registers
> +--------------------------------
> +
> +These chips have 4 register banks: input, output, invert and direction.
> +Each of these banks contains (lines/8) registers, one for each GPIO port.
> +
> +Banks offset is always a power of 2:
> +
> +- 4 lines -> bank offset is 1
> +- 8 lines -> bank offset is 1
> +- 16 lines -> bank offset is 2
> +- 24 lines -> bank offset is 4
> +- 32 lines -> bank offset is 4
> +- 40 lines -> bank offset is 8
> +
> +For example, register layout of GPIO expander with 24 lines:
> +
> ++------+-----------------+--------+
> +| addr | function | bank |
> ++======+=================+========+
> +| 00 | input port0 | |
> ++------+-----------------+ |
> +| 01 | input port1 | bank 0 |
> ++------+-----------------+ |
> +| 02 | input port2 | |
> ++------+-----------------+--------+
> +| 03 | n/a | |
> ++------+-----------------+--------+
> +| 04 | output port0 | |
> ++------+-----------------+ |
> +| 05 | output port1 | bank 1 |
> ++------+-----------------+ |
> +| 06 | output port2 | |
> ++------+-----------------+--------+
> +| 07 | n/a | |
> ++------+-----------------+--------+
> +| 08 | invert port0 | |
> ++------+-----------------+ |
> +| 09 | invert port1 | bank 2 |
> ++------+-----------------+ |
> +| 0A | invert port2 | |
> ++------+-----------------+--------+
> +| 0B | n/a | |
> ++------+-----------------+--------+
> +| 0C | direction port0 | |
> ++------+-----------------+ |
> +| 0D | direction port1 | bank 3 |
> ++------+-----------------+ |
> +| 0E | direction port2 | |
> ++------+-----------------+--------+
> +| 0F | n/a | |
> ++------+-----------------+--------+
> +
> +.. note::
> + This is followed by all supported chips, except by pcal6534.
Do you mean aforementioned banks offset arrangement?
> +
> +The table below shows the offsets for each of the compatible chips:
> +
> +========== ===== ========= ===== ====== ====== =========
> +compatible lines interrupt input output invert direction
> +========== ===== ========= ===== ====== ====== =========
> +pca9536 4 no 00 01 02 03
> +pca9537 4 yes 00 01 02 03
> +pca6408 8 yes 00 01 02 03
> +tca6408 8 yes 00 01 02 03
> +pca9534 8 yes 00 01 02 03
> +pca9538 8 yes 00 01 02 03
> +pca9554 8 yes 00 01 02 03
> +tca9554 8 yes 00 01 02 03
> +pca9556 8 no 00 01 02 03
> +pca9557 8 no 00 01 02 03
> +pca6107 8 yes 00 01 02 03
> +pca6416 16 yes 00 02 04 06
> +tca6416 16 yes 00 02 04 06
> +pca9535 16 yes 00 02 04 06
> +pca9539 16 yes 00 02 04 06
> +tca9539 16 yes 00 02 04 06
> +pca9555 16 yes 00 02 04 06
> +max7318 16 yes 00 02 04 06
> +tca6424 24 yes 00 04 08 0C
> +========== ===== ========= ===== ====== ====== =========
> +
> +Chips with additional timeout_en register
> +-----------------------------------------
> +
> +These Maxim chips have a bus timeout function which can be enabled in
> +the timeout_en register. This is present in only two chips. Defaults to
> +timeout disabled.
> +
> +========== ===== ========= ===== ====== ====== ========= ==========
> +compatible lines interrupt input output invert direction timeout_en
> +========== ===== ========= ===== ====== ====== ========= ==========
> +max7310 8 no 00 01 02 03 04
> +max7312 16 yes 00 02 04 06 08
> +========== ===== ========= ===== ====== ====== ========= ==========
> +
> +Chips with additional int_mask register
> +---------------------------------------
> +
> +These chips have an interrupt mask register in addition to the 4 basic
> +registers. The interrupt masks default to all interrupts disabled. To
> +use interrupts with these chips, the driver has to set the int_mask
> +register.
> +
> +========== ===== ========= ===== ====== ====== ========= ========
> +compatible lines interrupt input output invert direction int_mask
> +========== ===== ========= ===== ====== ====== ========= ========
> +pca9505 40 yes 00 08 10 18 20
> +pca9506 40 yes 00 08 10 18 20
> +========== ===== ========= ===== ====== ====== ========= ========
> +
> +Chips with additional int_mask and out_conf registers
> +-----------------------------------------------------
> +
> +This chip has an interrupt mask register, and an output port
> +configuration register, which can select between push-pull and
> +open-drain modes. Each bit controls two lines. Both of these registers
> +are present in PCAL chips as well, albeit the out_conf works
> +differently.
> +
> +========== ===== ========= ===== ====== ====== ========= ======== ========
> +compatible lines interrupt input output invert direction int_mask out_conf
> +========== ===== ========= ===== ====== ====== ========= ======== ========
> +pca9698 40 yes 00 08 10 18 20 28
> +========== ===== ========= ===== ====== ====== ========= ======== ========
> +
> +pca9698 also has a "master output" register for setting all outputs per
> +port to the same value simultaneously, and a chip specific mode register
> +for various additional chip settings.
> +
> +========== ============= ====
> +compatible master_output mode
> +========== ============= ====
> +pca9698 29 2A
> +========== ============= ====
> +
> +Chips with LED blink and intensity control
> +------------------------------------------
> +
> +These Maxim chips have no invert register.
> +
> +They have two sets of output registers (output0 and output1). An internal
> +timer alternates the effective output between the values set in these
> +registers, if blink mode is enabled in the blink register. The
> +master_intensity register and the intensity registers together define
> +the PWM intensity value for each pair of outputs.
> +
> +These chips can be used as simple GPIO expanders if the driver handles the
> +input, output0 and direction registers.
> +
> +========== ===== ========= ===== ======= ========= ======= ================ ===== =========
> +compatible lines interrupt input output0 direction output1 master_intensity blink intensity
> +========== ===== ========= ===== ======= ========= ======= ================ ===== =========
> +max7315 8 yes 00 01 03 09 0E 0F 10
> +max7313 16 yes 00 02 06 0A 0E 0F 10
> +========== ===== ========= ===== ======= ========= ======= ================ ===== =========
> +
> +Basic PCAL chips
> +----------------
> +
> +========== ===== ========= ===== ====== ====== =========
> +compatible lines interrupt input output invert direction
> +========== ===== ========= ===== ====== ====== =========
> +pcal6408 8 yes 00 01 02 03
> +pcal9554b 8 yes 00 01 02 03
> +pcal6416 16 yes 00 02 04 06
> +pcal9535 16 yes 00 02 04 06
> +pcal9555a 16 yes 00 02 04 06
> +========== ===== ========= ===== ====== ====== =========
> +
> +These chips have several additional features:
> +
> + 1. output drive strength setting (out_strength)
> + 2. input latch (in_latch)
> + 3. pull-up/pull-down (pull_in, pull_sel)
> + 4. push-pull/open-drain outputs (out_conf)
> + 5. interrupt mask and interrupt status (int_mask, int_status)
> +
> +========== ============ ======== ======= ======== ======== ========== ========
> +compatible out_strength in_latch pull_en pull_sel int_mask int_status out_conf
> +========== ============ ======== ======= ======== ======== ========== ========
> +pcal6408 40 42 43 44 45 46 4F
> +pcal9554b 40 42 43 44 45 46 4F
> +pcal6416 40 44 46 48 4A 4C 4F
> +pcal9535 40 44 46 48 4A 4C 4F
> +pcal9555a 40 44 46 48 4A 4C 4F
> +========== ============ ======== ======= ======== ======== ========== ========
> +
> +Currently the driver has support for the input latch, pull-up/pull-down
> +and uses int_mask and int_status for interrupts.
> +
> +PCAL chips with extended interrupt and output configuration functions
> +---------------------------------------------------------------------
> +
> +========== ===== ========= ===== ====== ====== =========
> +compatible lines interrupt input output invert direction
> +========== ===== ========= ===== ====== ====== =========
> +pcal6524 24 yes 00 04 08 0C
> +pcal6534 34 yes 00 05 0A 0F
> +========== ===== ========= ===== ====== ====== =========
> +
> +These chips have the full PCAL register set, plus the following functions:
> +
> + 1. interrupt event selection: level, rising, falling, any edge
> + 2. clear interrupt status per line
> + 3. read input without clearing interrupt status
> + 4. individual output config (push-pull/open-drain) per output line
> + 5. debounce inputs
> +
> +========== ============ ======== ======= ======== ======== ========== ========
> +compatible out_strength in_latch pull_en pull_sel int_mask int_status out_conf
> +========== ============ ======== ======= ======== ======== ========== ========
> +pcal6524 40 48 4C 50 54 58 5C
> +pcal6534 30 3A 3F 44 49 4E 53
> +========== ============ ======== ======= ======== ======== ========== ========
> +
> +========== ======== ========= ============ ============== ======== ==============
> +compatible int_edge int_clear input_status indiv_out_conf debounce debounce_count
> +========== ======== ========= ============ ============== ======== ==============
> +pcal6524 60 68 6C 70 74 76
> +pcal6534 54 5E 63 68 6D 6F
> +========== ======== ========= ============ ============== ======== ==============
> +
> +As can be seen in the table above, pcal6534 does not follow the usual
> +bank spacing rule. Its banks are closely packed instead.
> +
> +PCA957X chips with a completely different register layout
> +---------------------------------------------------------
> +
> +These chips have the basic 4 registers, but at unusual addresses.
> +
> +Additionally, they have:
> +
> + 1. pull-up/pull-down (pull_sel)
> + 2. a global pull enable, defaults to disabled (config)
> + 3. interrupt mask, interrupt status (int_mask, int_status)
> +
> +========== ===== ========= ===== ====== ====== ======== ========= ====== ======== ==========
> +compatible lines interrupt input invert config pull_sel direction output int_mask int_status
> +========== ===== ========= ===== ====== ====== ======== ========= ====== ======== ==========
> +pca9574 8 yes 00 01 02 03 04 05 06 07
> +pca9575 16 yes 00 02 04 06 08 0A 0C 0E
> +========== ===== ========= ===== ====== ====== ======== ========= ====== ======== ==========
> +
> +Currently the driver supports none of the advanced features.
> +
> +XRA1202
> +-------
> +
> +Basic 4 registers, plus advanced features:
> +
> + 1. interrupt mask, defaults to interrupts disabled
> + 2. interrupt status
> + 3. interrupt event selection, level, rising, falling, any edge
> + (int_mask, rising_mask, falling_mask)
> + 4. pull-up (no pull-down)
> + 5. tri-state
> + 6. debounce
> +
> +========== ===== ========= ===== ====== ====== ========= =========
> +compatible lines interrupt input output invert direction pullup_en
> +========== ===== ========= ===== ====== ====== ========= =========
> +xra1202 8 yes 00 01 02 03 04
> +========== ===== ========= ===== ====== ====== ========= =========
> +
> +========== ======== ======== ========== =========== ============ ========
> +compatible int_mask tristate int_status rising_mask falling_mask debounce
> +========== ======== ======== ========== =========== ============ ========
> +xra1202 05 06 07 08 09 0A
> +========== ======== ======== ========== =========== ============ ========
> +
> +Overview of functions
> +=====================
> +
> +This section lists chip functions that are supported by the driver
> +already, or are at least common in multiple chips.
> +
> +Input, Output, Invert, Direction
> +--------------------------------
> +
> +The basic 4 GPIO functions are present in all but one chip category, i.e.
> +`Chips with LED blink and intensity control`_ are missing the invert
> +register.
> +
> +3 different layouts are used for these registers:
> +
> + 1. banks 0, 1, 2, 3 with bank offsets of 2^n
> + - all other chips
> +
> + 2. banks 0, 1, 2, 3 with closely packed banks
> + - pcal6534
> +
> + 3. banks 0, 5, 1, 4 with bank offsets of 2^n
> + - pca9574
> + - pca9575
> +
> +Interrupts
> +----------
> +
> +Only an interrupt mask register
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +The same layout is used for all of these:
> +
> + 1. bank 5 with bank offsets of 2^n
> + - pca9505
> + - pca9506
> + - pca9698
> +
> +Interrupt mask and interrupt status registers
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +These work the same way in all of the chips: mask and status have
> +one bit per line, 1 in the mask means interrupt enabled.
> +
> +Layouts:
> +
> + 1. base offset 0x40, bank 5 and bank 6, bank offsets of 2^n
> + - pcal6408
> + - pcal6416
> + - pcal9535
> + - pcal9554b
> + - pcal9555a
> + - pcal6524
> +
> + 2. base offset 0x30, bank 5 and 6, closely packed banks
> + - pcal6534
> +
> + 3. bank 6 and 7, bank offsets of 2^n
> + - pca9574
> + - pca9575
> +
> + 4. bank 5 and 7, bank offsets of 2^n
> + - xra1202
> +
> +Interrupt on specific edges
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +`PCAL chips with extended interrupt and output configuration functions`_
> +have an int_edge register. This contains 2 bits per line, one of 4 events
> +can be selected for each line:
> +
> + 0: level, 1: rising edge, 2: falling edge, 3: any edge
> +
> +Layouts:
> +
> + 1. base offset 0x40, bank 7, bank offsets of 2^n
> +
> + - pcal6524
> +
> + 2. base offset 0x30, bank 7 + offset 0x01, closely packed banks
> + (out_conf is 1 byte, not (lines/8) bytes, hence the 0x01 offset)
> +
> + - pcal6534
> +
> +`XRA1202`_ chips have a different mechanism for the same thing: they have
> +a rising mask and a falling mask, with one bit per line.
> +
> +Layout:
> +
> + 1. bank 5, bank offsets of 2^n
> +
> +Input latch
> +-----------
> +
> +Only `Basic PCAL chips`_ and
> +`PCAL chips with extended interrupt and output configuration functions`_
> +have this function. When the latch is enabled, the interrupt is not cleared
> +until the input port is read. When the latch is disabled, the interrupt
> +is cleared even if the input register is not read, if the input pin returns
> +to the logic value it had before generating the interrupt. Defaults to latch
> +disabled.
> +
> +Currently the driver enables the latch for each line with interrupt
> +enabled.
> +
> + 1. base offset 0x40, bank 2, bank offsets of 2^n
> + - pcal6408
> + - pcal6416
> + - pcal9535
> + - pcal9554b
> + - pcal9555a
> + - pcal6524
> +
> + 2. base offset 0x30, bank 2, closely packed banks
> + - pcal6534
> +
> +Pull-up and pull-down
> +---------------------
> +
> +`Basic PCAL chips`_ and
> +`PCAL chips with extended interrupt and output configuration functions`_
> +use the same mechanism: their pull_en register enables the pull-up or pull-down
> +function, and their pull_sel register chooses the direction. They all use one
> +bit per line.
> +
> + 0: pull-down, 1: pull-up
> +
> +Layouts:
> +
> + 1. base offset 0x40, bank 3 (en) and 4 (sel), bank offsets of 2^n
> + - pcal6408
> + - pcal6416
> + - pcal9535
> + - pcal9554b
> + - pcal9555a
> + - pcal6524
> +
> + 2. base offset 0x30, bank 3 (en) and 4 (sel), closely packed banks
> + - pcal6534
> +
> +`PCA957X chips with a completely different register layout`_ have a pull_sel
> +register with one bit per line, and a global pull_en bit in their config
> +register.
> +
> +Layout:
> +
> + 1. bank 2 (config), bank 3 (sel), bank offsets of 2^n
> + - pca9574
> + - pca9575
> +
> +`XRA1202`_ chips can only pull-up. They have a pullup_en register.
> +
> +Layout:
> +
> + 1. bank 4, bank offsets of 2^n
> + - xra1202
> +
> +Push-pull and open-drain
> +------------------------
> +
> +`Chips with additional int_mask and out_conf registers`_ have this function,
> +but only for select IO ports. Register has 1 bit per 2 lines. In pca9698,
> +only port0 and port1 have this function.
> +
> + 0: open-drain, 1: push-pull
> +
> +Layout:
> +
> + 1. base offset 5*bankoffset
> + - pca9698
> +
> +`Basic PCAL chips`_ have 1 bit per port in one single out_conf register.
> +Only whole ports can be configured.
> +
> + 0: push-pull, 1: open-drain
> +
> +Layout:
> +
> + 1. base offset 0x4F
> + - pcal6408
> + - pcal6416
> + - pcal9535
> + - pcal9554b
> + - pcal9555a
> +
> +`PCAL chips with extended interrupt and output configuration functions`_
> +can set this for each line individually. They have the same per-port out_conf
> +register as `Basic PCAL chips`_, but they also have an indiv_out_conf register
> +with one bit per line, which inverts the effect of the port-wise setting.
> +
> + 0: push-pull, 1: open-drain
> +
> +Layouts:
> +
> + 1. base offset 0x40 + 7*bankoffset (out_conf),
> + base offset 0x60, bank 4 (indiv_out_conf) with bank offset of 2^n
> +
> + - pcal6524
> +
> + 2. base offset 0x30 + 7*banksize (out_conf),
> + base offset 0x54, bank 4 (indiv_out_conf), closely packed banks
> +
> + - pcal6534
> +
> +This function is currently not supported by the driver.
> +
> +Output drive strength
> +---------------------
> +
> +Only PCAL chips have this function. 2 bits per line.
> +
> +==== ==============
> +bits drive strength
> +==== ==============
> + 00 0.25x
> + 01 0.50x
> + 10 0.75x
> + 11 1.00x
> +==== ==============
> +
> + 1. base offset 0x40, bank 0 and 1, bank offsets of 2^n
> + - pcal6408
> + - pcal6416
> + - pcal9535
> + - pcal9554b
> + - pcal9555a
> + - pcal6524
> +
> + 2. base offset 0x30, bank 0 and 1, closely packed banks
> + - pcal6534
> +
> +Currently not supported by the driver.
> +
> +Datasheets
> +==========
> +
> +- MAX7310: https://datasheets.maximintegrated.com/en/ds/MAX7310.pdf
> +- MAX7312: https://datasheets.maximintegrated.com/en/ds/MAX7312.pdf
> +- MAX7313: https://datasheets.maximintegrated.com/en/ds/MAX7313.pdf
> +- MAX7315: https://datasheets.maximintegrated.com/en/ds/MAX7315.pdf
> +- MAX7318: https://datasheets.maximintegrated.com/en/ds/MAX7318.pdf
> +- PCA6107: https://pdf1.alldatasheet.com/datasheet-pdf/view/161780/TI/PCA6107.html
> +- PCA6408A: https://www.nxp.com/docs/en/data-sheet/PCA6408A.pdf
> +- PCA6416A: https://www.nxp.com/docs/en/data-sheet/PCA6416A.pdf
> +- PCA9505: https://www.nxp.com/docs/en/data-sheet/PCA9505_9506.pdf
> +- PCA9505: https://www.nxp.com/docs/en/data-sheet/PCA9505_9506.pdf
> +- PCA9534: https://www.nxp.com/docs/en/data-sheet/PCA9534.pdf
> +- PCA9535: https://www.nxp.com/docs/en/data-sheet/PCA9535_PCA9535C.pdf
> +- PCA9536: https://www.nxp.com/docs/en/data-sheet/PCA9536.pdf
> +- PCA9537: https://www.nxp.com/docs/en/data-sheet/PCA9537.pdf
> +- PCA9538: https://www.nxp.com/docs/en/data-sheet/PCA9538.pdf
> +- PCA9539: https://www.nxp.com/docs/en/data-sheet/PCA9539_PCA9539R.pdf
> +- PCA9554: https://www.nxp.com/docs/en/data-sheet/PCA9554_9554A.pdf
> +- PCA9555: https://www.nxp.com/docs/en/data-sheet/PCA9555.pdf
> +- PCA9556: https://www.nxp.com/docs/en/data-sheet/PCA9556.pdf
> +- PCA9557: https://www.nxp.com/docs/en/data-sheet/PCA9557.pdf
> +- PCA9574: https://www.nxp.com/docs/en/data-sheet/PCA9574.pdf
> +- PCA9575: https://www.nxp.com/docs/en/data-sheet/PCA9575.pdf
> +- PCA9698: https://www.nxp.com/docs/en/data-sheet/PCA9698.pdf
> +- PCAL6408A: https://www.nxp.com/docs/en/data-sheet/PCAL6408A.pdf
> +- PCAL6416A: https://www.nxp.com/docs/en/data-sheet/PCAL6416A.pdf
> +- PCAL6524: https://www.nxp.com/docs/en/data-sheet/PCAL6524.pdf
> +- PCAL6534: https://www.nxp.com/docs/en/data-sheet/PCAL6534.pdf
> +- PCAL9535A: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf
> +- PCAL9554B: https://www.nxp.com/docs/en/data-sheet/PCAL9554B_PCAL9554C.pdf
> +- PCAL9555A: https://www.nxp.com/docs/en/data-sheet/PCAL9555A.pdf
> +- TCA6408A: https://www.ti.com/lit/gpn/tca6408a
> +- TCA6416: https://www.ti.com/lit/gpn/tca6416
> +- TCA6424: https://www.ti.com/lit/gpn/tca6424
> +- TCA9539: https://www.ti.com/lit/gpn/tca9539
> +- TCA9554: https://www.ti.com/lit/gpn/tca9554
> +- XRA1202: https://assets.maxlinear.com/web/documents/xra1202_1202p_101_042213.pdf
The rest LGTM.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-15 1:25 ` Bagas Sanjaya
@ 2025-11-18 18:55 ` Andy Shevchenko
2025-11-19 0:55 ` Bagas Sanjaya
2025-11-19 7:51 ` Bartosz Golaszewski
0 siblings, 2 replies; 10+ messages in thread
From: Andy Shevchenko @ 2025-11-18 18:55 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Levente Révész, linux-gpio, linux-doc, linux-kernel,
Linus Walleij, Bartosz Golaszewski, Jonathan Corbet
On Sat, Nov 15, 2025 at 08:25:54AM +0700, Bagas Sanjaya wrote:
> On Wed, Nov 12, 2025 at 11:48:20PM +0100, Andy Shevchenko wrote:
When answering to the long email, please remove unrelated context.
Thanks.
...
> > +I went through all the datasheets and created this note listing
> > +chip functions and register layouts.
>
> Nit: above first-person intro can be instead edited to:
>
> This document lists chip functions and register layouts for all chips
> supported by PCA953x driver.
I believe it's fine to leave author's original text here. Also the proposed
version is not so clear how these document was assembled.
...
> > +.. note::
> > + This is followed by all supported chips, except by pcal6534.
>
> Do you mean aforementioned banks offset arrangement?
Yes. The chapters are per the stuff explained in them, so everything in one
chapter or section is related to the entire chapter or section.
...
> The rest LGTM.
Thank your for looking into this.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-18 18:55 ` Andy Shevchenko
@ 2025-11-19 0:55 ` Bagas Sanjaya
2025-11-19 7:51 ` Bartosz Golaszewski
1 sibling, 0 replies; 10+ messages in thread
From: Bagas Sanjaya @ 2025-11-19 0:55 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Levente Révész, linux-gpio, linux-doc, linux-kernel,
Linus Walleij, Bartosz Golaszewski, Jonathan Corbet
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
On Tue, Nov 18, 2025 at 08:55:22PM +0200, Andy Shevchenko wrote:
> On Sat, Nov 15, 2025 at 08:25:54AM +0700, Bagas Sanjaya wrote:
> > On Wed, Nov 12, 2025 at 11:48:20PM +0100, Andy Shevchenko wrote:
>
> When answering to the long email, please remove unrelated context.
> Thanks.
Thanks for the tip!
>
> ...
>
> > > +I went through all the datasheets and created this note listing
> > > +chip functions and register layouts.
> >
> > Nit: above first-person intro can be instead edited to:
> >
> > This document lists chip functions and register layouts for all chips
> > supported by PCA953x driver.
>
> I believe it's fine to leave author's original text here. Also the proposed
> version is not so clear how these document was assembled.
Ack.
>
> ...
>
> > > +.. note::
> > > + This is followed by all supported chips, except by pcal6534.
> >
> > Do you mean aforementioned banks offset arrangement?
>
> Yes. The chapters are per the stuff explained in them, so everything in one
> chapter or section is related to the entire chapter or section.
Ack.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-18 18:55 ` Andy Shevchenko
2025-11-19 0:55 ` Bagas Sanjaya
@ 2025-11-19 7:51 ` Bartosz Golaszewski
2025-11-19 9:11 ` Andy Shevchenko
1 sibling, 1 reply; 10+ messages in thread
From: Bartosz Golaszewski @ 2025-11-19 7:51 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bagas Sanjaya, Levente Révész, linux-gpio, linux-doc,
linux-kernel, Linus Walleij, Jonathan Corbet
On Tue, Nov 18, 2025 at 7:55 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Sat, Nov 15, 2025 at 08:25:54AM +0700, Bagas Sanjaya wrote:
> > On Wed, Nov 12, 2025 at 11:48:20PM +0100, Andy Shevchenko wrote:
>
> When answering to the long email, please remove unrelated context.
> Thanks.
>
> ...
>
> > > +I went through all the datasheets and created this note listing
> > > +chip functions and register layouts.
> >
> > Nit: above first-person intro can be instead edited to:
> >
> > This document lists chip functions and register layouts for all chips
> > supported by PCA953x driver.
>
> I believe it's fine to leave author's original text here. Also the proposed
> version is not so clear how these document was assembled.
>
> ...
>
> > > +.. note::
> > > + This is followed by all supported chips, except by pcal6534.
> >
> > Do you mean aforementioned banks offset arrangement?
>
> Yes. The chapters are per the stuff explained in them, so everything in one
> chapter or section is related to the entire chapter or section.
>
> ...
>
> > The rest LGTM.
>
> Thank your for looking into this.
>
Is there anything else to address or is it good to go?
Bart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-19 7:51 ` Bartosz Golaszewski
@ 2025-11-19 9:11 ` Andy Shevchenko
2025-11-19 11:06 ` Bagas Sanjaya
0 siblings, 1 reply; 10+ messages in thread
From: Andy Shevchenko @ 2025-11-19 9:11 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Bagas Sanjaya, Levente Révész, linux-gpio, linux-doc,
linux-kernel, Linus Walleij, Jonathan Corbet
On Wed, Nov 19, 2025 at 08:51:54AM +0100, Bartosz Golaszewski wrote:
> On Tue, Nov 18, 2025 at 7:55 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Sat, Nov 15, 2025 at 08:25:54AM +0700, Bagas Sanjaya wrote:
> > > On Wed, Nov 12, 2025 at 11:48:20PM +0100, Andy Shevchenko wrote:
...
> > > The rest LGTM.
> >
> > Thank your for looking into this.
>
> Is there anything else to address or is it good to go?
I believe it's good to go, as per last Bagas' email (as I read it). In any case
it's documentation and can be amended in-tree.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-19 9:11 ` Andy Shevchenko
@ 2025-11-19 11:06 ` Bagas Sanjaya
0 siblings, 0 replies; 10+ messages in thread
From: Bagas Sanjaya @ 2025-11-19 11:06 UTC (permalink / raw)
To: Andy Shevchenko, Bartosz Golaszewski
Cc: Levente Révész, linux-gpio, linux-doc, linux-kernel,
Linus Walleij, Jonathan Corbet
On 11/19/25 16:11, Andy Shevchenko wrote:
> On Wed, Nov 19, 2025 at 08:51:54AM +0100, Bartosz Golaszewski wrote:
>> Is there anything else to address or is it good to go?
>
> I believe it's good to go, as per last Bagas' email (as I read it). In any case
> it's documentation and can be amended in-tree.
>
Hence:
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
2025-11-12 22:48 [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x Andy Shevchenko
` (2 preceding siblings ...)
2025-11-15 1:25 ` Bagas Sanjaya
@ 2025-11-19 11:08 ` Bartosz Golaszewski
3 siblings, 0 replies; 10+ messages in thread
From: Bartosz Golaszewski @ 2025-11-19 11:08 UTC (permalink / raw)
To: Levente Révész, linux-gpio, linux-doc, linux-kernel,
Andy Shevchenko
Cc: Bartosz Golaszewski, Linus Walleij, Bartosz Golaszewski,
Jonathan Corbet
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Wed, 12 Nov 2025 23:48:20 +0100, Andy Shevchenko wrote:
> I went through all the datasheets and created this note listing
> chip functions and register layouts.
>
>
Applied, thanks!
[1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
https://git.kernel.org/brgl/linux/c/5ef5f3c2245e13c62adf4cb0980cdd7bd72c59d0
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-11-19 11:08 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-12 22:48 [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x Andy Shevchenko
2025-11-12 23:04 ` Linus Walleij
2025-11-13 0:32 ` Randy Dunlap
2025-11-15 1:25 ` Bagas Sanjaya
2025-11-18 18:55 ` Andy Shevchenko
2025-11-19 0:55 ` Bagas Sanjaya
2025-11-19 7:51 ` Bartosz Golaszewski
2025-11-19 9:11 ` Andy Shevchenko
2025-11-19 11:06 ` Bagas Sanjaya
2025-11-19 11:08 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).