From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Levente Révész" <levente.revesz@eilabs.com>,
linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Jonathan Corbet" <corbet@lwn.net>
Subject: Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x
Date: Tue, 18 Nov 2025 20:55:22 +0200 [thread overview]
Message-ID: <aRzBGhsLA_s1rJbM@smile.fi.intel.com> (raw)
In-Reply-To: <aRfWouKGA7q2ufCV@archie.me>
On Sat, Nov 15, 2025 at 08:25:54AM +0700, Bagas Sanjaya wrote:
> On Wed, Nov 12, 2025 at 11:48:20PM +0100, Andy Shevchenko wrote:
When answering to the long email, please remove unrelated context.
Thanks.
...
> > +I went through all the datasheets and created this note listing
> > +chip functions and register layouts.
>
> Nit: above first-person intro can be instead edited to:
>
> This document lists chip functions and register layouts for all chips
> supported by PCA953x driver.
I believe it's fine to leave author's original text here. Also the proposed
version is not so clear how these document was assembled.
...
> > +.. note::
> > + This is followed by all supported chips, except by pcal6534.
>
> Do you mean aforementioned banks offset arrangement?
Yes. The chapters are per the stuff explained in them, so everything in one
chapter or section is related to the entire chapter or section.
...
> The rest LGTM.
Thank your for looking into this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-18 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 22:48 [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x Andy Shevchenko
2025-11-12 23:04 ` Linus Walleij
2025-11-13 0:32 ` Randy Dunlap
2025-11-15 1:25 ` Bagas Sanjaya
2025-11-18 18:55 ` Andy Shevchenko [this message]
2025-11-19 0:55 ` Bagas Sanjaya
2025-11-19 7:51 ` Bartosz Golaszewski
2025-11-19 9:11 ` Andy Shevchenko
2025-11-19 11:06 ` Bagas Sanjaya
2025-11-19 11:08 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRzBGhsLA_s1rJbM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bagasdotme@gmail.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=levente.revesz@eilabs.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).