Re: [PATCH v5 5/7] revocable: Add fops replacement

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Thu, Dec 11, 2025 at 10:43:06PM +0900, Laurent Pinchart wrote:
> On Thu, Dec 11, 2025 at 05:36:57PM +0900, Wolfram Sang wrote:
> > 
> > > > Isn't there even prototype code from Dan Williams?
> > > > 
> > > > "[PATCH 1/3] cdev: Finish the cdev api with queued mode support"
> > > > 
> > > > https://lkml.org/lkml/2021/1/20/997
> > > 
> > > I mentioned that in my LPC talk in 2022 :-) I think we should merge that
> > > (or a rebased, possibly improved version of it). I've meant to try
> > > plumbing that series in V4L2 but couldn't find the time so far.
> > 
> > Yes, you mentioned it in 2022 but maybe not everyone in this thread is
> > right now aware of it ;) The patch above got changes requested. I talked
> > to Dan very briefly about it at Maintainers Summit 2023 and he was also
> > open (back then) to pick it up again.
> 
> After discussing with Tzung-Bi today after his presentation (thank you
> Tzung-Bi for your time, it helped me understand the problem you're
> facing better), I wonder if this series is fixing the issue in the right
> place.

Thank you for your time too for providing me some more context.

> At the core of the problem is a devm_kzalloc() call to allocate
> driver-specific data. That data structure is then referenced from a
> cdev, which can dereference is after it gets freed. It seems that
> reference-counting the data structure instead of using devm_kzalloc()
> could be a better solution.

After discussing with you, I recalled this was one of my previous attempts.
See the series [1] and Greg's feedback [2].

I want to provide some more context about the cdev level solution.  I failed
to do so for misc device [3] mainly because all misc devices share a same
cdev [4].  If one of the misc device drivers "revoke" the cdev, all other
drivers stop working.

I'm not saying we shouldn't seek for cdev level solution.  But at least it
doesn't work for misc device.  Still need some other ways for misc devices.

[1] https://lore.kernel.org/chrome-platform/20250721044456.2736300-8-tzungbi@kernel.org/
[2] https://lore.kernel.org/chrome-platform/2025072114-unifier-screen-1594@gregkh/
[3] https://lore.kernel.org/chrome-platform/aQ1xfHuyg1y8eJQ_@google.com/
[4] https://elixir.bootlin.com/linux/v6.17/source/drivers/char/misc.c#L299