Re: [PATCH v4] PCI: endpoint: pci-epf-test: Allow overriding default BAR sizes

[Niklas Cassel <cassel@kernel.org>]

On Thu, Jan 29, 2026 at 02:23:25PM +0100, Niklas Cassel wrote:
> +#define PCI_EPF_TEST_BAR_SIZE_W(_name, _id)				\
> +static ssize_t pci_epf_test_##_name##_store(struct config_item *item,	\
> +					    const char *page,		\
> +					    size_t len)			\
> +{									\
> +	struct config_group *group = to_config_group(item);		\
> +	struct pci_epf_test *epf_test =					\
> +		container_of(group, struct pci_epf_test, group);	\
> +	int val;							\
> +	int ret;							\
> +									\
> +	/*								\
> +	 * BAR sizes can only be modified before binding to an EPC,	\
> +	 * pci_epf_test_alloc_space() is called in .bind().		\

Argh...

This comment was supposed to be:
... EPC,
as pci_epf_test_alloc_space() is called in .bind().

(I forgot to readd the word "as" when rewrapping the comment...)

Mani, if no other comments, perhaps you could fixup while applying?

(Sorry for the trouble...)


Kind regards,
Niklas


> +	 */								\
> +	if (epf_test->epf->epc)						\
> +		return -EINVAL;						\
> +									\
> +	ret = kstrtouint(page, 0, &val);				\
> +	if (ret)							\
> +		return ret;						\
> +									\
> +	if (!is_power_of_2(val))					\
> +		return -EINVAL;						\
> +									\
> +	epf_test->bar_size[_id] = val;					\
> +									\
> +	return len;							\
> +}