From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
linux-renesas-soc@vger.kernel.org,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Antonio Borneo" <antonio.borneo@foss.st.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Lee Jones" <lee@kernel.org>, "Linus Walleij" <linusw@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org,
linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, "Mark Brown" <broonie@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Wilken Gottwalt" <wilken.gottwalt@posteo.net>,
"Will Deacon" <will@kernel.org>
Subject: Re: [RFC PATCH 0/4] hwspinlock: refactor headers into public provider/consumer pair
Date: Mon, 9 Feb 2026 13:35:14 +0200 [thread overview]
Message-ID: <aYnGcsK3jq2wrOHL@smile.fi.intel.com> (raw)
In-Reply-To: <aYnBrN0JRCf9-UjB@ninjato>
On Mon, Feb 09, 2026 at 12:14:52PM +0100, Wolfram Sang wrote:
> > > > > Providers need it, especially the 'priv' member. Consumers won't see it.
> > > >
> > > > But can't we make it opaque?
> > > >
> > > > We may have getters and setters for the priv member...
> > >
> > > I think we could do that.
> > >
> > > Two drivers use the bank member, but only for the device
> > > (lock->bank->dev). That can probably be refactored away, I'd guess.
> >
> > I am willing to develop this series in the above direction. Before
> > though, I'd like to know from hwspinlock maintainers if they agree to
> > this refactoring in general.
>
> Moving maintainers from CC to To ;) Do you, in general, approve this
> change to the headers? I think it is more modern and e.g. the mailbox
> subsystem has a similar structure, a header for the client and a header
> for the controller. And do you also prefer an opaque 'priv' member?
I'm in To and I am fine with this change (but not sure if I'm anyhow
a maintainer in the matter of the series).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-09 11:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 18:46 [RFC PATCH 0/4] hwspinlock: refactor headers into public provider/consumer pair Wolfram Sang
2026-01-25 18:46 ` [RFC PATCH 2/4] hwspinlock: refactor existing headers into consumer.h Wolfram Sang
2026-01-26 9:59 ` [RFC PATCH 0/4] hwspinlock: refactor headers into public provider/consumer pair Andy Shevchenko
2026-01-26 10:13 ` Wolfram Sang
2026-01-26 10:20 ` Andy Shevchenko
2026-01-26 10:29 ` Wolfram Sang
2026-01-27 11:41 ` Wolfram Sang
2026-02-09 11:14 ` Wolfram Sang
2026-02-09 11:35 ` Andy Shevchenko [this message]
2026-02-09 16:13 ` Bjorn Andersson
2026-02-09 19:51 ` Wolfram Sang
2026-02-09 21:37 ` Bjorn Andersson
2026-02-10 7:20 ` Andy Shevchenko
2026-02-10 10:44 ` Wolfram Sang
2026-02-10 15:14 ` Andy Shevchenko
2026-01-26 10:14 ` Wilken Gottwalt
2026-01-26 10:16 ` Wolfram Sang
2026-01-26 10:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYnGcsK3jq2wrOHL@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andy@kernel.org \
--cc=antonio.borneo@foss.st.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=boqun.feng@gmail.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=konradybcio@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mingo@redhat.com \
--cc=nuno.sa@analog.com \
--cc=orsonzhai@gmail.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=samuel@sholland.org \
--cc=skhan@linuxfoundation.org \
--cc=srini@kernel.org \
--cc=tglx@kernel.org \
--cc=wens@kernel.org \
--cc=wilken.gottwalt@posteo.net \
--cc=will@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox