From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60F1C318B92; Mon, 9 Feb 2026 11:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770636927; cv=none; b=XJO64LKckZijKOp8eLnp41JWM6r9rFFjbj53lbbv5BUN4OYONO1gieREdFYhmntF7/OuxhkFCLjx2ZkvczkKRIcisp62IPHI9ZspNTUYTPGZYULcPgJuGZXBXjqeOv7VRved7UiB5FMjcmJWdUgHpbZp/rzbTDzeZCQtTff6X+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770636927; c=relaxed/simple; bh=Xwaqb36Nvj3ZWe9RdJQ2KBhRmKitRe0XNRuCltuMInM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zt9Xg6oYP61iALfx9K+tLbs8EBToQN0W/muIO8b/NvRwJb1NItudibQNAeBAs7m+yGrYO/dBfGn1LC2nKlJGHtYca+PIwRGzsLklNBxMskMe2c2yflxaJJfqQph+3fD2Pjea8olgEi89b2cPKnOr+DhuhcG+amzC7afvmyZ85Zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fgkb65Pv; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fgkb65Pv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770636926; x=1802172926; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Xwaqb36Nvj3ZWe9RdJQ2KBhRmKitRe0XNRuCltuMInM=; b=fgkb65PvveYIsMU8V3L3AyS4goNOZff7OK9R3IE6fYngIDfIdOT16Lh5 5s/hNolK6N2p/4jeqsAnvq49OB/0MeU016S61RqiR5nOlw2t2OR50E8OD r9YZauuDA+VJVIV8UJnxhA8GjvkfDUWjgSgpeOWacSzI3vim3uyM0DeoH ZXvC0ItwARJ1YnQ2+ieo6tZFI0Gl2vAsbRm8TEMjksNs3DraV9hzMuRph qAqe6wqA+b963dTLeMYk3yTs2SCsyjVrrb2UfX7GUwndFyC9Ww7LT+3y8 kGc83V4mwQvH75ryIn6cXNbnVOnh4N72Jmn4EYXJkkTL+eMBdBu8gaVTp w==; X-CSE-ConnectionGUID: MKEqjKGHSE+BaKUWPBRBcQ== X-CSE-MsgGUID: fvqfX0EXQ66Pk1fZLJrngA== X-IronPort-AV: E=McAfee;i="6800,10657,11695"; a="82388016" X-IronPort-AV: E=Sophos;i="6.21,282,1763452800"; d="scan'208";a="82388016" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2026 03:35:25 -0800 X-CSE-ConnectionGUID: ZxoVSCP1Sv6TJkkP0NM1Qg== X-CSE-MsgGUID: XrdCgqgDQnK0u4xyIQwZog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,282,1763452800"; d="scan'208";a="216051310" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.128]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2026 03:35:17 -0800 Date: Mon, 9 Feb 2026 13:35:14 +0200 From: Andy Shevchenko To: Wolfram Sang Cc: Bjorn Andersson , Baolin Wang , linux-renesas-soc@vger.kernel.org, Alexandre Torgue , Andy Shevchenko , Antonio Borneo , Arnd Bergmann , Boqun Feng , Chen-Yu Tsai , Chunyan Zhang , Danilo Krummrich , David Lechner , Greg Kroah-Hartman , Ingo Molnar , Jernej Skrabec , Jonathan Cameron , Jonathan Corbet , Konrad Dybcio , Lee Jones , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Mark Brown , Maxime Coquelin , Nuno =?iso-8859-1?Q?S=E1?= , Orson Zhai , Peter Zijlstra , "Rafael J. Wysocki" , Samuel Holland , Shuah Khan , Srinivas Kandagatla , Thomas Gleixner , Waiman Long , Wilken Gottwalt , Will Deacon Subject: Re: [RFC PATCH 0/4] hwspinlock: refactor headers into public provider/consumer pair Message-ID: References: <20260125184654.17843-6-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Feb 09, 2026 at 12:14:52PM +0100, Wolfram Sang wrote: > > > > > Providers need it, especially the 'priv' member. Consumers won't see it. > > > > > > > > But can't we make it opaque? > > > > > > > > We may have getters and setters for the priv member... > > > > > > I think we could do that. > > > > > > Two drivers use the bank member, but only for the device > > > (lock->bank->dev). That can probably be refactored away, I'd guess. > > > > I am willing to develop this series in the above direction. Before > > though, I'd like to know from hwspinlock maintainers if they agree to > > this refactoring in general. > > Moving maintainers from CC to To ;) Do you, in general, approve this > change to the headers? I think it is more modern and e.g. the mailbox > subsystem has a similar structure, a header for the client and a header > for the controller. And do you also prefer an opaque 'priv' member? I'm in To and I am fine with this change (but not sure if I'm anyhow a maintainer in the matter of the series). -- With Best Regards, Andy Shevchenko