From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Taha Ed-Dafili <0rayn.dev@gmail.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
dlechner@baylibre.com, rdunlap@infradead.org,
skhan@linuxfoundation.org,
linux-kernel-mentees-archive@lists.linuxfoundation.org,
nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net,
lars@metafoo.de, Michael.Hennerich@analog.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/5] iio: accel: adxl345: Implement event scaling for ABI compliance
Date: Tue, 24 Feb 2026 16:58:17 +0200 [thread overview]
Message-ID: <aZ28iZDC6CPB2cZ4@smile.fi.intel.com> (raw)
In-Reply-To: <20260224140351.27288-5-0rayn.dev@gmail.com>
On Tue, Feb 24, 2026 at 02:03:47PM +0000, Taha Ed-Dafili wrote:
> The ADXL345 uses a fixed threshold resolution of 62.5 mg/LSB for
> event-related registers. Previously, the driver reported raw
> values without a scale factor.
>
> Implement IIO_EV_INFO_SCALE for all event types to provide the
> conversion factor (0.612915 m/s^2) as required by the IIO ABI.
>
> Consequently, remove the obsolete comment in adxl345_read_event_value()
> which stated that the scale factor is not applied.
>
> Add explicit write rejection for IIO_EV_INFO_SCALE in
> adxl345_write_event_value() returning -EINVAL.
...
> .mask_shared_by_type =
> BIT(IIO_EV_INFO_ENABLE) |
> - BIT(IIO_EV_INFO_VALUE),
> + BIT(IIO_EV_INFO_VALUE) |
> + BIT(IIO_EV_INFO_SCALE),
Why SCALE can't be squeezed before VALUE? This change brings unneeded churn.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-24 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 14:03 [PATCH v5 0/5] iio: accel: adxl345: Implement event scaling and ABI compliance Taha Ed-Dafili
2026-02-24 14:03 ` [PATCH v5 1/5] docs: iio: adxl345: grammar and formatting cleanups Taha Ed-Dafili
2026-02-24 14:03 ` [PATCH v5 2/5] iio: core: Add IIO_EV_INFO_SCALE to event info Taha Ed-Dafili
2026-02-24 14:03 ` [PATCH v5 3/5] iio: accel: adxl345: Expose IIO_EV_INFO_VALUE for double tap Taha Ed-Dafili
2026-02-24 14:55 ` Andy Shevchenko
2026-02-24 15:03 ` Andy Shevchenko
2026-02-26 15:03 ` Taha Ed-Dafili
2026-02-26 16:02 ` Andy Shevchenko
2026-02-24 14:03 ` [PATCH v5 4/5] iio: accel: adxl345: Implement event scaling for ABI compliance Taha Ed-Dafili
2026-02-24 14:58 ` Andy Shevchenko [this message]
2026-02-24 14:03 ` [PATCH v5 5/5] docs: iio: adxl345: update event attributes and scaling math Taha Ed-Dafili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ28iZDC6CPB2cZ4@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees-archive@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox