From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Taha Ed-Dafili <0rayn.dev@gmail.com>,
jic23@kernel.org, rdunlap@infradead.org,
skhan@linuxfoundation.org,
linux-kernel-mentees-archive@lists.linuxfoundation.org,
nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net,
lars@metafoo.de, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance
Date: Sat, 14 Feb 2026 20:22:22 +0200 [thread overview]
Message-ID: <aZC9Xurq1KcVHuMT@smile.fi.intel.com> (raw)
In-Reply-To: <af774bb9-817d-4d88-9fe3-54468949ea54@baylibre.com>
On Sat, Feb 14, 2026 at 11:02:22AM -0600, David Lechner wrote:
> On 2/8/26 9:05 AM, Taha Ed-Dafili wrote:
> > The ADXL345 uses a fixed threshold resolution of 62.5 mg/LSB for
> > event-related registers. Previously, the driver reported raw
> > values without a scale factor.
> >
> > Implement IIO_EV_INFO_SCALE for all event types to provide the
> > conversion factor (0.612915 m/s^2) as required by the IIO ABI.
...
> > - BIT(IIO_EV_INFO_ENABLE) |
> > + BIT(IIO_EV_INFO_ENABLE) |
What's the difference here?
> > + BIT(IIO_EV_INFO_SCALE) |
> > BIT(IIO_EV_INFO_VALUE),
>
> Would be nice to be consistent and put scale after value as the ones
> at the end.
Would it be better other way around to avoid unneeded churn with touching
the last line?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-14 18:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 15:05 [PATCH v3 0/4] iio: accel: adxl345: Add event scaling and doc fixes Taha Ed-Dafili
2026-02-08 15:05 ` [PATCH v3 1/4] docs: iio: adxl345: fix typos and grammar Taha Ed-Dafili
2026-02-08 15:05 ` [PATCH v3 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info Taha Ed-Dafili
2026-02-08 15:05 ` [PATCH v3 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance Taha Ed-Dafili
2026-02-14 17:02 ` David Lechner
2026-02-14 17:09 ` David Lechner
2026-02-14 18:22 ` Andy Shevchenko [this message]
2026-02-14 21:49 ` Randy Dunlap
2026-02-08 15:05 ` [PATCH v3 4/4] docs: iio: adxl345: update math and examples for scaling Taha Ed-Dafili
2026-02-14 17:11 ` David Lechner
2026-02-15 19:29 ` Jonathan Cameron
2026-02-14 17:21 ` [PATCH v3 0/4] iio: accel: adxl345: Add event scaling and doc fixes Jonathan Cameron
2026-02-15 15:57 ` Jonathan Cameron
2026-02-15 17:11 ` Taha Ed-Dafili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZC9Xurq1KcVHuMT@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees-archive@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox