From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24711230BDB for ; Thu, 19 Feb 2026 08:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771489451; cv=none; b=V+7MBOe7HTo+PV4IbV60vsG0naRgcBmZ/DkgdUe99vDyyXD9Dv2K3pQkBAOFE5r1a0psonOx1vGO54HA2Y9OFOFCX2FSxW9UsSmEJuvI1ftFNJIfWzUVNJuRTnM2YzfZB4yHklZc6AlOM47lIP1vGh9kUQzU0NQDju6IYtzZRDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771489451; c=relaxed/simple; bh=pl8NaGuc07730Vhu9Yi5iYedyPwIa2ZX8U6xHGWonLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gurra6jK4EynEbOODJGmm4/ZEGvh5bnS5ATIfP1FF0WyHCJJMvKZ/Rk04TxMWusZAJ8HLY9bzGUcIqPMl7epK6lOJIXaZeZpD1m8ap5hkensj5Gk8osTRodlaPsT6HMfOhbZgtEbZuScZlMoaTdqWvGNur+Z3jEOuFd1i7oeO+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gKGxken2; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gKGxken2" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4362507f0feso389273f8f.0 for ; Thu, 19 Feb 2026 00:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771489448; x=1772094248; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0GbbSdysg+YFEUJI01k89ruDtqq8bN+fDTrKedLeRl8=; b=gKGxken2WFoZuX42NCCSDHpNUhkhkcbFoI2oSFAAtNqCVSYwcJ1ZZ5YHdMKN0/L/A9 C7GEQFB2FaMYnNMx8qpfCuOgn6gG4jgqzjKRIEGtMI8MZ5kowIdn7Q5h3wlguiR7161G Ee2zBv+SjjSOawkLFJpZuKnR76K9nncojZFMMJ3EtWirhtbZKCkl0yMmQ8oogbpOOCUQ wsu3fkeNNU669hBRsiAqFCPuNeFPpTVi+HqGz+CoVExuvK5vvhwQBvjKYE9Uf+18VQh3 IapODavNdIwRKIguMrscVylxkcg1tqcoHdJm7jIKgOu9U7UN8PyGQZZMNlI3SbbbFJZX cXBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771489448; x=1772094248; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GbbSdysg+YFEUJI01k89ruDtqq8bN+fDTrKedLeRl8=; b=tKtY21UAExUPbMB6epVE6wSdOpgQJQD4A6pud6qd8/LLvplR3/cCBbyu/PDaNBUhFy mJpI9iRU/C40iMZ+rdxIQgTsP6wtCBsx457faqYq09Jn30aHnvXgqrC2EUZGzsMDB31C 3NAEVn8hBfS0GsdPUasgBhg1/kGpg7km+k0JktVqx5ywrQb8sAEq+w/bIPD3v+H/pAr+ xF1McaC38h4I/8twQ1fLFeso/DUywfch6k6KgUeuICkuMurmzaZB9LeSScpP66lphkh6 vy4Yk7l7wzwinyg0/JxvNIrXTCIRLoIGRuMjmVcejL7vxrYhX4iaJCzeUB25ZtBpJ0Kf dLqw== X-Forwarded-Encrypted: i=1; AJvYcCXar778Q7zg+sgWoq0SeMIzqk35Qi4BuM6lR0B1SV7yAn57BVzs1mP6/4naMaTdDad8Wjvk84IAtw8=@vger.kernel.org X-Gm-Message-State: AOJu0YxZOD/G6sL/P854uzfnMjdKK7eGVTwj712ExIzSeBhCH9bjL+tk JLVDjEnZHJjKsVcDtbg4H7XuO4judNuVoiWGZuowt8cyYguH0a0CMJBHyRmIqFZTwow= X-Gm-Gg: AZuq6aL04kYCQIMFlljTZhp4+/zjrqkRJbQ5otn2A4+rAeSw4grD+x2YmB0FTzc3cAY 2yXmPViHHzrqXVKja9BOURTeY6CtMeMSPhdUubmsQ1b8SrlYb6WH10MS9QdEygYW68o5B/+LWqr YhGC2hG6Ho+nKJMIg9hhtEqQJSbxTueiRYW4heOryNENyaKgFfRfUPpO4z2aQ4PrPXTERY/qMl7 3GFS7hOkO6zhpv1CwdRbPgxs/OSs8LHrl3pAO+NaAJbmOKyp55aM3rkSQCrHTv9jc2p0LyAkWnw rcEIZUe4XKp5b4QN0R1ONHn0cLzcph6+AhG4e7Vs6eXzlItIaMZOwArBZYxoxgULwfXopSRh2Pf yVt/O5JVPjMaJ6l1IGZfGT5yipRfEPw155hCp17krGmndkQgJIUYwCAq8ZnSA+E/u4DJZXMzRMC NwmH/QOAA1L/Mt4zqPDn5WN86sFMyo X-Received: by 2002:a05:600c:6912:b0:483:456a:5146 with SMTP id 5b1f17b1804b1-4837108fed4mr354407295e9.25.1771489448240; Thu, 19 Feb 2026 00:24:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4836ff00332sm412241365e9.2.2026.02.19.00.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 00:24:07 -0800 (PST) Date: Thu, 19 Feb 2026 11:24:04 +0300 From: Dan Carpenter To: Kees Cook Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Gustavo A . R . Silva" , Bill Wendling , Justin Stitt , Jann Horn , Przemek Kitszel , Marco Elver , Linus Torvalds , Greg Kroah-Hartman , Sasha Levin , linux-mm@kvack.org, Randy Dunlap , Miguel Ojeda , Matthew Wilcox , John Hubbard , Joe Perches , Vegard Nossum , Harry Yoo , Nathan Chancellor , Peter Zijlstra , Nick Desaulniers , Jonathan Corbet , Jakub Kicinski , Yafang Shao , Tony Ambardar , Alexander Lobakin , Jan Hendrik Farr , Alexander Potapenko , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v6 1/5] slab: Introduce kmalloc_obj() and family Message-ID: References: <20251203233029.it.641-kees@kernel.org> <20251203233036.3212363-1-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 19, 2026 at 11:01:04AM +0300, Dan Carpenter wrote: > On Wed, Dec 03, 2025 at 03:30:31PM -0800, Kees Cook wrote: > > Introduce type-aware kmalloc-family helpers to replace the common > > idioms for single object and arrays of objects allocation: > > > > ptr = kmalloc(sizeof(*ptr), gfp); > > ptr = kmalloc(sizeof(struct some_obj_name), gfp); > > ptr = kzalloc(sizeof(*ptr), gfp); > > ptr = kmalloc_array(count, sizeof(*ptr), gfp); > > ptr = kcalloc(count, sizeof(*ptr), gfp); > > > > These become, respectively: > > > > ptr = kmalloc_obj(*ptr, gfp); > > We are already getting patches that covert these to: > > ptr = kmalloc_obj(ptr, gfp); > > (without the *). This feels like the obvious bug people will introduce > with this API. I sort of think that "ptr = kmalloc_obj(ptr, gfp);" is > more natural, so maybe we could make it work that way instead? Never mind. It causes a compile error when people leave out the asterisk. Thanks for that. regards, dan carpenter